From: Guenter Roeck <guenter.roeck@ericsson.com>
To: Joe Perches <joe@perches.com>
Cc: Jean Delvare <khali@linux-fr.org>,
Andy Whitcroft <apw@canonical.com>,
Andrew Morton <akpm@linux-foundation.org>,
Randy Dunlap <rdunlap@xenotime.net>,
Hans de Goede <hdegoede@redhat.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Samuel Ortiz <sameo@linux.intel.com>,
"David S. Miller" <davem@davemloft.net>,
Paul Goyette <paul@whooppee.com>,
"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>
Subject: Re: [PATCH] scripts/checkpatch.pl: Add strict test of logical test continuations at beginning of line
Date: Sun, 11 Jul 2010 14:15:47 -0700 [thread overview]
Message-ID: <20100711211547.GA24666@ericsson.com> (raw)
In-Reply-To: <1278877979.1501.76.camel@Joe-Laptop.home>
On Sun, Jul 11, 2010 at 03:52:59PM -0400, Joe Perches wrote:
> On Sun, 2010-07-11 at 21:34 +0200, Jean Delvare wrote:
> > On Sun, 11 Jul 2010 11:57:12 -0700, Joe Perches wrote:
> > > I don't remember that discussion. Link?
> > http://lkml.org/lkml/2009/12/5/65
> > You started the thread, so I would think you'd remember it.
>
> Though there are differences in opinion about what's important,
> I try to forget the trivial. Just ask my sweet wife...
>
Same issue hit me twice now, so it isn't as if nobody cares.
For my part, I don't care where to put the &&. But I would like to have a means
to get beyond the basic stuff before submitting my patches, to give reviewers
an opportunity to find the _real_ problems in my code.
Guenter
next prev parent reply other threads:[~2010-07-11 21:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-11 14:53 [PATCH v2] hwmon: Add support for JEDEC JC 42.4 compliant temperature sensors Guenter Roeck
2010-07-11 15:31 ` Joe Perches
2010-07-11 16:16 ` Guenter Roeck
2010-07-11 16:21 ` Jean Delvare
2010-07-11 18:57 ` [PATCH] scripts/checkpatch.pl: Add strict test of logical test continuations at beginning of line Joe Perches
2010-07-11 19:34 ` Jean Delvare
2010-07-11 19:52 ` Joe Perches
2010-07-11 21:15 ` Guenter Roeck [this message]
2010-07-12 22:49 ` [PATCH v2] hwmon: Add support for JEDEC JC 42.4 compliant temperature sensors Andrew Morton
2010-07-12 23:07 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100711211547.GA24666@ericsson.com \
--to=guenter.roeck@ericsson.com \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=davem@davemloft.net \
--cc=hdegoede@redhat.com \
--cc=joe@perches.com \
--cc=khali@linux-fr.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=paul@whooppee.com \
--cc=rdunlap@xenotime.net \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®