From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932334AbbAPBQk (ORCPT ); Thu, 15 Jan 2015 20:16:40 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:33054 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932275AbbAPBQj (ORCPT ); Thu, 15 Jan 2015 20:16:39 -0500 Date: Thu, 15 Jan 2015 17:16:27 -0800 From: Andrew Morton To: Joonsoo Kim Cc: Vlastimil Babka , Mel Gorman , David Rientjes , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/5] mm/compaction: enhance tracepoint output for compaction begin/end Message-Id: <20150115171627.91b51c2e.akpm@linux-foundation.org> In-Reply-To: <1421307673-24084-2-git-send-email-iamjoonsoo.kim@lge.com> References: <1421307673-24084-1-git-send-email-iamjoonsoo.kim@lge.com> <1421307673-24084-2-git-send-email-iamjoonsoo.kim@lge.com> X-Mailer: Sylpheed 2.7.1 (GTK+ 2.18.9; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 15 Jan 2015 16:41:10 +0900 Joonsoo Kim wrote: > We now have tracepoint for begin event of compaction and it prints > start position of both scanners, but, tracepoint for end event of > compaction doesn't print finish position of both scanners. It'd be > also useful to know finish position of both scanners so this patch > add it. It will help to find odd behavior or problem on compaction > internal logic. > > And, mode is added to both begin/end tracepoint output, since > according to mode, compaction behavior is quite different. > > And, lastly, status format is changed to string rather than > status number for readability. > > ... > > + TP_printk("zone_start=0x%lx migrate_pfn=0x%lx free_pfn=0x%lx zone_end=0x%lx, mode=%s status=%s", > + __entry->zone_start, > + __entry->migrate_pfn, > + __entry->free_pfn, > + __entry->zone_end, > + __entry->sync ? "sync" : "async", > + compaction_status_string[__entry->status]) > ); > > #endif /* _TRACE_COMPACTION_H */ > diff --git a/mm/compaction.c b/mm/compaction.c > index 546e571..2d86a20 100644 > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -19,6 +19,14 @@ > #include "internal.h" > > #ifdef CONFIG_COMPACTION > +char *compaction_status_string[] = { > + "deferred", > + "skipped", > + "continue", > + "partial", > + "complete", > +}; compaction_status_string[] is unreferenced if tracing is disabled - more ifdeffery is needed?