From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932449AbbI3RTE (ORCPT ); Wed, 30 Sep 2015 13:19:04 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:58995 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753655AbbI3RTB (ORCPT ); Wed, 30 Sep 2015 13:19:01 -0400 Date: Wed, 30 Sep 2015 18:18:52 +0100 From: Mark Brown To: Rasmus Villemoes Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org Message-ID: <20150930171852.GD15635@sirena.org.uk> References: <1443479342-31621-1-git-send-email-linux@rasmusvillemoes.dk> <1443479342-31621-2-git-send-email-linux@rasmusvillemoes.dk> <20150929183024.GC30445@sirena.org.uk> <878u7okzfe.fsf@rasmusvillemoes.dk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="JgQwtEuHJzHdouWu" Content-Disposition: inline In-Reply-To: <878u7okzfe.fsf@rasmusvillemoes.dk> X-Cookie: Give him an evasive answer. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 2a01:348:6:8808:7e7a:91ff:fede:4a45 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 2/2] regmap: debugfs: improve regmap_reg_ranges_read_file() X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --JgQwtEuHJzHdouWu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Sep 30, 2015 at 11:51:33AM +0200, Rasmus Villemoes wrote: > On Tue, Sep 29 2015, Mark Brown wrote: > > On Tue, Sep 29, 2015 at 12:29:02AM +0200, Rasmus Villemoes wrote: > > That said I think memcpy() is going to be the best way of getting to > > that since one of the issues there (which currently doesn't work) is > > slicing things off the front and memcpy() handles that nicely. > I'm not sure I understand what you want to do. Should I resend as three > separate patches (the four bullets minus the PAGE_SIZE thing), and then > we can take it from there? I'd like to while we're at optimising the code to make it more functional by supporting copying out any chunk of data rather than just complete lines as now. In any case, please split up and resend as you suggest above. --JgQwtEuHJzHdouWu Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWDBl8AAoJECTWi3JdVIfQaM8IAISEB+9V9OPDwZzDAjDPvl9q NXZ3xMzhhaxZTYfYAmhtUd5MHM33C2IAzwRtp1NGY4AJABK9mcNsJGAwF7l8i7jp PMvFOd/nwlZNNJmZO+gYKpccHDZnyYQ0BrAnF9LtHjRRwxnnAD8ej7x4LT7Kh3I0 WxjJ1mdgjnYIhAgk5dTMfni71TqnzOnr2Ft8MQyo1rZq0wPFk1jeDTvRw5KD7Che Zyl+yMw0aOwnY3HpuCJmIbXcwK7lCHywLazag99kK6dsap7LtE2lvtStKGHkcqYg aKrq2Zv/t3w58IKaCSgGlHfpqkOwFyC/pUimonTusNF/WqVrmZPXDH9cGkfqjnA= =er49 -----END PGP SIGNATURE----- --JgQwtEuHJzHdouWu--