From: Jesper Nilsson <jesper.nilsson@axis.com>
To: Valentin Rothberg <valentinrothberg@gmail.com>
Cc: rabin@rab.in, jespern@axis.com, Paul Bolle <pebolle@tiscali.nl>,
ziegler@cs.fau.de, linux-kernel@vger.kernel.org
Subject: Re: CRIS v32: leftover references on ETRAX_VIRTUAL_GPIO
Date: Fri, 2 Oct 2015 09:08:41 +0200 [thread overview]
Message-ID: <20151002070841.GP4919@axis.com> (raw)
In-Reply-To: <20151002065722.GA1804@nebuchadnezzar.informatik.uni-erlangen.de>
On Fri, Oct 02, 2015 at 08:57:22AM +0200, Valentin Rothberg wrote:
> Hi Rabin,
Hi!
> your commit ("CRIS v32: remove old GPIO and LEDs code") is in today's
> linux-next tree (i.e., 20151002). Among other Kconfig options, the
> commit removes ETRAX_VIRTUAL_GPIO but leaves the following references in
> the code:
>
> 0 arch/cris/arch-v32/kernel/setup.c 132 #ifdef CONFIG_ETRAX_VIRTUAL_GPIO
> 1 arch/cris/arch-v32/kernel/setup.c 149 #ifdef CONFIG_ETRAX_VIRTUAL_GPIO
> 2 arch/cris/arch-v32/mach-fs/Kconfig 197 depends on ETRAX_VIRTUAL_GPIO
> 3 arch/cris/arch-v32/mach-fs/Kconfig 208 depends on ETRAX_VIRTUAL_GPIO
> 4 arch/cris/include/uapi/asm/etraxgpio.h 59 #ifdef CONFIG_ETRAX_VIRTUAL_GPIO
> 5 arch/cris/include/uapi/asm/etraxgpio.h 74 #ifdef CONFIG_ETRAX_VIRTUAL_GPIO
>
> Is it intentional or just an accident?
I'm guessing it's an accident, I did have some trouble applying that
particular patch and I had to verify the patch by hand, but I might
have made a mistake and removed something that Rabin didn't remove.
(Since I knew this symbol was tightly connected to the CRIS gpio)
Anyways, I'll roll a patch for removing them, thanks for the heads-up!
/Jesper
> I found the issue with scripts/checkkconfigsymbols.py.
>
> Kind regards,
> Valentin
/^JN - Jesper Nilsson
--
Jesper Nilsson -- jesper.nilsson@axis.com
next prev parent reply other threads:[~2015-10-02 7:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-02 6:57 Valentin Rothberg
2015-10-02 7:08 ` Jesper Nilsson [this message]
2015-10-02 14:04 ` Jesper Nilsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151002070841.GP4919@axis.com \
--to=jesper.nilsson@axis.com \
--cc=jespern@axis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pebolle@tiscali.nl \
--cc=rabin@rab.in \
--cc=valentinrothberg@gmail.com \
--cc=ziegler@cs.fau.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®