From: Mark Brown <broonie@kernel.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-arm-kernel@lists.infradead.org,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Brian Austin <brian.austin@cirrus.com>,
Paul Handrigan <Paul.Handrigan@cirrus.com>,
Liam Girdwood <lgirdwood@gmail.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] ASoC: cs35l32: avoid uninitialized variable access
Date: Sat, 5 Mar 2016 14:39:34 +0900 [thread overview]
Message-ID: <20160305053934.GI18327@sirena.org.uk> (raw)
In-Reply-To: <1453741678-1988125-1-git-send-email-arnd@arndb.de>
[-- Attachment #1: Type: text/plain, Size: 295 bytes --]
On Mon, Jan 25, 2016 at 06:07:32PM +0100, Arnd Bergmann wrote:
> - if (i2c_client->dev.of_node) {
> + if (IS_ENABLED(CONFIG_OF) && i2c_client->dev.of_node) {
This feels it's going to be happening a lot and we should probably have
a dev_has_of_node() helper that does the IS_ENABLED() check.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-03-05 12:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-25 17:07 Arnd Bergmann
2016-01-25 17:07 ` [PATCH 2/2] ASoC: s3c24xx: use const snd_soc_component_driver pointer Arnd Bergmann
2016-01-26 4:09 ` Krzysztof Kozlowski
2016-03-05 5:39 ` Mark Brown [this message]
2016-03-05 14:54 ` [PATCH 1/2] ASoC: cs35l32: avoid uninitialized variable access Russell King - ARM Linux
2016-03-06 20:43 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160305053934.GI18327@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Paul.Handrigan@cirrus.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=brian.austin@cirrus.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®