From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752570AbcKHNxD (ORCPT ); Tue, 8 Nov 2016 08:53:03 -0500 Received: from mout.kundenserver.de ([217.72.192.75]:60852 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752087AbcKHNxA (ORCPT ); Tue, 8 Nov 2016 08:53:00 -0500 From: Arnd Bergmann To: Alex Deucher Cc: Arnd Bergmann , =?UTF-8?q?Christian=20K=C3=B6nig?= , David Airlie , Rex Zhu , Tom St Denis , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH] drm/amdgpu/powerplay/smu7: fix unintialized data usage Date: Tue, 8 Nov 2016 14:52:18 +0100 Message-Id: <20161108135247.2030917-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:nxwOPiy0wICO1kioAfzZt4kvckS3q2fYMYXWOnuAW7rhrTv23bY S0fCoNKI8N3AbQtVJacVVz4tvsTDh6Mht2G/FzjaXqCTUO9/RHxC/JQ5QCtuMc8N8tgEcsO 67DIDrLcCqO6H89OW3gZ66Y+ahZnIjMhCLFoKSv6JGH3DvVZ62RUB3tvf9ZHbk9wUQyprGb Z967UvYRas8bkaRgCSB2w== X-UI-Out-Filterresults: notjunk:1;V01:K0:cIslYYPI1LQ=:xuihHGRh/XWJKGtCaX4zDi RY8T7pFkUXwVmjWMARGnuAq1br7KPWISpVr4nNsf/NBX1EsrFYy7zFTn29IkcmAhuM4WL2cWs BU838wESpHltertV7YeEtmy2F4BxqSpXR/dhJROwhZkOZi4NkUSCWlwA8Pw0gBZ5nU9XFU/sn weaLEn7XLLuiftZHvKxPFJP+JBAbjdMkmnLdcwKBshtoDnzr3VmiopSwv7jfSCo7/BjXnO6oa SNLNUdYdLgAdFWlvU8kMwFafszHUxbZPnTshQZuadHU2DLL2WTMpxLb4FWrRfWq3yGo4bRYHz j1VLUXMeeJT4lu1e22NYt4lmtDo0pVwsBt+PRaxEYCImhbcnIwHwKmabdEAUwok/OeMVEj27h 3yOFkszMARpsY8EyV0xsKmcmTqxqXMu3gQ6krc5sYhTlQ8ow5SX90KktKa6pCxg04GYwKv8S6 jbKSW/M5Y765ZTxAOTSoHgSeUqimd7VHAHtVGfvFf2FCqIE/vAgk1/pFG5cXMXMugO1YhKJUO 1kN6AJJcvHxnKtKmyyWzFauiOXEtcjaQ8QbvHSH0vyHnGK+mVPDEmIc3mfOOuAt1wCGmZiG3G ny8xL6OjcdAZzanREBPAWzmJVH7CjVphPDM38LvNFRyjidQuLXv3EC+oKdJGMCkRnhY2D5Sft ZNECCdkyFwFBJDXBEf78f8StQP39Kbok7pzBBpwUs/FIWBpJ/2rYPiVCEBx6Tv1LKWmc= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org A recent bugfix replaced an out-of-bounds access with direct use of unintialized data: drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c: In function 'smu7_patch_limits_vddc': drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c:2033:6: error: 'vddc' may be used uninitialized in this function [-Werror=maybe-uninitialized] drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c:2146:11: note: 'vddc' was declared here drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c:2033:6: error: 'vddci' may be used uninitialized in this function [-Werror=maybe-uninitialized] drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c:2146:17: note: 'vddci' was declared here uint32_t vddc, vddci; This initializes the data as before using the correct type. Fixes: 77f7f71f5be1 ("drm/amdgpu/powerplay/smu7: fix static checker warning") Signed-off-by: Arnd Bergmann --- drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c index 9e49f2777143..b2d61d043d52 100644 --- a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c @@ -2147,9 +2147,11 @@ static int smu7_patch_limits_vddc(struct pp_hwmgr *hwmgr, struct smu7_hwmgr *data = (struct smu7_hwmgr *)(hwmgr->backend); if (tab) { + vddc = tab->vddc; smu7_patch_ppt_v0_with_vdd_leakage(hwmgr, &vddc, &data->vddc_leakage); tab->vddc = vddc; + vddci = tab->vddci; smu7_patch_ppt_v0_with_vdd_leakage(hwmgr, &vddci, &data->vddci_leakage); tab->vddci = vddci; -- 2.9.0