From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752013AbdAVSNe (ORCPT ); Sun, 22 Jan 2017 13:13:34 -0500 Received: from pandora.armlinux.org.uk ([78.32.30.218]:54984 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751892AbdAVSMj (ORCPT ); Sun, 22 Jan 2017 13:12:39 -0500 Date: Sun, 22 Jan 2017 18:12:10 +0000 From: Russell King - ARM Linux To: Wei Yongjun Cc: Wei Xu , Wei Yongjun , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] ARM: 8641/1: treewide: fix error return code in hip04_smp_init() Message-ID: <20170122181210.GM27312@n2100.armlinux.org.uk> References: <20170122164128.29381-1-weiyj.lk@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170122164128.29381-1-weiyj.lk@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org What does this have to do with patch 8641/1 ("ARM: 8641/1: treewide: Replace uses of virt_to_phys with __pa_symbol") ? Your patch also isn't "treewide" either. Confused. On Sun, Jan 22, 2017 at 04:41:28PM +0000, Wei Yongjun wrote: > From: Wei Yongjun > > Fix to return error code -ENODEV from the of_find_compatible_node() > error handling case instead of 0, as done elsewhere in this function. > > Signed-off-by: Wei Yongjun > --- > arch/arm/mach-hisi/platmcpm.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm/mach-hisi/platmcpm.c b/arch/arm/mach-hisi/platmcpm.c > index a6c1176..f0fff21 100644 > --- a/arch/arm/mach-hisi/platmcpm.c > +++ b/arch/arm/mach-hisi/platmcpm.c > @@ -279,6 +279,8 @@ static int __init hip04_smp_init(void) > &hip04_boot_method[0], 4); > if (ret) > goto err; > + > + ret = -ENODEV; > np_sctl = of_find_compatible_node(NULL, NULL, "hisilicon,sysctrl"); > if (!np_sctl) > goto err; > -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.