From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1172839AbdDXOmL (ORCPT ); Mon, 24 Apr 2017 10:42:11 -0400 Received: from mx2.suse.de ([195.135.220.15]:36548 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1172820AbdDXOmC (ORCPT ); Mon, 24 Apr 2017 10:42:02 -0400 Date: Mon, 24 Apr 2017 16:41:54 +0200 From: Jan Kara To: Dan Carpenter Cc: Jan Kara , Miklos Szeredi , Amir Goldstein , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] fsnotify: remove a stray unlock Message-ID: <20170424144154.GD23988@quack2.suse.cz> References: <20170421105220.tha7fa73smi7vowv@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170421105220.tha7fa73smi7vowv@mwanda> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri 21-04-17 13:52:20, Dan Carpenter wrote: > We recently shifted this code around, so we're no longer holding the > lock on this path. > > Fixes: 755b5bc681eb ("fsnotify: Remove indirection from mark list addition") > Signed-off-by: Dan Carpenter Thanks! I've merged this patch. Honza > > diff --git a/fs/notify/mark.c b/fs/notify/mark.c > index 55955ded338d..9991f8826734 100644 > --- a/fs/notify/mark.c > +++ b/fs/notify/mark.c > @@ -603,7 +603,6 @@ int fsnotify_add_mark_locked(struct fsnotify_mark *mark, struct inode *inode, > FSNOTIFY_MARK_FLAG_ATTACHED); > list_del_init(&mark->g_list); > atomic_dec(&group->num_marks); > - spin_unlock(&mark->lock); > > fsnotify_put_mark(mark); > return ret; -- Jan Kara SUSE Labs, CR