From: Zhenyu Wang <zhenyuw@linux.intel.com>
To: "Chen, Xiaoguang" <xiaoguang.chen@intel.com>
Cc: "Tian, Kevin" <kevin.tian@intel.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"chris@chris-wilson.co.uk" <chris@chris-wilson.co.uk>,
"alex.williamson@redhat.com" <alex.williamson@redhat.com>,
"kraxel@redhat.com" <kraxel@redhat.com>,
"Niu, Bing" <bing.niu@intel.com>,
"intel-gvt-dev@lists.freedesktop.org"
<intel-gvt-dev@lists.freedesktop.org>,
"Wang, Zhi A" <zhi.a.wang@intel.com>,
"Lv, Zhiyuan" <zhiyuan.lv@intel.com>
Subject: Re: [PATCH v6 2/6] drm/i915/gvt: OpRegion support for GVT-g
Date: Wed, 31 May 2017 14:30:16 +0800 [thread overview]
Message-ID: <20170531063015.7a7k77kygi6eoftp@zhen-hp.sh.intel.com> (raw)
In-Reply-To: <DD379D741F77464281CE7ED1CD7C12DE70669283@SHSMSX101.ccr.corp.intel.com>
[-- Attachment #1: Type: text/plain, Size: 856 bytes --]
On 2017.05.31 06:22:28 +0000, Chen, Xiaoguang wrote:
> >> @@ -467,6 +555,15 @@ static int intel_vgpu_create(struct kobject *kobj,
> >struct mdev_device *mdev)
> >> vgpu->vdev.mdev = mdev;
> >> mdev_set_drvdata(mdev, vgpu);
> >>
> >> + ret = intel_vgpu_reg_init_opregion(vgpu);
> >> + if (ret) {
> >> + gvt_vgpu_err("create OpRegion failed\n");
> >> + goto out;
> >> + }
> >
> >Still need to handle error path for created vgpu.
> Just checked the code, if initialize the opregion failed we should first release vfio/mdev releated work(maybe call intel_vgpu_release function) and then destroy the vgpu. Will update in the next version.
>
Better to init opregion inside of create vgpu and do proper error
handling there too.
--
Open Source Technology Center, Intel ltd.
$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2017-05-31 6:35 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-27 8:38 [PATCH v6 0/6] drm/i915/gvt: Dma-buf " Xiaoguang Chen
2017-05-27 8:38 ` [PATCH v6 1/6] drm/i915/gvt: Extend the GVT-g architecture to support vfio device region Xiaoguang Chen
2017-05-27 8:38 ` [PATCH v6 2/6] drm/i915/gvt: OpRegion support for GVT-g Xiaoguang Chen
2017-05-31 4:47 ` Zhenyu Wang
2017-05-31 6:22 ` Chen, Xiaoguang
2017-05-31 6:30 ` Zhenyu Wang [this message]
2017-05-31 6:44 ` Chen, Xiaoguang
2017-05-27 8:38 ` [PATCH v6 3/6] drm/i915/gvt: Frame buffer decoder " Xiaoguang Chen
2017-05-31 5:12 ` Zhenyu Wang
2017-05-31 6:46 ` Chen, Xiaoguang
2017-05-27 8:38 ` [PATCH v6 4/6] vfio: Define vfio based vgpu's dma-buf operations Xiaoguang Chen
2017-05-29 7:20 ` Gerd Hoffmann
2017-05-31 6:18 ` Chen, Xiaoguang
2017-05-31 17:22 ` Kirti Wankhede
2017-06-01 3:01 ` Chen, Xiaoguang
2017-06-01 16:38 ` Alex Williamson
2017-06-01 18:46 ` Kirti Wankhede
2017-06-02 8:38 ` Gerd Hoffmann
2017-06-05 8:26 ` Kirti Wankhede
2017-06-06 7:59 ` Gerd Hoffmann
2017-05-27 8:38 ` [PATCH v6 5/6] drm/i915/gvt: Dmabuf support for GVT-g Xiaoguang Chen
2017-05-31 12:04 ` Gerd Hoffmann
2017-06-01 3:02 ` Chen, Xiaoguang
2017-06-01 9:15 ` Chris Wilson
2017-05-27 8:38 ` [PATCH v6 6/6] drm/i915/gvt: Adding interface so user space can get the dma-buf Xiaoguang Chen
2017-06-01 18:08 ` Alex Williamson
2017-06-02 3:24 ` Chen, Xiaoguang
2017-06-02 3:34 ` Alex Williamson
2017-06-02 9:31 ` Chen, Xiaoguang
2017-06-02 14:58 ` Alex Williamson
2017-06-02 15:23 ` Gerd Hoffmann
2017-06-05 2:39 ` Chen, Xiaoguang
2017-06-06 7:35 ` Gerd Hoffmann
2017-05-30 10:23 ` [PATCH v6 0/6] drm/i915/gvt: Dma-buf support for GVT-g Gerd Hoffmann
2017-05-31 2:29 ` Chen, Xiaoguang
2017-05-31 8:59 ` Gerd Hoffmann
2017-05-31 9:07 ` Chen, Xiaoguang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170531063015.7a7k77kygi6eoftp@zhen-hp.sh.intel.com \
--to=zhenyuw@linux.intel.com \
--cc=alex.williamson@redhat.com \
--cc=bing.niu@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-gvt-dev@lists.freedesktop.org \
--cc=kevin.tian@intel.com \
--cc=kraxel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xiaoguang.chen@intel.com \
--cc=zhi.a.wang@intel.com \
--cc=zhiyuan.lv@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®