From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750725AbdHBE0b (ORCPT ); Wed, 2 Aug 2017 00:26:31 -0400 Received: from ozlabs.org ([103.22.144.67]:44763 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750742AbdHBE03 (ORCPT ); Wed, 2 Aug 2017 00:26:29 -0400 Date: Wed, 2 Aug 2017 14:26:28 +1000 From: Stephen Rothwell To: Greg KH Cc: Linux-Next Mailing List , Linux Kernel Mailing List , Sean Young , Andy Shevchenko Subject: linux-next: manual merge of the tty tree with the tty.current tree Message-ID: <20170802142628.6b39c31d@canb.auug.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Greg, Today's linux-next merge of the tty tree got a conflict in: drivers/tty/serial/8250/8250_core.c between commit: 9527b82ae3af ("Revert "serial: Delete dead code for CIR serial ports"") from the tty.current tree and commit: c7ac15ce8924 ("serial: core: move UPF_NO_TXEN_TEST to quirks and rename") from the tty tree. I fixed it up (see below) and can carry the fix as necessary. This is now fixed as far as linux-next is concerned, but any non trivial conflicts should be mentioned to your upstream maintainer when your tree is submitted for merging. You may also want to consider cooperating with the maintainer of the conflicting tree to minimise any particularly complex conflicts. -- Cheers, Stephen Rothwell diff --cc drivers/tty/serial/8250/8250_core.c index 1aab3010fbfa,3db9d6e19660..000000000000 --- a/drivers/tty/serial/8250/8250_core.c +++ b/drivers/tty/serial/8250/8250_core.c @@@ -1043,24 -1043,14 +1043,25 @@@ int serial8250_register_8250_port(struc if (up->dl_write) uart->dl_write = up->dl_write; - if (serial8250_isa_config != NULL) - serial8250_isa_config(0, &uart->port, - &uart->capabilities); + if (uart->port.type != PORT_8250_CIR) { + if (serial8250_isa_config != NULL) + serial8250_isa_config(0, &uart->port, + &uart->capabilities); + ++ serial8250_apply_quirks(uart); + ret = uart_add_one_port(&serial8250_reg, + &uart->port); + if (ret == 0) + ret = uart->port.line; + } else { + dev_info(uart->port.dev, + "skipping CIR port at 0x%lx / 0x%llx, IRQ %d\n", + uart->port.iobase, + (unsigned long long)uart->port.mapbase, + uart->port.irq); - serial8250_apply_quirks(uart); - ret = uart_add_one_port(&serial8250_reg, &uart->port); - if (ret == 0) - ret = uart->port.line; + ret = 0; + } } mutex_unlock(&serial_mutex);