From: Mark Brown <broonie@kernel.org>
To: Yu-Hsuan Hsu <yuhsuan@chromium.org>
Cc: linux-kernel@vger.kernel.org, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>, Jon Hunter <jonathanh@nvidia.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>,
dgreid@chromium.org, cychiang@chromium.org
Subject: Re: [PATCH v5] ASoC: max98090: remove 24-bit format support if RJ is 0
Date: Mon, 17 Jun 2019 15:56:50 +0100 [thread overview]
Message-ID: <20190617145650.GS5316@sirena.org.uk> (raw)
In-Reply-To: <20190617035526.85310-1-yuhsuan@chromium.org>
[-- Attachment #1: Type: text/plain, Size: 654 bytes --]
On Mon, Jun 17, 2019 at 11:55:26AM +0800, Yu-Hsuan Hsu wrote:
> + /*
> + * When TDM = 0, remove 24-bit format support if it is not in right
> + * justified mode.
> + */
> + if (!max98090->tdm_slots &&
> + (fmt & SND_SOC_DAIFMT_FORMAT_MASK) != SND_SOC_DAIFMT_RIGHT_J) {
> + substream->runtime->hw.formats = SNDRV_PCM_FMTBIT_S16_LE;
> + snd_pcm_hw_constraint_msbits(substream->runtime, 0, 16, 16);
> + }
Do you need both the addition of constraints and the one way
modification of the formats here? Also the indentation is messed up
which makes things hard to read, the second line of the conditional is
aligned with the contents of the if block.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2019-06-17 14:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-17 3:55 Yu-Hsuan Hsu
2019-06-17 14:56 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190617145650.GS5316@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=cychiang@chromium.org \
--cc=dgreid@chromium.org \
--cc=jonathanh@nvidia.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.com \
--cc=yuhsuan@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®