From: "Valentin Vidić" <vvidic@valentin-vidic.from.hr>
To: David Laight <David.Laight@ACULAB.COM>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
Valdis Kletnieks <valdis.kletnieks@vt.edu>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging: exfat: cleanup braces for if/else statements
Date: Wed, 4 Sep 2019 19:05:42 +0200 [thread overview]
Message-ID: <20190904170536.GA12633@valentin-vidic.from.hr> (raw)
In-Reply-To: <d14cda319c584db9b8aa35b15b542f89@AcuMS.aculab.com>
On Wed, Sep 04, 2019 at 09:38:55AM +0000, David Laight wrote:
> From: Valentin Vidic
> > Sent: 03 September 2019 19:12
> > On Tue, Sep 03, 2019 at 06:32:49PM +0100, Al Viro wrote:
> > > On Tue, Sep 03, 2019 at 06:47:32PM +0200, Valentin Vidic wrote:
> > > > + } else if (uni == 0xFFFF) {
> > > > skip = TRUE;
> > >
> > > While we are at it, could you get rid of that 'TRUE' macro?
> >
> > Sure, but maybe in a separate patch since TRUE/FALSE has more
> > calls than just this.
>
> I bet you can get rid of the 'skip' variable and simplify the code
> by using continue/break/return (or maybe goto).
Seems it is not so simple - the value of skip is used to control the
behavior in the next loop iteration based on the current uni value.
So maybe just replace skip with a less confusing name.
--
Valentin
next prev parent reply other threads:[~2019-09-04 17:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-03 16:47 Valentin Vidic
2019-09-03 17:32 ` Al Viro
2019-09-03 18:12 ` Valentin Vidić
2019-09-04 9:38 ` David Laight
2019-09-04 17:05 ` Valentin Vidić [this message]
2019-09-03 18:19 ` Greg Kroah-Hartman
2019-09-03 18:55 ` [PATCH] staging: exfat: drop local TRUE/FALSE defines Valentin Vidic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190904170536.GA12633@valentin-vidic.from.hr \
--to=vvidic@valentin-vidic.from.hr \
--cc=David.Laight@ACULAB.COM \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=valdis.kletnieks@vt.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®