mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@alien8.de>
To: Johannes Erdfelt <johannes@erdfelt.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	"Raj, Ashok" <ashok.raj@intel.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Mihai Carabas <mihai.carabas@oracle.com>,
	"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@redhat.com>,
	Jon Grimm <Jon.Grimm@amd.com>,
	kanth.ghatraju@oracle.com, konrad.wilk@oracle.com,
	patrick.colp@oracle.com, Tom Lendacky <thomas.lendacky@amd.com>,
	x86-ml <x86@kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/microcode: Add an option to reload microcode even if revision is unchanged
Date: Fri, 6 Sep 2019 18:17:35 +0200	[thread overview]
Message-ID: <20190906161735.GH19008@zn.tnic> (raw)
In-Reply-To: <20190906154618.GB29569@sventech.com>

On Fri, Sep 06, 2019 at 08:46:18AM -0700, Johannes Erdfelt wrote:
> That said, we very much rely on late microcode loading and it has helped
> us and our customers significantly.

You do realize that you rely on an update method which *won't* work in
all possible cases and then you *will* have to reboot if the microcode
patching *must* happen early, do you?

> It's really easy to say "fix your infrastructure" when you're not
> running that infrastructure.

I'm not saying you should fix your infrastructure now - I'm saying you
should keep that in mind when thinking whether to rely more on late
loading or not. Who knows, maybe newer generation machines in the fleet
could do load balancing, live migration, whatever fancy new cloud stuff
it is, to facilitate a proper reboot.

Or someone could rewrite arch/x86/ to rediscover new features upon a
microcode reload or a feature disabling. And do that in a clean way. Who
knows...

> Reboots suck. Customers hate it. Operations hates it. When you get into
> the number of hosts we have, you run into all kinds of weird failure
> scenarios. (What do you mean that the NIC that was working just fine
> before the reboot is no longer seen on the PCI bus?)

Yeah, I've heard all the stories.

> The more reboots we can avoid, the better it is for us and our
> customers.

So how do you update the kernels on those machines? Or you live-patch in
the new functionality too?

> I understand that it could be unsafe to late load some rare microcode
> updates (theoretical or not). However, that is certainly the exception.
> We have done this multiple times on our fleet and we plan to continue
> doing so in the future.

The fact that it has worked for you does not make it right. It won't
magically become safe, as tglx said.

But since you do custom development, you should be fine, it seems.

Practically speaking, late loading probably won't disappear as it is
being used apparently. Just don't expect that it will get "extended" if
that extension brings with itself fallout and duct tape fixes left and
right.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette

  reply	other threads:[~2019-09-06 16:17 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-29  5:33 Ashok Raj
2019-08-29  5:38 ` Raj, Ashok
2019-08-29  6:09 ` Borislav Petkov
2019-08-29 13:02   ` Raj, Ashok
2019-09-03 16:46     ` Borislav Petkov
2019-09-04 22:06       ` Boris Ostrovsky
2019-09-04 22:12         ` Boris Petkov
2019-09-05  0:21           ` Raj, Ashok
2019-09-05  7:20             ` Borislav Petkov
2019-09-05 10:51               ` Thomas Gleixner
2019-09-05 19:40               ` Raj, Ashok
2019-09-05 19:49                 ` Borislav Petkov
2019-09-05 20:20                   ` Raj, Ashok
2019-09-05 21:22                 ` Thomas Gleixner
2019-09-05 22:27                   ` Raj, Ashok
2019-09-06  7:46                     ` Borislav Petkov
2019-09-06 12:51                     ` Thomas Gleixner
2019-09-06 14:40                       ` Johannes Erdfelt
2019-09-06 15:16                         ` Borislav Petkov
2019-09-06 15:46                           ` Johannes Erdfelt
2019-09-06 16:17                             ` Borislav Petkov [this message]
2019-09-06 16:43                               ` Konrad Rzeszutek Wilk
2019-09-06 17:10                                 ` Borislav Petkov
2019-09-06 16:52                               ` Johannes Erdfelt
2019-09-06 17:17                                 ` Borislav Petkov
2019-09-06 21:16                         ` Thomas Gleixner
2019-09-07  0:33                           ` Raj, Ashok
2019-09-07 10:37                             ` Thomas Gleixner
2019-09-16 10:36                               ` Thomas Gleixner
2019-09-17  0:31                                 ` Raj, Ashok
2019-09-17  6:37                                   ` Thomas Gleixner
2019-09-17  6:46                                     ` Borislav Petkov
2019-09-17 14:29                                     ` Raj, Ashok
2019-09-19 19:48                           ` Mihai Carabas
2019-09-06 16:55                       ` Raj, Ashok

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190906161735.GH19008@zn.tnic \
    --to=bp@alien8.de \
    --cc=Jon.Grimm@amd.com \
    --cc=ashok.raj@intel.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=hpa@zytor.com \
    --cc=johannes@erdfelt.com \
    --cc=kanth.ghatraju@oracle.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mihai.carabas@oracle.com \
    --cc=mingo@redhat.com \
    --cc=patrick.colp@oracle.com \
    --cc=tglx@linutronix.de \
    --cc=thomas.lendacky@amd.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®