From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC512C432C0 for ; Thu, 28 Nov 2019 02:00:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C097B2071F for ; Thu, 28 Nov 2019 02:00:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZDQPuq5T" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728636AbfK1CAg (ORCPT ); Wed, 27 Nov 2019 21:00:36 -0500 Received: from mail-pg1-f193.google.com ([209.85.215.193]:46408 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728608AbfK1CAg (ORCPT ); Wed, 27 Nov 2019 21:00:36 -0500 Received: by mail-pg1-f193.google.com with SMTP id k1so3696606pga.13; Wed, 27 Nov 2019 18:00:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=1NWy/8kAMX+v65QvJYYfXEV09Sd7DFbVQpWA/O3VSdM=; b=ZDQPuq5TBYpZoGzPhNGoHNbKKdXKxiCMMo601ZnEkkrmtx2u070725swBJXCqMCIgz 3LuimkszMxVGsLjMqO2UvAumaTNCGn8WhuwEa7k6pMaQisr75y8Oc7enPCWk3WYQzdGr XXspDtLuA4K0Bny5rW/Y3DURJF37ZbHf8o3rPiaAVJHY81IdLFcFPW+TQM2n1hIi2YEV N7moVQG/JEKQi1E30iPUzRCNdqyecCUsVzDig6/gxmwFLqLwFrLTSZ/iFRHWq9nRADQt z9hDXDdaMUWFdQXl64g+aHn8A5fL/9PoCZPiZ9vwl+ZOR+S9If4E1HA2k+fDseJcBI4B hsIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=1NWy/8kAMX+v65QvJYYfXEV09Sd7DFbVQpWA/O3VSdM=; b=iC1S056egVUWrkMC9gR36DB2UmSd60Infl/Y9PjquaGGJrbj+7lv9yTpf6c8293OXh 6esUZnXtDsXlg7jaiZkxiDQ+zMdaUkApDs5HSSxyCUnLSzKeL5bjHwJuf68Vo5QuOe9F 7sJJts0foGoZgqc7g2p78KSVh+rwTVhLCwtS4la1Fi+lmtGIkdYyEWclFqt5dueqUfE1 mCxB82TW1GyMTjH6kooEI9ZxDy8dbuavouJwc44ColIYsJbA5QaujLBqCzNcfFNGi0S+ r5NF+2QjHCLcl7EG2pvkqT2nkvnqc82DRaY9qrzEk+FdVDZbe59jcvGXEgtc/P9o7KW6 i1Kg== X-Gm-Message-State: APjAAAVBs5IYIDDy4WGYlixv/95a79zGju8yuKRQZT1xDTb0IWhkxtHL xiZrGrxLKQfOmKTLN41pw70= X-Google-Smtp-Source: APXvYqy/8U61avG9uOn9PWYfv+bT9v34GayzyHYrcWi8xfRCZ3hYaXwujSgokK2MAY4WhpNKrB0NYg== X-Received: by 2002:aa7:9d9c:: with SMTP id f28mr30916321pfq.20.1574906435782; Wed, 27 Nov 2019 18:00:35 -0800 (PST) Received: from suzukaze.ipads-lab.se.sjtu.edu.cn ([202.120.40.82]) by smtp.gmail.com with ESMTPSA id a19sm18387016pfn.144.2019.11.27.18.00.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Nov 2019 18:00:35 -0800 (PST) From: Chuhong Yuan Cc: Nicolas Ferre , "David S . Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Chuhong Yuan Subject: [PATCH net v4] net: macb: add missed tasklet_kill Date: Thu, 28 Nov 2019 10:00:21 +0800 Message-Id: <20191128020021.23761-1-hslester96@gmail.com> X-Mailer: git-send-email 2.24.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit To: unlisted-recipients:; (no To-header on input) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This driver forgets to kill tasklet in remove. Add the call to fix it. Fixes: 032dc41ba6e2 ("net: macb: Handle HRESP error") Signed-off-by: Chuhong Yuan --- Changes in v4: - Put tasklet_kill after unregister_netdev to ensure IRQs are disabled when killing tasklet. drivers/net/ethernet/cadence/macb_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c index d5ae2e1e0b0e..9c767ee252ac 100644 --- a/drivers/net/ethernet/cadence/macb_main.c +++ b/drivers/net/ethernet/cadence/macb_main.c @@ -4422,6 +4422,7 @@ static int macb_remove(struct platform_device *pdev) mdiobus_free(bp->mii_bus); unregister_netdev(dev); + tasklet_kill(&bp->hresp_err_tasklet); pm_runtime_disable(&pdev->dev); pm_runtime_dont_use_autosuspend(&pdev->dev); if (!pm_runtime_suspended(&pdev->dev)) { -- 2.24.0