From: Masami Hiramatsu <mhiramat@kernel.org>
To: Jason Yan <yanaijie@huawei.com>
Cc: <rostedt@goodmis.org>, <linux-kernel@vger.kernel.org>,
Hulk Robot <hulkci@huawei.com>
Subject: Re: [PATCH] bootconfig: init: make xbc_namebuf static
Date: Tue, 15 Sep 2020 16:24:24 +0900 [thread overview]
Message-ID: <20200915162424.a947b5d51695f726db2af2a9@kernel.org> (raw)
In-Reply-To: <20200915070324.2239473-1-yanaijie@huawei.com>
On Tue, 15 Sep 2020 15:03:24 +0800
Jason Yan <yanaijie@huawei.com> wrote:
> This eliminates the following sparse warning:
>
> init/main.c:306:6: warning: symbol 'xbc_namebuf' was not declared.
> Should it be static?
Yes, this looks good to me.
Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
Thank you!
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
> ---
> init/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/init/main.c b/init/main.c
> index 92773a5daf8d..5ac07eb4a300 100644
> --- a/init/main.c
> +++ b/init/main.c
> @@ -303,7 +303,7 @@ static void * __init get_boot_config_from_initrd(u32 *_size, u32 *_csum)
>
> #ifdef CONFIG_BOOT_CONFIG
>
> -char xbc_namebuf[XBC_KEYLEN_MAX] __initdata;
> +static char xbc_namebuf[XBC_KEYLEN_MAX] __initdata;
>
> #define rest(dst, end) ((end) > (dst) ? (end) - (dst) : 0)
>
> --
> 2.25.4
>
--
Masami Hiramatsu <mhiramat@kernel.org>
prev parent reply other threads:[~2020-09-15 7:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-15 7:03 Jason Yan
2020-09-15 7:24 ` Masami Hiramatsu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200915162424.a947b5d51695f726db2af2a9@kernel.org \
--to=mhiramat@kernel.org \
--cc=hulkci@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=yanaijie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®