From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 64F373D75AB for ; Thu, 14 May 2026 08:24:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778747096; cv=none; b=YIQSh0oZxb5Q5GZREeQ3RUmIjX/oqYmKzYPz/BvGFugVOgFWEEiJHCv+4Ep0CMlaTZTrKHEa+Bm0eqjkpz8kPgj09a2st2DfUxWQm+LbX1BCM8m9OmogwDKA7qR9IsZh0gwk66dRYffEigKysxG9PK2efD+I2bvhOBAx4Gm73a8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778747096; c=relaxed/simple; bh=WWJm/xpIv5plkf8LM1Nw9aJODKA1eKtQKr6e1aIxW0Q=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Ee9H8ooa0Wm+5VdKyFky+Ex3WJEqp8RE6Q25VovlZXlNUez/T/ChZMY8oc9lGIxHBVt5HgSJcyr//QAt0/BTm4bEJ+GtBgWYFF1HOmt81BGjPnHH4SHQGLCw5ZnYCr/KLjRUicKeCJkB9cxWdMik2omGFovEFlfzelXFOgnaBMI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cse.iitm.ac.in; spf=pass smtp.mailfrom=cse.iitm.ac.in; dkim=pass (2048-bit key) header.d=cse-iitm-ac-in.20251104.gappssmtp.com header.i=@cse-iitm-ac-in.20251104.gappssmtp.com header.b=TyxvKzJw; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cse.iitm.ac.in Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cse.iitm.ac.in Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cse-iitm-ac-in.20251104.gappssmtp.com header.i=@cse-iitm-ac-in.20251104.gappssmtp.com header.b="TyxvKzJw" Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-36936dcf19dso172836a91.0 for ; Thu, 14 May 2026 01:24:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cse-iitm-ac-in.20251104.gappssmtp.com; s=20251104; t=1778747094; x=1779351894; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=XFQkelQQRKhZpfEoPGAVYNK0Hwvv38SrBtzyzwAZhUY=; b=TyxvKzJwznLCqIX4SPN3uT5eAaPuDct5GAvbEtYAREL7n+a8AKy12pfQA2nB9wrAKR 7ywQ1HnUcvmQ36Jn+igoNQtb2tk50CUT7LCI2A9/CL+hkR9Okzjt/fIDhDMAeG12iP9r vp9S3FFrPoAx9VFZiF0b5pV1gR/oYFD0fL8Ptua1cUhebkarmuTwlIc27gsaPQjeLGIJ vVNbDmbzXhhAxwcNUp0YZdmQwOnj5IOBZVqZ4wQoh/ZkMKhhjKyI4T62wbaUryRjJ+5C oD2NCTm2TN1X6fXNxoZJZFgy5xuteeCg4J/FkY3Y2j2fW4ouF9Lz2mKD2Nm+bl4FAK/C FPsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778747094; x=1779351894; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=XFQkelQQRKhZpfEoPGAVYNK0Hwvv38SrBtzyzwAZhUY=; b=CBB8PmtvIMEy/Ann3kPM6k69XMKvv9hoyzMHLWtP9poHhNWJYm7Aeju7+/SkzNMOuB hq9FCDAzOSwlMGoncGN7jfPL6VgyyBwArn07S8J+z214Zw9Gcinm2tORs5SgSUm5mpti 9TmIvw57IGd6Vj1qoJd4wA3/eOT3breVjneiFB/LNEtrRmpMLqraacWExzXGVLUI6cxL bsNQpatlVrG+ENhcUML7V3igIEPf73ifeAZK4O8Mx40qKFqOrGgkwri2NqHuYFxR3WI/ yMaECB1ndFnRFrDeN8nqKU3zCH6E/xcWPSDQHvleWhRGC1dIQ/LfkRG6Bho/drg/J9ve Oncw== X-Forwarded-Encrypted: i=1; AFNElJ86PqM+XRmtgGtwn2LhxBqawCtrBKu6R4ao3Rnk6Tpn1Cn1pxQ26Iw/+BTz8glhBgrpf9qInJGsROwHY5k=@vger.kernel.org X-Gm-Message-State: AOJu0YwY7nKUeEJy7kuxn9qJL1TCkKaesr9M5wU0sLyAwbIATSmhw/ZO TOEx9sITzSwQxIapaSnix3cMbD/GoSmyvnO35/7NQMR84RgSn6/hQaScNepR4HXIsP0= X-Gm-Gg: Acq92OFOAa2d40qoqXDozeYWfJHvW7Q21C8KLLPrpbluVzcQ3kysVTgtx6UZ+oBxMOn KVS9S2upwP0sYwxvdirFeMg7ImKi+oTJh4rs06tvy2DHMOEofX/8eiYNijaSEaTXLtPUYaW/MWa e9J4L5Bwhr0RDVKrODIkxhMRZQlTPRj/DQ8CjR8GHO+UwDyG2yvmlAIipQ01d1bT8qzJ97pgEH3 yr82GMO8OMX0O+mgYOHhp038hY9V02ygJWxg03cy7wB6JwMkCf9AQHWKacnOWRe4wsWE3bA8Yqh C4f7YbdSDP15p4A90mmnG5RyYJQV7RGh4GpdZAl4pu55gy4jiz+F9tIlN10jmI1DstRaIqTyxfP ek6opV2gY3QNzsry85Kbvtd2U8fO9/Smm2g/qPlU/tOG7egZtklcbdJrbxgemOGMspHnG+WRA00 AGSKYdhciwC/gJgfxbRekbJ9dswA7cAf201FcHA9ra0MddkmGSevjOktU4GlWQwYDTaMXOeMz/s i6NrankmBm4qCSUspUdy/8iRXPZzT/EJHE4VQ2RhBQw X-Received: by 2002:a17:90a:ec90:b0:367:b8ad:f0e9 with SMTP id 98e67ed59e1d1-368f7990c58mr6047925a91.16.1778747093565; Thu, 14 May 2026 01:24:53 -0700 (PDT) Received: from [127.0.1.1] ([103.158.43.41]) by smtp.googlemail.com with ESMTPSA id 41be03b00d2f7-c82bb06875bsm1589102a12.3.2026.05.14.01.24.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 May 2026 01:24:53 -0700 (PDT) From: Abdun Nihaal Date: Thu, 14 May 2026 13:54:30 +0530 Subject: [PATCH 01/14] fbdev: hecubafb: fix potential memory leak in hecubafb_probe() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260514-fbdev-v1-1-b3a2474fa720@cse.iitm.ac.in> References: <20260514-fbdev-v1-0-b3a2474fa720@cse.iitm.ac.in> In-Reply-To: <20260514-fbdev-v1-0-b3a2474fa720@cse.iitm.ac.in> To: Helge Deller , Javier Martinez Canillas , Thomas Zimmermann , Benjamin Herrenschmidt , Andrew Morton , Sebastian Siewior , Florian Tobias Schandinat , Ondrej Zary , Antonino Daplas , Paul Mundt , Krzysztof Helt , Tomi Valkeinen , Michal Januszewski , Heiko Schocher , Peter Jones Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Abdun Nihaal X-Mailer: b4 0.13.0 The memory allocated for pagerefs in fb_deferred_io_init() is not freed on the error path. Fix it by calling fb_deferred_io_cleanup(). Fixes: 56c134f7f1b5 ("fbdev: Track deferred-I/O pages in pageref struct") Cc: stable@vger.kernel.org Signed-off-by: Abdun Nihaal --- drivers/video/fbdev/hecubafb.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/video/fbdev/hecubafb.c b/drivers/video/fbdev/hecubafb.c index 3547d58a29cf..dd2af980f3d8 100644 --- a/drivers/video/fbdev/hecubafb.c +++ b/drivers/video/fbdev/hecubafb.c @@ -192,7 +192,9 @@ static int hecubafb_probe(struct platform_device *dev) info->flags = FBINFO_VIRTFB; info->fbdefio = &hecubafb_defio; - fb_deferred_io_init(info); + retval = fb_deferred_io_init(info); + if (retval) + goto err_fbdefio; retval = register_framebuffer(info); if (retval < 0) @@ -209,6 +211,8 @@ static int hecubafb_probe(struct platform_device *dev) return 0; err_fbreg: + fb_deferred_io_cleanup(info); +err_fbdefio: framebuffer_release(info); err_fballoc: vfree(videomemory); -- 2.43.0