From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f177.google.com (mail-pg1-f177.google.com [209.85.215.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D29EC3D8123 for ; Thu, 14 May 2026 08:25:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778747104; cv=none; b=SjVunITUjWCsKJBRBTXXLPGXRFJYX83CSsLYV942ycRwQK8IuSPUE3oEsI7UITGdV+Op/WOSLoRYBpIJQ79aQydtmfUtKtzcN82EAghnFz0Z/KEc+D9Y9TSbyF/Uypa44VrBxg+Id6ChxIAOZCDvdJ/pCiKFpnb33muh51970y4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778747104; c=relaxed/simple; bh=8Z8K1cxzOFKrVJqTydIBAVWPHk0uegI4AOwudkIAUMM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Mt6yBwbyB0Y4uya1osDHrB6CwoFoYdpUhRT2WRIfOsEIcya0nygtWyEiddRK6YAj2eziqvq2XRolqpEglUO+pT/tYw1gEbGJDd49lLhYzvgOLA63f7OTsS2OuqeG4vtxpurA/4Unsbk0LgLR/9my6mbmyofzzYB9XQ0WoXnrFTE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cse.iitm.ac.in; spf=pass smtp.mailfrom=cse.iitm.ac.in; dkim=pass (2048-bit key) header.d=cse-iitm-ac-in.20251104.gappssmtp.com header.i=@cse-iitm-ac-in.20251104.gappssmtp.com header.b=CVsKybsX; arc=none smtp.client-ip=209.85.215.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cse.iitm.ac.in Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cse.iitm.ac.in Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cse-iitm-ac-in.20251104.gappssmtp.com header.i=@cse-iitm-ac-in.20251104.gappssmtp.com header.b="CVsKybsX" Received: by mail-pg1-f177.google.com with SMTP id 41be03b00d2f7-c8028fa6039so5204041a12.2 for ; Thu, 14 May 2026 01:25:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cse-iitm-ac-in.20251104.gappssmtp.com; s=20251104; t=1778747102; x=1779351902; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=7d38f+IaIo+LqPs0VUxtKb87zLxGu6BC7Fyaado5mzo=; b=CVsKybsXWDXuCTZclc+ut8IMXNhmqIGPBFYrMQkaLFXdFfmujFt98fCinanHM64J8H 53iFU/aBY0VpBu+TjsfeF/QtiAe2+CLoM9fdvsu/HKrO7vp2LOIpFbnAJCbc+DqB4asj tsWkdQpJZ7UYDiAaaZQA3OPxUDYWTXdZbmTqePGte5tfr6+srYAvPnlDWClkl8V2qbcN 8DMHRldVeI9/e04AAEBGFmMt0M7Lgg25kJXnsCbhvy/zVxFIH4Ad4KAEaaCD2oWtmxPF 1T6gIfm6HKDFci2DeiwsgdShtfrC9k4IdIcs1jE+7U3vLAV1TA/9pDwFft5fRLDlhfPZ 615Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778747102; x=1779351902; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=7d38f+IaIo+LqPs0VUxtKb87zLxGu6BC7Fyaado5mzo=; b=P1wCtu0PaGot9s/GlsEJ2e5tWD1v0iY+ACJI/6aiiIuiEDKXqshA+9pB9GfIHZ5zAv qx144mJvmSq4s7MyTHYnxiUt6r7N/6dcJKXkf2MnAuvBxDZnA1hFRlCs8T3kzh8hCu/f GS3N4ELQXVrUfPTcIPaiznkuCZuG98EiHtl1gA1OEi4JqDrfYiiyA1YuPL7V6q08lE2m /ZNk0sZaaXkKCdFCMKUkr7FwF+/WdEgsro4i2SmlfamPDHsJHF57xYrGSmQ1VRor4+4z XDdeQjHKJ9534yi2a93hpjSF0LSdOBpsXSHIN36ca8iq19d0AveCrGNg0JfBJR7Zj+Dx D7sA== X-Forwarded-Encrypted: i=1; AFNElJ9KKh4N5B1qtlYxh0Spy3o/A1K4JKL73xTSTzJLNhFlYoz+0XdG9BLFxgQHTua7PdeRedoR7xIOaCMVNY8=@vger.kernel.org X-Gm-Message-State: AOJu0YzWJOP3+lY02sY+Rrdy5AZumuRTO4spraJE5hdD9szo7PqMSuC1 PcnhEi/wQEier/9XwLJSGhPI3FEkLP32qRVKQ/J9YHDSi3Y/+nKq9qesTX/BMDVF260= X-Gm-Gg: Acq92OHKhu57GMtqtXttqJVnaaOBsz6aXMh19FqCM2qZeRVSWQ1IjLZxTXfw72ie64S ZEB1akcv5Lt+e9TjqnCguxh6SHz5T8B0xl1DmMAtPYlK7t7PtVQjYUVb+brpoS66BbC7duzyjZU HmAdJ8mwKGd2OObBhHWTSnLZjJWpp/n6tkUcLBV3b4BjFe6e209VEZ/436fbJ6Hyc0WEEJsQX/b cQJNYof7eoMLEKYBxDq1bBYyqIyENPYYfHddN773xmHQscGFlCUDvRh6pBCW+6S9jrdrocCJPjr 87JVVGJrgyZeC5YY9Xbi+Jx07mTs9eamvuiWTLBiIHBcmR9e0zX5o7lfn0mTs+fS3XAwUuqF9+9 F6YaTJAlbWiG/AHvBnrDm7trChowaZTCeD/3HW5f2y9sSG64t44ZbJqaOyRJususWwywa6vnOUp LaP43SrcP7PwSbl5KIzsHo52Pe0d+Z56IeOUpWzN+19p4au/oCvwNrMnLs0reH5b/7D3D6kf2j8 fcQ+AYLG4F03ZIZ/S6X426Uhy9qulgauD6Erpe/LOZd62+eIGvovYg= X-Received: by 2002:a05:6a20:7495:b0:38b:d9b5:5de2 with SMTP id adf61e73a8af0-3af83e4433bmr7439055637.50.1778747102141; Thu, 14 May 2026 01:25:02 -0700 (PDT) Received: from [127.0.1.1] ([103.158.43.41]) by smtp.googlemail.com with ESMTPSA id 41be03b00d2f7-c82bb06875bsm1589102a12.3.2026.05.14.01.24.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 May 2026 01:25:01 -0700 (PDT) From: Abdun Nihaal Date: Thu, 14 May 2026 13:54:31 +0530 Subject: [PATCH 02/14] fbdev: broadsheetfb: fix potential memory leak in broadsheetfb_probe() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260514-fbdev-v1-2-b3a2474fa720@cse.iitm.ac.in> References: <20260514-fbdev-v1-0-b3a2474fa720@cse.iitm.ac.in> In-Reply-To: <20260514-fbdev-v1-0-b3a2474fa720@cse.iitm.ac.in> To: Helge Deller , Javier Martinez Canillas , Thomas Zimmermann , Benjamin Herrenschmidt , Andrew Morton , Sebastian Siewior , Florian Tobias Schandinat , Ondrej Zary , Antonino Daplas , Paul Mundt , Krzysztof Helt , Tomi Valkeinen , Michal Januszewski , Heiko Schocher , Peter Jones Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Abdun Nihaal X-Mailer: b4 0.13.0 The memory allocated for pagerefs in fb_deferred_io_init() is not freed on the error path. Fix it by calling fb_deferred_io_cleanup(). Fixes: 56c134f7f1b5 ("fbdev: Track deferred-I/O pages in pageref struct") Cc: stable@vger.kernel.org Signed-off-by: Abdun Nihaal --- drivers/video/fbdev/broadsheetfb.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/video/fbdev/broadsheetfb.c b/drivers/video/fbdev/broadsheetfb.c index c8ba098a8c42..582f1ee4c9b6 100644 --- a/drivers/video/fbdev/broadsheetfb.c +++ b/drivers/video/fbdev/broadsheetfb.c @@ -1072,12 +1072,14 @@ static int broadsheetfb_probe(struct platform_device *dev) info->flags = FBINFO_VIRTFB; info->fbdefio = &broadsheetfb_defio; - fb_deferred_io_init(info); + retval = fb_deferred_io_init(info); + if (retval) + goto err_vfree; retval = fb_alloc_cmap(&info->cmap, 16, 0); if (retval < 0) { dev_err(&dev->dev, "Failed to allocate colormap\n"); - goto err_vfree; + goto err_fbdefio; } /* set cmap */ @@ -1121,6 +1123,8 @@ static int broadsheetfb_probe(struct platform_device *dev) board->cleanup(par); err_cmap: fb_dealloc_cmap(&info->cmap); +err_fbdefio: + fb_deferred_io_cleanup(info); err_vfree: vfree(videomemory); err_fb_rel: -- 2.43.0