From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA81E3F413B for ; Thu, 14 May 2026 08:25:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778747127; cv=none; b=Ne6X5pwxFpOzK6cIBFD+7vfCVeGGd1oRv/AwP/8CeBOuuakKt97/+gntqPLgpe9DirqdBEiq/1GR4s+qvZv223D0ElMiTZTIP2Ach/ctOPaKI/EvRPi96GqYRFFqdojl8DiCmEzHq+CXUT2ks8/FsUVh0p427y1dUwKKYgri31g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778747127; c=relaxed/simple; bh=7dxxrzbqdG+D1liscZGC4J7GXbPSfqu94rWrjh7Aoes=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=FKHonjundBd/qnr7r6jUQ4mrxhnKnbgch1EcBckOgwksR51W/POeWTsD+wZZOsjAzlsvhE+JQw/cyJtce/RQwCOBf+JUKswItHC97/PfIpyZQxEHf9Q2SwjRoONkLY3BdFDYGZwgwvOhAR+jvsN4epBEFGFwXlCdy+GEekYieTo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cse.iitm.ac.in; spf=pass smtp.mailfrom=cse.iitm.ac.in; dkim=pass (2048-bit key) header.d=cse-iitm-ac-in.20251104.gappssmtp.com header.i=@cse-iitm-ac-in.20251104.gappssmtp.com header.b=Om9xZZjh; arc=none smtp.client-ip=209.85.216.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cse.iitm.ac.in Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cse.iitm.ac.in Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cse-iitm-ac-in.20251104.gappssmtp.com header.i=@cse-iitm-ac-in.20251104.gappssmtp.com header.b="Om9xZZjh" Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-36900945df5so1021728a91.0 for ; Thu, 14 May 2026 01:25:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cse-iitm-ac-in.20251104.gappssmtp.com; s=20251104; t=1778747125; x=1779351925; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Cj4tsYfpJn1h72OjlKL8YrS/bESA9WMb/nnrThUnbQ0=; b=Om9xZZjh2bxdxmVNCiYljIo6TEXd0J4seAO8DMoA8QqiHAAoS5TJmjXsFgeTQSAKTV YY0Fbnwc6Adxo5JCmEUU23QUdl27ML8rnMntB5Tr2n4iiuc1czbhLqiLGE8i1csg7oGK c/dzGAOP4uEGt9eW/rJggM17RmUPWqPwEqCEyMCru0ZnazRwJInWSLBebCuSdLFuTTSd a9A6EL5rDoDWL9gPS+AzElv/NnFkkOnnicS3jApYybmvX4XNDxgCpNM6uWnQq0+Ddb4b ukXf9upoU8AYTKIa+L09XXOAUoPgypiklhfMJ+1P5vdYZ7g21byhK0vLuumwEyHKn5Oz /Xlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778747125; x=1779351925; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Cj4tsYfpJn1h72OjlKL8YrS/bESA9WMb/nnrThUnbQ0=; b=Flh1FSi4DX2ZZWEV8dzUrJdRuId5nN9IIfZJzNFVurUIk5qTPW7sijmO55WJtgANky VX/jUgL4XVFUxbV9y9CwS5iXXxFtrtXeHkyCr21OYgo3L6NXzvn9hi/3Wt/zy9PYMrP4 zWbjwXdtlsvkOJdRVnfgTsa4u7HbQpHNs+16/VhxZFGbur+F24WSQ3LVImjxVNzfKyZS qlhwdfwsQfJ6Z7llp9079ISVGVbc5VIeKSSz7itPs/KFuz2yWa62dS1u+dKMpRk9ISzD Zh1qvJ5GwSq/gdWftd5AusJGyEVJsg7O/4n4avWaEyrZpGoDdLFNPZEJyd0vbNscvMTh zqvA== X-Forwarded-Encrypted: i=1; AFNElJ/E9pcp/eINkKAE+hKzw2Fm7dPfg6H0VoDM4ZwQSi86oJY2cL8+xnRJoFWr3NX9iSE5wCpYA4FRtVc50YU=@vger.kernel.org X-Gm-Message-State: AOJu0YxfUOL+uSpwmt9TYHhDLP4P33kwQL69ClS76STKo83DLSrza0Cj U2fUh2YW8zkwP65RQg1zbE0tNA0M4It/Fxs4Ze64nXQzPw939a51VuG0KdsQdGRQk4w= X-Gm-Gg: Acq92OHQ+u3kgBRGbHhnX+RPvCU7ts5ORJj3VLF35B5B2PfuFXCUYBij4T0CqYeRIQH yBDPWgqaxlbo2Xitdo5iFlh362MeUwVybOCRzWDPOjULCcvFY9xeHxKMwG5i9EuIxmDCO8mUHcq PKqQELWNH2tII0JliX9LTa4uxqHTfqCspOl6nKthNTqZ006SCFe3o1k9ErjUJ1P/fQY10dYG6VK cgEYrTPfyK1fbTz9A8A4aWIMr5JVY/cGzqvn6dewyS9Vu/GURyAHhSrOVC/MbvQJydrEv9EZWN/ 7jD/rYc3QgRcJUt1C9rQHjkiLbbFgj+Ipy4VyXJ6UJDDg6Xgkx88Ue6DV7chYmuuv7OYObrFbXS NN2OdxzYCyBex9xiPWzLtfn81VgUA8gWbRoe2EulFEmudFlfW2zUkwVvm++IFBXJhKJw5BhZ4pB vcPvz5RumttA+A4RXBRIJryGz0xa5/I9noPj4EjvwQS/jLKCRWEVb/yDK8Sf96MCf7j0byDLtex wcTFRwOS2Yf46p7A+n1y3JozsKeomqfzl7zl4VmirMY X-Received: by 2002:a17:90b:2e4f:b0:368:30bf:e51a with SMTP id 98e67ed59e1d1-368f782f1c3mr6794705a91.12.1778747125031; Thu, 14 May 2026 01:25:25 -0700 (PDT) Received: from [127.0.1.1] ([103.158.43.41]) by smtp.googlemail.com with ESMTPSA id 41be03b00d2f7-c82bb06875bsm1589102a12.3.2026.05.14.01.25.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 May 2026 01:25:24 -0700 (PDT) From: Abdun Nihaal Date: Thu, 14 May 2026 13:54:34 +0530 Subject: [PATCH 05/14] fbdev: carminefb: fix potential memory leak in alloc_carmine_fb() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260514-fbdev-v1-5-b3a2474fa720@cse.iitm.ac.in> References: <20260514-fbdev-v1-0-b3a2474fa720@cse.iitm.ac.in> In-Reply-To: <20260514-fbdev-v1-0-b3a2474fa720@cse.iitm.ac.in> To: Helge Deller , Javier Martinez Canillas , Thomas Zimmermann , Benjamin Herrenschmidt , Andrew Morton , Sebastian Siewior , Florian Tobias Schandinat , Ondrej Zary , Antonino Daplas , Paul Mundt , Krzysztof Helt , Tomi Valkeinen , Michal Januszewski , Heiko Schocher , Peter Jones Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Abdun Nihaal X-Mailer: b4 0.13.0 The memory allocated for modelist in fb_videomode_to_modelist() is not freed in the subsequent error path. Fix that by calling fb_destroy_modelist() Fixes: 2ece5f43b041 ("fbdev: add the carmine FB driver") Cc: stable@vger.kernel.org Signed-off-by: Abdun Nihaal --- drivers/video/fbdev/carminefb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/video/fbdev/carminefb.c b/drivers/video/fbdev/carminefb.c index 5f13f1cc79d3..fca50b7961eb 100644 --- a/drivers/video/fbdev/carminefb.c +++ b/drivers/video/fbdev/carminefb.c @@ -589,6 +589,7 @@ static int alloc_carmine_fb(void __iomem *regs, void __iomem *smem_base, return 0; err_dealloc_cmap: + fb_destroy_modelist(&info->modelist); fb_dealloc_cmap(&info->cmap); err_free_fb: framebuffer_release(info); -- 2.43.0