From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C8543D8120 for ; Thu, 14 May 2026 08:25:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778747150; cv=none; b=qUh8EKonuzaT/hgqKI7a+1lbmI5X9VFE213rFZ9lAdSmF7NGtZoBuidxzwjPipPdXqgGEDfef3SNdZzPVMjoTVUpMmAr+jwqQqDwbF9+8HVNM4M5UxB6gq6N1D+GYqTwwlPvz14wbB1iBU0G2D01FUL7eF1QRRJAD8OoLm/f+jc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778747150; c=relaxed/simple; bh=Dkx3pVUGwjaUQXWa+bptzHOFLaaIn6XK7Bp6IDRBSVo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=oa+/oiA5QC/2A/bC+7VWlpbQ3qvK5uKa0EAHIOm6DHZLPXcmTBXru1i7CedJiotap1EWZpYu780gPnL2xCrX/Hb13Djf1O7G3tYsYKWtNeBovdXDKvVuoMgw9v42GJf0efrhpRRbSVv+gdjGqHlby4nqRRNex6xTb7yDgpUAywg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cse.iitm.ac.in; spf=pass smtp.mailfrom=cse.iitm.ac.in; dkim=pass (2048-bit key) header.d=cse-iitm-ac-in.20251104.gappssmtp.com header.i=@cse-iitm-ac-in.20251104.gappssmtp.com header.b=z1Lt5KaP; arc=none smtp.client-ip=209.85.216.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cse.iitm.ac.in Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cse.iitm.ac.in Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cse-iitm-ac-in.20251104.gappssmtp.com header.i=@cse-iitm-ac-in.20251104.gappssmtp.com header.b="z1Lt5KaP" Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-36627a0ea23so3165242a91.0 for ; Thu, 14 May 2026 01:25:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cse-iitm-ac-in.20251104.gappssmtp.com; s=20251104; t=1778747148; x=1779351948; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=U8JuFCRwwrvf2GMkTB19c8/MiJ4FqDOCW/ASwDDZNHk=; b=z1Lt5KaP747LvCfDiP91KFSqqQKP4kQ1y3sXy0FLgUW340f22HXKEamlJ/Syk/avuE kouavYUB0Z/kzfBCo+LJnpLRV5VzB3cRu5mmN13MWRd4HvtvusFo9tQbGt6Gh8wOUXF0 q810a0rZk6c1wjiwsVznxQRlLBvp0UnWtLkmIQjb/3VGS5pCPf+zQB9OSxGvwsCbI/Kz o8vyZIF9RdiaLQmKMdVHlx4aqlldtx7F64Bi3FbS12VFLb9O6VkVNlvrNg0A0SdLinOF kGnLVhpTs+WOdPCOOvLEGaxeKdHcbcz6keUL33ol4kn+nz6hC0IDgHl0YbRk7qoo5WQl 009w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778747148; x=1779351948; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=U8JuFCRwwrvf2GMkTB19c8/MiJ4FqDOCW/ASwDDZNHk=; b=gNXPBLk4+81u4JO0Qq/8JTFTZ3OQ27tgrO8iIy3UFWroxiLV/R6+ZXboO/Alybdd6y qHtw+aq8KjgAVkKLy7+PE4gEkgNB8ZqbCsdM4f+UwbUNTGaQYd9GOeoqqrTg+6ss0sLz XizmeZKmZ2K/joy9Si6qedU5u7dprTwxKRZVHiXRgiElwg02073EZcp7EgDTQ+KIDBfu JyGdZhAVTpd/Yh/ismSOpuKWKQ/9nOuzfwGlB9J/PLNUN/auUOkGlTv6tWIzIDlycQL0 Gx33AUUnoAq8McBX5jblE7EW6KBT4uNynkM39nArHav2EX79UrfowRaWRDpWeGAKQ64Y uKqA== X-Forwarded-Encrypted: i=1; AFNElJ9MBW7XmTruhG/lNhcUwweHVMGWa41dqu5frsbwcxSnGGc6AGnoTiz/bQiD00tndYE6kUjk9Hl7U621ORs=@vger.kernel.org X-Gm-Message-State: AOJu0YxsgaDO4RXE4KMpybbxElS3KskKgdJzMGsmnzony5crEEkXa6xU KVKVnj1QIg7lXZD77CqVG49FFrLEG080a2nSxSb0B3J4Qzv4b1hMbssX1cYMe9qEE3U= X-Gm-Gg: Acq92OHlcU3OjaHVzIParFfB7tHo743Cc9turzsvbwPswdtr1w9XkpWkMRX5r4u0FKp qGsXMv72gFPFwS2We+m/OCKZXTPVRgpPyL2u1t/7HxBaXlT0N+Zc8ce4KGxsJXJc53Ml8wZPj26 dN5wo+vhZKgENBBNr7sN7WaehEJtsI48Hr97YFDugumKIaGpKMm9RghXxU6cl3W6cokTRIkaHsq WjpC3H6ISp86lSUHpsY5SsS0t3F2I4vQogbb+py1/txlJoywuc4UsAgvMmeelvEuCrrqPFBzfu9 wOZpNjyHPAN0SG6YlAjWGinnmhecH4IixIl2bW/MlUbEhfdIB+8geyDqv6InmJGR5LzmlKDM7pt F8U072G0aXFC7oMCjYKbIQvq7qcfdEQiCayaeyQSgJ68M9Ke59cubqB9VBxVJMagAfIEMS6QwQ4 4j1WUyFQmbr0Go5QlbQdPFmgbdR70+KIzi1ENrmdjV5CIY7/SzPES83tAxpi7wq8Xjol5USnSL/ rj6os/4OSXsGysjNL6xqwCzHeiIGzGHG/wkEe0SI1/IA5aIAHf/lx4= X-Received: by 2002:a17:90a:fc44:b0:368:4cb2:17b8 with SMTP id 98e67ed59e1d1-368f40835b7mr7602543a91.21.1778747148094; Thu, 14 May 2026 01:25:48 -0700 (PDT) Received: from [127.0.1.1] ([103.158.43.41]) by smtp.googlemail.com with ESMTPSA id 41be03b00d2f7-c82bb06875bsm1589102a12.3.2026.05.14.01.25.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 May 2026 01:25:47 -0700 (PDT) From: Abdun Nihaal Date: Thu, 14 May 2026 13:54:37 +0530 Subject: [PATCH 08/14] fbdev: s3fb: fix potential memory leak in s3_pci_probe() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260514-fbdev-v1-8-b3a2474fa720@cse.iitm.ac.in> References: <20260514-fbdev-v1-0-b3a2474fa720@cse.iitm.ac.in> In-Reply-To: <20260514-fbdev-v1-0-b3a2474fa720@cse.iitm.ac.in> To: Helge Deller , Javier Martinez Canillas , Thomas Zimmermann , Benjamin Herrenschmidt , Andrew Morton , Sebastian Siewior , Florian Tobias Schandinat , Ondrej Zary , Antonino Daplas , Paul Mundt , Krzysztof Helt , Tomi Valkeinen , Michal Januszewski , Heiko Schocher , Peter Jones Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Abdun Nihaal X-Mailer: b4 0.13.0 In s3_pci_probe(), the memory allocated for modelist using fb_videomode_to_modelist() is not freed in subsequent error paths. Fix that by calling fb_destroy_modelist() Fixes: 86c0f043a737 ("s3fb: add DDC support") Cc: stable@vger.kernel.org Signed-off-by: Abdun Nihaal --- drivers/video/fbdev/s3fb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/video/fbdev/s3fb.c b/drivers/video/fbdev/s3fb.c index 831e9e6861b1..dc1f9b627185 100644 --- a/drivers/video/fbdev/s3fb.c +++ b/drivers/video/fbdev/s3fb.c @@ -1446,6 +1446,7 @@ static int s3_pci_probe(struct pci_dev *dev, const struct pci_device_id *id) err_alloc_cmap: err_find_mode: #ifdef CONFIG_FB_S3_DDC + fb_destroy_modelist(&info->modelist); if (par->ddc_registered) i2c_del_adapter(&par->ddc_adapter); if (par->mmio) -- 2.43.0