From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 857ED47DF84 for ; Fri, 15 May 2026 12:43:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778848981; cv=none; b=GafF/QR9fjytEX9IpRv257novypfxisAnDgS+C6dD+Ho+i34WzQzAMuBxGAobnAHGfwNEOgcbiLY8O6IZCcb6ZhEO47/D0CKt4fwN8AkOjkKB5UFF/R97WqshxGJch7IWG3i3y0ofnLj/r8XbKfyftm2yMUinrzRfJPdg0v1nhY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778848981; c=relaxed/simple; bh=zwgk6epnRWY8Wv5vG6Mf9eFSqZrrY7jCN5ujBz1hPqM=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=NaNNSeBbuzCuraVwQ2nOVqd1wIuhzoURmCxalJVc+xgmDXewmt6CVMag7gugT9ICqygSPrRTjRNxi6WPMzaQAyoKT0yWE/SWQ+dXj7oR2DJH7nxamuYGBpQmcp9Z42NcnNskym02MlkI8XMeUFz0T0qg8bR1QdTjsv2UJgsVmhU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=MfonqrYN; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=hf80f5Sz; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="MfonqrYN"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="hf80f5Sz" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64FBejCG3795744 for ; Fri, 15 May 2026 12:42:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=F4ku8bhGpeG 5gSXCtpcrJJX6a8V20679dhsPTygcnWI=; b=MfonqrYNZml3WtDu0pRbeI4aKMN /s9FNCElzmNU+sXhxiBVl0tFO2V5RTtin6OJE34zqUgEjwDSnLYx2Ry0i1v4jlW0 9GfEL4uVBUHqu/hc6j2VDD8FKqM766YSNz/SdXBfX0vvp+2gcp9I57IUcv3ecY+c AzMOuQ35TboxQFdctWmU4u2GvLKW9FlVL3J1yW3H9ep3J4/eJuuNzgQQsyJ1lKNS Uw4yjzLz4R4Qkwt5djpOKR998rIw1yviU4pQXbJGLAvIyGgj4AZe5jVshLv3ug1x vZXn/OGqsHQ8OoF+3KO46YgeZ0Fk0v67YxshjkHp77BAGjK+FpMyfZqKt/A== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e5m1su78d-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 15 May 2026 12:42:59 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-365fd467cf6so8049375a91.0 for ; Fri, 15 May 2026 05:42:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778848978; x=1779453778; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=F4ku8bhGpeG5gSXCtpcrJJX6a8V20679dhsPTygcnWI=; b=hf80f5SzU/L2AMEn16Yb3UqCgyuT7ccZQJCh+bWv6O3auu5T4s5sQVI8wU8yzsbqC6 CQl17avh82f3rMkcz6Kq8oBTBgXdutLT0wLcKVUXyWra5TWwFOa0IglH4rUrpQ6qEFFQ b5HRKTVWTfM36+HuvoAVEOPvU/a/bzOJ6p6KMjYwPFZm/+RGQ4cHyBN9EXFaXQ5LkThw pnKbnQOjm9DgoP8Z2ErGq95cdyFlDSksAOZ+v2/9dk83QffssR3A8sCO1MewTVOg60L2 7P8DdI5ma4XDl3HpiPrNnIgwVHLCQfjDllUdSZJmwT44X1mS+w0whHuhS52fEM3wq48/ Xuuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778848978; x=1779453778; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=F4ku8bhGpeG5gSXCtpcrJJX6a8V20679dhsPTygcnWI=; b=c47V7QYJUOxPdLY6ggu8tGvoR8Gc+bXY7YSi8kDd7QPHIcUILfRX9zUlL38bUSYLb3 6sAohrve8FCmw6AGqRHV/U6/YqnJRrYZ9M/DL/HahEN6CQm2XzXfltDH2Gg1TycCJY88 pIR/KmYUuATED3WkYUwAfOP+lKKh7seiAVpYGpAn4SVSwEcQ32dqL7f5mSM2yonep5p6 2ARHfts1x6+oQTuL5u41biDSIksyTykMUpKKRTLyTDDvI7iSLLuk3xz+RB87tCpa0ESK Qg4Cp1BEZ+NLy8/zdocuLO60TP5R+83KQJWPWtqIkITdc9qmfnMM5eVNtZbQZ4aH3nDX XJ5g== X-Forwarded-Encrypted: i=1; AFNElJ9DFJc8YYoqlhxnX6K9TQK4ICkY5vsK545hnaWfj5B8/FtLyNCZuLRFXJSy5ZAv5fQ+/r7RSjEUYh2H1Go=@vger.kernel.org X-Gm-Message-State: AOJu0Yw3sthhc94d8DlhLdGQ003cG/eOJLMNZSL/YG9An3KGRjkMhKNu QofJ9wl3lF6jHEzeJuWGfvbeqDZZrjpyToW4VLtlbHYscQP21Gvdg6VbPSQBajV35o12EsUAgRh FR8l21grA3hTe/+PSR+pKCXjbefoGEp4b5q4Yrx0JDibHd4bMHJf2xdilU+5eWqaJYHA= X-Gm-Gg: Acq92OHuWuoxHIx8GFatOUwGELARtl7Zz3JfR6j+TM2mOBa9Me8/RlZTrF1ueXiPCd+ 9ZHU5V6apCsfe9SgqKadZjQ7CWUi+9JZyPuIoR0DO8mMfAMU92V+JiBvqa6yqI6gMU2UlZcmgkf TYg1qeWCvyMhluEgmS4KoUlA6vCERYjdmOsvoSH5ZuJrgilP8s1QDwdIXldvnwqAf3xEVX3rraG 0PfezLii3+TKHxRhAjCm9Xb6HdSfMZrb2xOiyQnWcBQnMDmwnf1GHVE5pahHXYDesPxpuvGh3qN ldgmOe3Gb+OeiZvkjmRxNuyl28DDdXt0VrylpH/zzLXnXdRz5LzW89FgxWGJyZS/G8Z7P2L6UKP q0cUNnxooZ4yE5KqzDBZmNMMJ6XOdDMLyZ9AjWGLNX+Hw6TVaLwSfy3vivSgPK88PpbClWBJkcd B/KrK10PkD0m8wAofPgLM= X-Received: by 2002:a17:903:990:b0:2ae:6259:5aff with SMTP id d9443c01a7336-2bd7e784bd9mr44811545ad.6.1778848978189; Fri, 15 May 2026 05:42:58 -0700 (PDT) X-Received: by 2002:a17:903:990:b0:2ae:6259:5aff with SMTP id d9443c01a7336-2bd7e784bd9mr44811275ad.6.1778848977719; Fri, 15 May 2026 05:42:57 -0700 (PDT) Received: from QCOM-SocCW5bzXR.qualcomm.com (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2bd5c05f27csm56119395ad.25.2026.05.15.05.42.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 May 2026 05:42:57 -0700 (PDT) From: Jianping Li To: srini@kernel.org, amahesh@qti.qualcomm.com, arnd@arndb.de, gregkh@linuxfoundation.org, abelvesa@kernel.org, jorge.ramirez-ortiz@linaro.org Cc: Ekansh Gupta , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, quic_chennak@quicinc.com, Jianping Li Subject: [PATCH v5 5/5] misc: fastrpc: Allow fastrpc_buf_free() to accept NULL Date: Fri, 15 May 2026 20:42:17 +0800 Message-Id: <20260515124217.20723-6-jianping.li@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260515124217.20723-1-jianping.li@oss.qualcomm.com> References: <20260515124217.20723-1-jianping.li@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTE1MDEyOSBTYWx0ZWRfX26eDZx1903ld VUIBziQuAr6haaUU3JS98DZTwuxGzSPHPhdR/OdWWSDniFYJCvOsSqdEXnOaywME2Ps22ncoSYe qZb9Z1vqI4UI2y9/EOURFp2ZXlt3LZa6Ld2A8MeDgHERHnqAKLeDqYKymposBunP0tsIFGoO5HU SgFPTVF+9eFYNwaRU5b6colFeTvisD7itjUu8SS7QGuBQH2k6f0rUNBnAEOiiWwHhTmiONRXC0N dWX4125yzldoi9JaGb6DYmyfBSUSt04bnvWujGOUfaGA/qqUekTolm6FAhCU6eAM0KaDQklNNty e8L28G8EZYyY8LEfZVDqk8290aipuH8G5ZgMYLpB3rIIePQ0dmbrc2Y/qnOa2zr25BxtiL55z2Y u8Xt12U1v4ANM5x1m3ojs4uYLyc8WYP4aC3NfQ/7HV2fkSl+dC4ZpXz+KRp5ReF7X5NzQGXl01e qa3CyXDuDWjVmFn00Zg== X-Authority-Analysis: v=2.4 cv=cZXiaHDM c=1 sm=1 tr=0 ts=6a0714d3 cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=GmafkBk8WXepDEkBruoA:9 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-GUID: kWvLOP3T_28kM2-3w9xVCRECkil-8c__ X-Proofpoint-ORIG-GUID: kWvLOP3T_28kM2-3w9xVCRECkil-8c__ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-15_03,2026-05-13_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 spamscore=0 phishscore=0 suspectscore=0 adultscore=0 bulkscore=0 impostorscore=0 malwarescore=0 clxscore=1015 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605150129 From: Ekansh Gupta Make fastrpc_buf_free() a no-op when passed a NULL pointer, allowing callers to avoid open-coded NULL checks. Co-developed-by: Ekansh Gupta Signed-off-by: Ekansh Gupta Signed-off-by: Jianping Li --- drivers/misc/fastrpc.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c index 9c70788afa0f..82bfbf342725 100644 --- a/drivers/misc/fastrpc.c +++ b/drivers/misc/fastrpc.c @@ -416,6 +416,9 @@ static int fastrpc_map_lookup(struct fastrpc_user *fl, int fd, static void fastrpc_buf_free(struct fastrpc_buf *buf) { + if (!buf) + return; + dma_free_coherent(buf->dev, buf->size, buf->virt, fastrpc_ipa_to_dma_addr(buf->fl->cctx, buf->dma_addr)); kfree(buf); @@ -512,8 +515,7 @@ static void fastrpc_context_free(struct kref *ref) for (i = 0; i < ctx->nbufs; i++) fastrpc_map_put(ctx->maps[i]); - if (ctx->buf) - fastrpc_buf_free(ctx->buf); + fastrpc_buf_free(ctx->buf); spin_lock_irqsave(&cctx->lock, flags); idr_remove(&cctx->ctx_idr, ctx->ctxid >> 4); @@ -1564,8 +1566,7 @@ static int fastrpc_device_release(struct inode *inode, struct file *file) list_del(&fl->user); spin_unlock_irqrestore(&cctx->lock, flags); - if (fl->init_mem) - fastrpc_buf_free(fl->init_mem); + fastrpc_buf_free(fl->init_mem); list_for_each_entry_safe(ctx, n, &fl->pending, node) { list_del(&ctx->node); -- 2.43.0