From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4EE90399D02 for ; Thu, 21 May 2026 07:22:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779348127; cv=none; b=XQOisPJ72aJBa+HhnTCoBrZCaiKRpArdtaKPLMTl6ZDvZoVflwDs1v/Ln2Js4Q6LnK0lGgJP3AmUN4i4FB3RAE/SVV91LT6eSGFbuaCM+SKkIsBvsLK/iSCCFt0n79EBn7Mkr8rqS63+PV81cW5FaF7NIcWyuy1OgQwJ3GedhLw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779348127; c=relaxed/simple; bh=s4R2Qr199Q0coUmKNOJQZtFnltSpVGAoB1aOSOudBX8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bcFGl1N6nZKRGqhyl36LRuSHUzU9rpeai6/18eNDScE0/AJt4jdpItZAe8h929Pkhui8u5Nb36bq78CEkWNtGtMAQR7Jdrp7/CK4gRMHCap8UevhXnhV9hdHzmIfohKVy3gPftDSjRRvba47f4qmLvpVAUxCACvMhvIBgtc2kBA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=oj+XH5aE; arc=none smtp.client-ip=209.85.210.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="oj+XH5aE" Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-8354461da74so2594295b3a.1 for ; Thu, 21 May 2026 00:22:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779348125; x=1779952925; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=mxmsocRTSr0oM4XOAp/+uZK3GT7M6xq1xF4d1oUBSdc=; b=oj+XH5aEab6/JiVapGJmdZwtDx7qoS8mUMgzc7fj8vbbBZ3QvpYG5aTvJo4mhtTzm6 ZtIyXnK+LWqEbput21K0qJi2KoEeRNSD5HDCSTGYokbt+EUsF7k9yzl70BEduJ3aIgxd yK7Y0LKq1zJBSwb0AVOp598aziGSabm1fv/8Gwqo3s3sFUI54DvN3I54w0rwlLuEgISf 6TmzhA4lL/mWENAgAq3GOWmXho1vRi/ZwsjjtX9u0ZWQPtrUSgPLx+Oiob5fY/w40QOR D8pT1PrxkfFgYaGq4M9DVNLy0I3d0c/zc3Qt+jjGDdiTxM+a06eJJFcNVIpWgD5QuJRT oa6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779348125; x=1779952925; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=mxmsocRTSr0oM4XOAp/+uZK3GT7M6xq1xF4d1oUBSdc=; b=j/oZA1N9mj5WBqWR+k7SFBNHMoUtjkrXODF6LM9h1u7fWdPAq48rEbMmGjEBy2CO9L /NGC80x8jyPKv9JNgztmii7Pzd7TaMkfNy+Bi+GZLzeSt9WfCuDuqO3iI/9aAL1SMm/D 2wlmdaAqVZ3wkcTNwcUT4J48unHsun7njNqT6LcYbdLQcNq7qL25qKhBcHgRCVEZ5GAk CzxNKpJMoggmi/lkTR7m7mMfwxLblrwSH7CzZ2Y8CMn1kkA14Y89qEJr8t9HDeOgzHh7 kY2RQ2gsINT3aHFcOIwu4WkN9FHODPbpPk6JX5Z7mN/F4QypAmL1gFxWE3uZFpwpNKQB iSbg== X-Forwarded-Encrypted: i=1; AFNElJ8dhNzbL9fempCJf0cHErJHFfr6QEAlMjUT7KTmr6Nu35yqiCJkRB7XkYaWSxSGr47PFQd0Bm2OasAYVfs=@vger.kernel.org X-Gm-Message-State: AOJu0YzdmYrCPkzD65NvwTLuhlwZwFAVfCZjgqE/rauEeyUKZO9OyTuV ffdGZzgtAvcvU5mOLJ5ioRQuDEP3Q9demkAP6152RKcAO/QC9xr73nrX X-Gm-Gg: Acq92OFBrYEmTw4gpj+xw66bwbUfxVPWnUeY4cug81Uz3Dv+zUABsKRYIXrYHj3PsRG NXyKCYFn/HNMsezPcPcL0trLmyDt/qdk+0n9coumvVtWMmLx0xGo01sHvsoC5cjsIgWjK7FG4/d Jg83Sx257sQ4/AO0itAH06Eo6rMLc+cTNiayPteZAbGdGnOuamYe19uY7vzrE+TFjCfB6KlzANg gZ/ggB+9bdqG5p8GFvtSrEK8INg7GdFBd4Zftz5HxdClh9ihH/CnllJZGFY5NR25fW25PsaWBZw LevDlU+Dc0MLI1tgqhGJPCqKPKSM50vdEwr1/fjKKleXGkXnqnpuaOeA8UhXo2YR1Amdm9mrHlu 3LHT4ovF288PFHBlQofPK4ecdv2bqvSXAJK4LFhyN606SLcaPFKlRhPRrtD7ARimCOZRr/rVVvK IFMsunSO44JAKX6JJMXJ/Rph8= X-Received: by 2002:a05:6a00:4501:b0:83f:250d:5ab with SMTP id d2e1a72fcca58-8414ac7a05emr1801583b3a.7.1779348125528; Thu, 21 May 2026 00:22:05 -0700 (PDT) Received: from localhost ([2001:19f0:8001:1b2d:5400:5ff:fefa:a95d]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84154a00089sm306760b3a.20.2026.05.21.00.22.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 May 2026 00:22:05 -0700 (PDT) From: Inochi Amaoto To: Ulf Hansson , Karol Gugala , Mateusz Holenko , Gabriel Somlo , Joel Stanley , Maciej Dudek , Paul Mackerras Cc: Inochi Amaoto , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, Yixun Lan , Longbin Li Subject: [PATCH v5 1/2] mmc: litex_mmc: Use DIV_ROUND_UP for more accurate clock calculation Date: Thu, 21 May 2026 15:21:20 +0800 Message-ID: <20260521072122.1601215-2-inochiama@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260521072122.1601215-1-inochiama@gmail.com> References: <20260521072122.1601215-1-inochiama@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The previous clock uses roundup_pow_of_two() to calculate the core clock frequency. It does not meet the actual hardware meaning. The actual frequency is calculated by "ref_clk / ((div >> 1) << 1)". Fix the clock divider calculation. Fixes: 92e099104729 ("mmc: Add driver for LiteX's LiteSDCard interface") Signed-off-by: Inochi Amaoto --- drivers/mmc/host/litex_mmc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/mmc/host/litex_mmc.c b/drivers/mmc/host/litex_mmc.c index d2f19c2dc673..52571bb17c61 100644 --- a/drivers/mmc/host/litex_mmc.c +++ b/drivers/mmc/host/litex_mmc.c @@ -16,6 +16,7 @@ #include #include #include +#include #include #include #include @@ -436,11 +437,10 @@ static void litex_mmc_setclk(struct litex_mmc_host *host, unsigned int freq) struct device *dev = mmc_dev(host->mmc); u32 div; - div = freq ? host->ref_clk / freq : 256U; - div = roundup_pow_of_two(div); + div = freq ? DIV_ROUND_UP(host->ref_clk, freq) : 256U; div = clamp(div, 2U, 256U); dev_dbg(dev, "sd_clk_freq=%d: set to %d via div=%d\n", - freq, host->ref_clk / div, div); + freq, host->ref_clk / ((div + 1) & ~1U), div); litex_write16(host->sdphy + LITEX_PHY_CLOCKERDIV, div); host->sd_clk = freq; } -- 2.54.0