From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D3F0F1684B0 for ; Sun, 5 Jul 2026 05:04:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783227888; cv=none; b=gMgzdaPAdefhKUsF58Ilx7QLQIJ/v+VeopphdzVlcvssXv6/ncawhtUNjHwL70xj48EUPozf7aIerjGLs5n9DvaY9SfqZ4WmvzmQcKltvEfqhyto03IAzCJKgl+0wxObxiaf/NMEdeUcdT1BYKm5EE5jDSW7+lvibS8WJzIsiUE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783227888; c=relaxed/simple; bh=g2IcKpyrWKW2kwgfDe4vrcXDqRs97rHlKyippcALm3M=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=OK/BV6Y6D33G3/q9br+1G6rvQRVRYDOxy62hbKRT4FevaO1GG4r6cGwjl+eP81AZtEMN3BbfgWB/9CzfB3FLZRbjOr0jaJtk/mAuolPtcgLzRIMAfQ57LbGrQjLiGDqkXwJiC65laGgJjGXPiTCjkx7Eaw08Tm6l7TWz19RGT7g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fzAu+iTV; arc=none smtp.client-ip=209.85.210.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fzAu+iTV" Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-846970f0acaso1766802b3a.3 for ; Sat, 04 Jul 2026 22:04:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783227886; x=1783832686; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=e3HuwUbG+Mn1Fyekwox0FnTgEFt3jewOA0gc/xR54aY=; b=fzAu+iTV2EYMYmFOM9VpUY5l/aokrxpc0k4iihBBae4o/j1yhhwvTCpXK+0tOPgA0b /oUelux/4q8DJeKUK8z6tWqNHJAd4xpCjQQdXNM+rBXhXm8OkUUGd3d0EkgSUf4tWuIL c+Xq5Viez+kD0CWA713GlZyTQV3DyrFUGs9MNzoXjRc4HcCpQN8MhQmZwJZVzjcDNYFm gcT1Oq6jsT9habQdeMpFMG19r/VLW4YrctI0PyE5hSna5NAonJLJmnKUvghQu/B5kHAc dz3lMnFCmCXBUp48YbaBrmiCetlbxelIdTqWa3HJ3EiLiclQJZtJCLIisytmt40PxlEq wEGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783227886; x=1783832686; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=e3HuwUbG+Mn1Fyekwox0FnTgEFt3jewOA0gc/xR54aY=; b=N4HfEuoPysHTcksi5pEFW7d0xLboAj2xMcvtLmyn7ycE68RSzMM86jqYpLmBI+KEup NiHEzUgaHY39xJO/fQEkKVyBTxiijAUatUZRrc890xBMH3g/vnBGoudAAdeSklj1GqRu hUIwsW2/zzjugCbmXiTcqHtt+N+pDSCaM0AQntAKtVDeH2/pWwes0mIPSGpYz3bI6u5s KLsROgejbA7Gr+iMcG6Mw+2ykdww8i0yVHX2Y1XitxkyD2jEoDgxOincoC810qjVsbX3 lBMukepC3bL6kvW/ZVL8+620FETFIok830zTgVZBDBM7av44WcJYknAADKF8p6qIz+bA ibng== X-Forwarded-Encrypted: i=1; AFNElJ8oVaKXfoLHNbYw+C+FYxMMdu7ohTXhpl3bqd4LnDqcUuX5F1AyOaJ38h2EHr2+n19Q362rqw2SzUcK+N0=@vger.kernel.org X-Gm-Message-State: AOJu0YxPmgJvVbjWfCGyD9/QxFsQkf+ih6uAQhKcUVKATAKaD4PcY+Re 31SuQia9KN4yFOQayB/ZvbxeI1tKeO0kT2iysIw6tDV74JoCMzJxsCd0MD96hA== X-Gm-Gg: AfdE7cnURJW5iAPuzS44sxm2FSNctelIoO5uQjYuhQ0ouA10gBdet4xGZb2veNfRW3w iGuGpXO6YokUEWoD54skxD+HEzOsteALsBeXjIMWtXzCaAMzkSzHqwyVNCFZW+/W8MzdTmdXuNX j+kZV1pAIrSwt1zpiIc4dP+DhRfo2lm0VuW/x6H9TjMZQf48iW0C0YErry9NKukPliGwgY3zuOb tncwtjhuEv2E+3Yh0IZL2AiqwWDMFmdhC42/8ibQX+0bslA/LWZ7YjbKMyLE3o7u1DtbztXAcgN Y40VsVsJayOgbUJ/X9nwNawCkW7Bg4JHggDxOjki471HgvXSwjpP2+PhHJUzw4uEOSlDc2T/nQV BpacgbD4PTv2J83yZhmwji9yrqhnyrRGZ5OhI3P0L91ofP8IQKnpGfDxa383lsTjrVYQnW8Eu1Q qZf5GZSjGBdyEkPeZn5hCmyouegWZ7P1wgPp1oibu/8xRVU5NrtWqUL6+vIvBE2/F4JfnnT9Zhb BT/ X-Received: by 2002:a05:6300:4c:b0:3bd:3a53:c147 with SMTP id adf61e73a8af0-3c03e503125mr5654778637.45.1783227886092; Sat, 04 Jul 2026 22:04:46 -0700 (PDT) Received: from dtor-ws.sjc.corp.google.com ([2a00:79e0:2ebe:8:4560:aa1b:b33a:15b8]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30f3b252222sm19585414eec.23.2026.07.04.22.04.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 Jul 2026 22:04:45 -0700 (PDT) From: Dmitry Torokhov Date: Sat, 04 Jul 2026 22:04:37 -0700 Subject: [PATCH 1/2] sh: mach-x3proto: add software node for GPIO controller Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260704-sh-x3proto-swnode-v1-1-0c039549dc46@gmail.com> References: <20260704-sh-x3proto-swnode-v1-0-0c039549dc46@gmail.com> In-Reply-To: <20260704-sh-x3proto-swnode-v1-0-0c039549dc46@gmail.com> To: Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz Cc: Linus Walleij , Bartosz Golaszewski , Arnd Bergmann , linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.16-dev-6911d We want to convert the legacy gpio-keys platform device on the SH-X3 Prototype board to use software nodes. To do this properly and allow referencing the GPIO controller by address rather than relying on name-based matching (which is being removed from the gpiolib core), we need to associate the GPIO controller with a software node. Introduce x3proto_gpiochip_node, register it, and associate it with x3proto_gpio_chip. Assisted-by: Antigravity:gemini-3.5-flash Signed-off-by: Dmitry Torokhov --- arch/sh/boards/mach-x3proto/gpio.c | 15 ++++++++++++++- arch/sh/include/mach-x3proto/mach/hardware.h | 2 ++ 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/arch/sh/boards/mach-x3proto/gpio.c b/arch/sh/boards/mach-x3proto/gpio.c index c13d51b29702..a09cafc782b4 100644 --- a/arch/sh/boards/mach-x3proto/gpio.c +++ b/arch/sh/boards/mach-x3proto/gpio.c @@ -18,6 +18,7 @@ #include #include #include +#include #define KEYCTLR 0xb81c0000 #define KEYOUTR 0xb81c0002 @@ -73,6 +74,10 @@ static void x3proto_gpio_irq_handler(struct irq_desc *desc) chip->irq_unmask(data); } +const struct software_node x3proto_gpiochip_node = { + .name = "x3proto-gpio", +}; + struct gpio_chip x3proto_gpio_chip = { .label = "x3proto-gpio", .direction_input = x3proto_gpio_direction_input, @@ -104,9 +109,15 @@ int __init x3proto_gpio_setup(void) if (unlikely(ilsel < 0)) return ilsel; + ret = software_node_register(&x3proto_gpiochip_node); + if (ret) + goto err_gpio; + + x3proto_gpio_chip.fwnode = software_node_fwnode(&x3proto_gpiochip_node); + ret = gpiochip_add_data(&x3proto_gpio_chip, NULL); if (unlikely(ret)) - goto err_gpio; + goto err_swnode; x3proto_irq_domain = irq_domain_create_linear(NULL, NR_BASEBOARD_GPIOS, &x3proto_gpio_irq_ops, NULL); @@ -127,6 +138,8 @@ int __init x3proto_gpio_setup(void) err_irq: gpiochip_remove(&x3proto_gpio_chip); ret = 0; +err_swnode: + software_node_unregister(&x3proto_gpiochip_node); err_gpio: synchronize_irq(ilsel); diff --git a/arch/sh/include/mach-x3proto/mach/hardware.h b/arch/sh/include/mach-x3proto/mach/hardware.h index 57ea4a5cca35..1ee5a404973c 100644 --- a/arch/sh/include/mach-x3proto/mach/hardware.h +++ b/arch/sh/include/mach-x3proto/mach/hardware.h @@ -3,10 +3,12 @@ #define __MACH_X3PROTO_HARDWARE_H struct gpio_chip; +struct software_node; /* arch/sh/boards/mach-x3proto/gpio.c */ int x3proto_gpio_setup(void); extern struct gpio_chip x3proto_gpio_chip; +extern const struct software_node x3proto_gpiochip_node; #define NR_BASEBOARD_GPIOS 16 -- 2.55.0.rc0.799.gd6f94ed593-goog