From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 95A6F37E5F4 for ; Sat, 25 Jul 2026 15:53:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784994832; cv=none; b=ILSnGUxAkjMpFHp9echsvb9plyZ/0ISXb6w5VZ8mqaTLnriWJvVLSNeXrDM9dnLQOGSOJEARpvuwGChNeF7ZhUaUwrzBybrY7zzQjDPO8wX6tumcvI3uqXBbXPUTMJpK6smpMQeScXwSRPhcNOu2Xi8bnRiHkB8tXBEZP+nCBCc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784994832; c=relaxed/simple; bh=OpOhBYcuN0nyRTyfRTNGDk26BsFJngmTdWDqs4lr7SA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=CNmo9tkG83ewwuhFuhG6F+4Ov9OyOGb/RQJ0WAKU2wsSVYUf/QFXPGyKYBQvDEd84/wm+8UAUKX83NsKIF4HatuYdqLbK67sNHjrIoQ2L+QnOrytKmA3HTwBvzBMcKG4wAj8aebStdp8g+YbmSD6mmU5SS0d3yvXdM03lldBD5M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OuCZHZEW; arc=none smtp.client-ip=209.85.210.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OuCZHZEW" Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-84830c774a0so1408082b3a.1 for ; Sat, 25 Jul 2026 08:53:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784994828; x=1785599628; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=haKzi9zaiexZgw6Xqxh6nKl14oEv35kMvzujmPCscgI=; b=OuCZHZEWlKr7zik1Qppb1caDM4Kl6XST9UK/OYaUB2dpdygQ+m79hpD+aN3Qqu1YdU H8aPmOVDGdMyV100WvmWiPk586SdfaivgYhgWIASsBADq/w30kJ9sywtgO9FDSHDePVu NmGDRIdNAcp6O6oNopo7C0ci0zhLMaUgo3xysmvhEaURDyENtV7imzfO+y1UGQnNzYnC H8B95GhjPKQy+jsMM52H80NmCYrlf7p9bgAW5O0FwpYlkwZ1Fq8b0XjumcTe/o8TsE8r nfUgg8KbsB0m/mFvwYjhWWoiMf56zsOel5FoPPovYHX2GK6AtuT7q3vReWoYnyysZk4x L+dQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784994828; x=1785599628; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=haKzi9zaiexZgw6Xqxh6nKl14oEv35kMvzujmPCscgI=; b=kcZdrom4sNiOLW4CIGBfQwCdMHbbMZj0zcWgJ0pr+wvJtO45ZyC38XWb3r5ekRBk7w oPacadXPQCc19lDtLvB/wm9aOiOzeZujXFrbZ4huQzuYnSVYlAOyi5kItxX7PMUZeuuE 2i9oJVabq0/ZskA6/p3usmdZnA17BAx44Z2nqjGRM3nNQ8c6lHzysDBUwQ5QDHnPN03n AyZKlKkH85f68rpxhaL4s5T+hpXRwynPfHEkxHqVeznn0vovtCrQ06oLSFJ2M0no7z77 MjVYMbxwxu5oItOrj/1pOv0rmoosruPRd3u/4lrY4Fu6uE9qHSFEiyfkU3o2SU6Jd1/J Qlsg== X-Forwarded-Encrypted: i=1; AHgh+RqgbR8ueoWADxskwbdG495K6AftgPwUp51pc5Aqv45VgUVs1q+p7aqGPQcWKCvWO0cBgv2ms6U9Zcs6swE=@vger.kernel.org X-Gm-Message-State: AOJu0YzRk1UlnihVQmVIDszSPFuhFLt8Z7dLjy7fc6zvTCik+q3b5Yi8 Sx+N7x8wrmdKyhS+vREuI4mN/Y6Zovi+xC7miKmV2hXheWCVRmB69QggsjMeqhO44Yc= X-Gm-Gg: AR+sD10MA6LpEuEKAhnRu0UsBQHzc6HGiKzddYNwzZ9wyYGV5/eMuTPfFJ0RMBdAnKQ ggXS4i11+/POEaANhsCI5tkfWhAI9qkq2se8CsQxhM4Q2zU6QetZwU6I4TdG8lO646u1gr2+Ctn U/pBvb8RJ+ztxwBZDRIvD3UKXwqQppzxNU4FLiwXiFbcTCYpdcDAyVEuBxzbM4QHv7VEaxqCpEF J4iZFSO816sYBWosA26r2c70P+56/Ub/7f0NKecFGjJbQwGSV2MMVjYVZW1xjHbn/YTRoghsG6B o0TPhQAqqhc2eZuZPdJ5Aot3JEh3dndVg/0MYAT/aAJ6wAdj4rVuIT/2dVGCuFOrWadAfIg0Cun lJcQQ3exWyYr2AxxiWXmpP+7byvLWddLxcCqtLoc5nc+ikiYeUo6sF0a98zZ8uVEO4mR85GtkAf MIlbsaQXhx3NGbz9YDDufNixv9LE59V5HJgrqc X-Received: by 2002:a05:6a21:4c03:b0:3bf:6237:4d49 with SMTP id adf61e73a8af0-3c67da78f32mr2776721637.23.1784994828226; Sat, 25 Jul 2026 08:53:48 -0700 (PDT) Received: from localhost.localdomain ([103.149.158.159]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-314bc549b11sm12630500eec.18.2026.07.25.08.53.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Jul 2026 08:53:47 -0700 (PDT) From: Sreeraj S Kurup To: o-takashi@sakamocchi.jp Cc: linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, Sreeraj S Kurup Subject: [PATCH v3 0/2] firewire: core: validate descriptor and sub-block lengths in fw_core_add_descriptor() Date: Sat, 25 Jul 2026 15:52:53 +0000 Message-ID: <20260725155255.3054-1-sreekuttan2156239@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This two-patch series addresses potential out-of-bounds memory accesses when parsing Config ROM descriptors in fw_core_add_descriptor(). Patch 1 adds overall length validation using the in_range() macro to ensure descriptors fit within standard IEEE 1394 Config ROM limits (256 quadlets). Patch 2 validates individual sub-block header lengths during iteration to prevent reading past allocated buffer boundaries on malformed inputs. v2 -> v3: - Split original single patch into two distinct commits for cleaner review as requested by Takashi Sakamoto. - Simplified overall length check using the in_range() macro. Sreeraj S Kurup (2): firewire: core: validate overall descriptor length in fw_core_add_descriptor() firewire: core: validate sub-block lengths in fw_core_add_descriptor() drivers/firewire/core-card.c | 28 ++++++++++++++++++++++------ 1 file changed, 22 insertions(+), 6 deletions(-) -- 2.54.0