From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr2-f12.google.com (mail-wr2-f12.google.com [74.125.225.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7ECDC46EF92 for ; Sun, 20 Sep 2026 18:05:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.225.76 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789927533; cv=none; b=jtGFsqukr3BWut1AhVeCV+dRtTW5I5uRvejlCmoQGrxrBax4e5sME/vHqdGpGOu3Mdh/4f569pc2sQNpgVT97d53kBTguFqv/xRyIgcl/NWABkGtkgmKAdXAIzJgjMlQpD7Zff1VztCd+kNkhhKPOv+BVdaF9qXZT0CHnEYFGJY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789927533; c=relaxed/simple; bh=pjgBUps3bhRyY6u6ycXVMzX0Fos9VuZiAf5efJGxEsE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=bro+DDLhpk3Bv9uz23wCVAgjJ3Qv3xmzgqJ8jqyO43WMXqiSxPezbyJjny/7k8GglfcgxDo0nvf39vfh9ymHLm3fdpewymN8xmwGeVWTw7O4wHFFpH3yomKonpeszzjMR0ovOiqyZH5DFtmrWER1VdDoiyTrlfshPi6nPmOvabs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OEUEhQKZ; arc=none smtp.client-ip=74.125.225.76 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OEUEhQKZ" Received: by mail-wr2-f12.google.com with SMTP id ffacd0b85a97d-485b1d2874fso777768f8f.0 for ; Sun, 20 Sep 2026 11:05:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789927529; x=1790532329; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=/eKvqLxq/FDnVLXWqL74StVCqkT72bEtQBBRhBThWEs=; b=OEUEhQKZKDkV1L/B+R+7tZsGgjYjLAZowSLRUM3FR4ktYBsQKn1WJ7yGPWDX2X1DYI nuQP22ynoC8zmU4p7qGeHts5oWvQkdFZLAvhMlzxUpkR5dODrCK8GctmlzGRnE+6pH/d FbP7y8tJXk4c5x1qBXW8se1pFBFfu3wn5YdJ9H2HER4kOhEQig6uGnZMKBqlxmTqhvBI qa4CncvlLK4W88PgavH5qX+F68O/JlGMjYWoD1Qi2vkLtYMpB/92WQ65qoDdKehUH8Bb 2MUafT4oy98sQTxTud+eR78+6/SYeqKekJeXEzMt+YsnH4l/zZigxL8rOPzNFvkTBVAe mrTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789927529; x=1790532329; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=/eKvqLxq/FDnVLXWqL74StVCqkT72bEtQBBRhBThWEs=; b=BC/OiuA6QmjNsUxNgTUZZ+/r/20wA0KBLmONYKLOMyQ7Xm0GL+lOyWA9PTXwZFJjfW 3UcQTbX7pLWgCQidpgjfZdId35ZCIOxgrVWDGcQ5g+Qoo/VPGSZd/SbCwUtdsNwdO3ym qG8XTLjn+gb7sIpAcktPrc7fx3kkhocv29OtAAeEc466ttMKE+uCrACKzibFOBNUlzxU iQmfiplwmRpMkYPCvAMwPkoaDZc8Zsz4RCVbcWljhhPgdYmwf93xp0SWciAf57VbujCB p6rZ2trpTLmnHcnaMRJoF86ZrH4hOvS5NmWzuq8s67e8AAs27wYnQ50pl0w7Vy7iF9AV cEEw== X-Forwarded-Encrypted: i=1; AKwUvBymDJp9e/6uz9in41ix9pxEUW7Ln264xz/tFXl8fKEeSH+hgr+z8AnhFeGEal46TNx/ABpoCxzfCxavG3E=@vger.kernel.org X-Gm-Message-State: AFuF++m6HrbaWM1zRu4/acspHLkb8/Lb0ALheoXupuG/2yD2CLUG9vWO iA7EST9PQjcOsMtkv9IEOp7xnPf4GtaH5jiyebNw18sPpV4fFehSYQaP X-Gm-Gg: AYBFou0YlYKSMHYjTf9texk8xyDxR278/5dwVluszZX8aAINgXFd1t9iebGA1CfFekH hoJfLLQk+cKU9ydT10R+F8Vc2GPkpc8m2yTskXkgPBXzZflisHXnRBDToNDdMlVHskkCDw/lxAc wPbGWBPIrPRvmuGC67BLw5PBNb6Qx7jxNIZsqdBWWP7xWU3WU9v9g76C/6plQh1XRrFWk6UMTjA 0PNSDB8YafOiJpzGnMRSFrwSOuB9lIHTzBUmemiMoiWZFi7SxQ6gHqH13XPmbWwW6vi0j+oU45R jr1YeBJAAwD8YTFjZabQdvIGT8WZRRFTRK4xVdiJ1ADthoZhuNJrc8DiQBjAujPh+oSptkSrcz/ UofFYnPH5izTCztO5NtGbdncj+RmD2HN344EoaA6lJBs9dshBUdfvtoE6QjnZ5IQQpYXsMXFPjR M1Eo0B7pEyR043ptaLZOOv19eR+OYy/Dn3fg5buoGDwvrWkb4XwiOLOvxDaMt+BgYyaSW1yE1ii 3Vii1R3SSehxkTtZfyYRAixE2I/eQhu5LnuAZU9HHkyCg/cc0KxH1mOoW/cIBSIGK4fIwWUkOaz fFNNc6RD7fl/0ZcgslbPKvDG/T8DcVMbsclwvb05NWnxIMHKHxX+2NC6hw4DnywkGcN2YfHur9Q jxbZmXSuUv/Eh0NLjhEmuE7FKAkDXnyIqFVJVnllb2rP2FQ== X-Received: by 2002:a05:600c:4714:b0:49e:6581:7baf with SMTP id 5b1f17b1804b1-49fc4f72886mr130088595e9.2.1789927529563; Sun, 20 Sep 2026 11:05:29 -0700 (PDT) Received: from [192.168.1.187] ([2a02:8308:4092:11f0::f9f]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49fcd0f7b9bsm164648055e9.5.2026.09.20.11.05.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Sep 2026 11:05:29 -0700 (PDT) From: Joshua Crofts Date: Sun, 20 Sep 2026 20:05:27 +0200 Subject: [PATCH v9 5/5] iio: magnetometer: ak8975: make use of the macros from bits.h Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Message-Id: <20260920-ak8975-cleanup-v9-5-1b0f00ec19ef@gmail.com> References: <20260920-ak8975-cleanup-v9-0-1b0f00ec19ef@gmail.com> In-Reply-To: <20260920-ak8975-cleanup-v9-0-1b0f00ec19ef@gmail.com> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Joshua Crofts , Andy Shevchenko X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1789927524; l=3014; i=joshua.crofts1@gmail.com; s=20260530; h=from:subject:message-id; bh=6ZMjVC6e/KIqTzgrm9DqPo2hpOPArGBVsN2S5dq6DFc=; b=51owwuPaLGk6u9mi2rhRJdyER1xoSr7TMn5CxXZCPw9yln+SCfYQCb9OH6/h3Bz8JTL/jEM24 RFPNwofyTeqDJWrQCF8I5sETkrcXmhra1aVT+W1+IAfiI1xbwaBKYaV X-Developer-Key: i=joshua.crofts1@gmail.com; a=ed25519; pk=RTDOoVwgeL4oFdASj9U+cxJuIjXuXk73zkjnGOJKbEo= From: Andy Shevchenko Make use of BIT() and GENMASK() where it makes sense. Signed-off-by: Andy Shevchenko Reviewed-by: Nuno Sá Co-developed-by: Joshua Crofts Signed-off-by: Joshua Crofts --- drivers/iio/magnetometer/ak8975.c | 26 +++++++++++--------------- 1 file changed, 11 insertions(+), 15 deletions(-) diff --git a/drivers/iio/magnetometer/ak8975.c b/drivers/iio/magnetometer/ak8975.c index ac556644b02d..05cdd285c5f4 100644 --- a/drivers/iio/magnetometer/ak8975.c +++ b/drivers/iio/magnetometer/ak8975.c @@ -44,8 +44,7 @@ #define AK8975_REG_INFO 0x01 #define AK8975_REG_ST1 0x02 -#define AK8975_REG_ST1_DRDY_SHIFT 0 -#define AK8975_REG_ST1_DRDY_MASK (1 << AK8975_REG_ST1_DRDY_SHIFT) +#define AK8975_REG_ST1_DRDY_MASK BIT(0) #define AK8975_REG_HXL 0x03 #define AK8975_REG_HXH 0x04 @@ -54,15 +53,12 @@ #define AK8975_REG_HZL 0x07 #define AK8975_REG_HZH 0x08 #define AK8975_REG_ST2 0x09 -#define AK8975_REG_ST2_DERR_SHIFT 2 -#define AK8975_REG_ST2_DERR_MASK (1 << AK8975_REG_ST2_DERR_SHIFT) +#define AK8975_REG_ST2_DERR_MASK BIT(2) -#define AK8975_REG_ST2_HOFL_SHIFT 3 -#define AK8975_REG_ST2_HOFL_MASK (1 << AK8975_REG_ST2_HOFL_SHIFT) +#define AK8975_REG_ST2_HOFL_MASK BIT(3) #define AK8975_REG_CNTL 0x0A -#define AK8975_REG_CNTL_MODE_SHIFT 0 -#define AK8975_REG_CNTL_MODE_MASK (0xF << AK8975_REG_CNTL_MODE_SHIFT) +#define AK8975_REG_CNTL_MODE_MASK GENMASK(3, 0) #define AK8975_REG_CNTL_MODE_POWER_DOWN 0x00 #define AK8975_REG_CNTL_MODE_ONCE 0x01 #define AK8975_REG_CNTL_MODE_SELF_TEST 0x08 @@ -94,8 +90,7 @@ #define AK09912_REG_ST1 0x10 -#define AK09912_REG_ST1_DRDY_SHIFT 0 -#define AK09912_REG_ST1_DRDY_MASK (1 << AK09912_REG_ST1_DRDY_SHIFT) +#define AK09912_REG_ST1_DRDY_MASK BIT(0) #define AK09912_REG_HXL 0x11 #define AK09912_REG_HXH 0x12 @@ -106,8 +101,7 @@ #define AK09912_REG_TMPS 0x17 #define AK09912_REG_ST2 0x18 -#define AK09912_REG_ST2_HOFL_SHIFT 3 -#define AK09912_REG_ST2_HOFL_MASK (1 << AK09912_REG_ST2_HOFL_SHIFT) +#define AK09912_REG_ST2_HOFL_MASK BIT(3) #define AK09912_REG_CNTL1 0x30 @@ -116,8 +110,7 @@ #define AK09912_REG_CNTL_MODE_ONCE 0x01 #define AK09912_REG_CNTL_MODE_SELF_TEST 0x10 #define AK09912_REG_CNTL_MODE_FUSE_ROM 0x1F -#define AK09912_REG_CNTL2_MODE_SHIFT 0 -#define AK09912_REG_CNTL2_MODE_MASK (0x1F << AK09912_REG_CNTL2_MODE_SHIFT) +#define AK09912_REG_CNTL2_MODE_MASK GENMASK(4, 0) #define AK09912_REG_CNTL3 0x32 @@ -864,7 +857,10 @@ static const struct iio_chan_spec ak8975_channels[] = { IIO_CHAN_SOFT_TIMESTAMP(AK8975_CHAN_TS), }; -static const unsigned long ak8975_scan_masks[] = { 0x7, 0 }; +static const unsigned long ak8975_scan_masks[] = { + BIT(AK8975_CHAN_X) | BIT(AK8975_CHAN_Y) | BIT(AK8975_CHAN_Z), + 0 +}; static const struct iio_info ak8975_info = { .read_raw = &ak8975_read_raw, -- 2.55.0