From: Jakub Kicinski <kuba@kernel.org>
To: Ratheesh Kannoth <rkannoth@marvell.com>
Cc: <netdev-bot+sashiko@kernel.org>, <davem@davemloft.net>,
<gakula@marvell.com>, <lcherian@marvell.com>,
<linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
<sgoutham@marvell.com>, <andrew+netdev@lunn.ch>,
<edumazet@google.com>, <pabeni@redhat.com>,
<saikrishnag@marvell.com>
Subject: Re: [PATCH net] octeontx2-af: guard is_pf_cgxmapped() when PF to CGX map is absent
Date: Mon, 21 Sep 2026 15:01:49 -0700 [thread overview]
Message-ID: <20260921150149.1af94192@kernel.org> (raw)
In-Reply-To: <aqzSYu6KduRWM42T@rkannoth-OptiPlex-7090>
On Fri, 18 Sep 2026 11:25:46 +0530 Ratheesh Kannoth wrote:
> On 2026-09-18 at 11:00:17, netdev-bot+sashiko@kernel.org (netdev-bot+sashiko@kernel.org) wrote:
> > Thank you for your contribution! Sashiko AI review found 1 potential
> > issue(s) to consider:
> >
> > Critical: 0 · High: 0 · Medium: 1 (1) · Low: 0
> >
> > - [Medium] The added `if (!rvu->pf2cgxlmac_map) return false;` in
> > `is_pf_cgxmapped()`…
> Will modify the commit message and will post v2 to net-next as a hardening patch.
no such thing as "hardening", please don't add defensive checks upstream
prev parent reply other threads:[~2026-09-21 22:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-15 2:29 Ratheesh Kannoth
2026-09-18 5:30 ` netdev-bot+sashiko
2026-09-18 5:55 ` Ratheesh Kannoth
2026-09-21 22:01 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260921150149.1af94192@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gakula@marvell.com \
--cc=lcherian@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev-bot+sashiko@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rkannoth@marvell.com \
--cc=saikrishnag@marvell.com \
--cc=sgoutham@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®