From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi2-f13.google.com (mail-oi2-f13.google.com [74.125.231.205]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 267E958B6C0 for ; Wed, 23 Sep 2026 22:35:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.231.205 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790202924; cv=none; b=OJWdXJLODi4T2dr/yEoEB9X2YkWFOUbs4YzrnbmP3NiRgNKNti4oscIhO6eJ484mQNZg9eWpxFUXYhha3Pvs3/b7TjeKImBX6mGpSivFBrlJh+VgO3d8+zZQAVjXPYzYmRyFet1xTxC+0Gungppw17RhitiUakdqf5eJbiCJI4U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790202924; c=relaxed/simple; bh=zCwr+VGqKnNAOkzayghTBT7W0F9XwKbxJ4/xtvRrwII=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=f85oaXmL4N/HVN5LkxFCaM+vd6Ws0grPi/PpbpMwUSl4LOaRQm5KYhMqktOji2WvbU7YM3b+x2LNbNKjlj28zlv1NMPZpDdF7wzJ0Lpv8d8BSLSljWuMs0q4y82mHqqQti7P+6GWh8nt5aL8WzNilx4zEeoQMUdEbiaTEozXbZI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nzja11FM; arc=none smtp.client-ip=74.125.231.205 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nzja11FM" Received: by mail-oi2-f13.google.com with SMTP id 5614622812f47-4b37a3ed714so1020271b6e.0 for ; Wed, 23 Sep 2026 15:35:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790202920; x=1790807720; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=zfwGwbUwBRuvPTUiKX1AIC4L/SKKbUUkwfFbVYVud+k=; b=nzja11FMb/s4BNpfi7CK/AvhmbHstDDYJKUhXQfnGZS8AblwgppnFMuZolhLkW4/DU A6bHAmkIXYx8Ovj8ZO5dU5sCL5+MAzfLwRTYdXKferqxJBzV+5m9WHU2fO/Vh+jbDlmZ LROZ+1eGKV5LA5KfbtSrSEZ4W3Qe+KqxpyRjss0m18AMAXDdd0niqpIle8L9bCU5wIXt fqkWECLtaJ5AZ27aG5OF3W6/mW4FIRG1qFr9H9ldmJBQslzztYHuaj28vtO9rc54A5NY 3ZvbUuJcaXNg6tXtzwFxjlECYiuECs5JWG9mr6cmuZ6OAjvRW+rkMc6gjicBDF2vs91i ojOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790202920; x=1790807720; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=zfwGwbUwBRuvPTUiKX1AIC4L/SKKbUUkwfFbVYVud+k=; b=I8PlC0dcQHB9dS0PDhb0pv1YLdhuGWS47bTkKIpKXqG0oYBZliXbmtkr55CKq/G7P0 6vSy8OutzgQLdYBTmETPGJGaLKh/rvgsRs0jL/pZbZsl+WGRklBSXzFCLPrRKBAeKnsN r6/B0IFvavR6oYazWzNFMp7Ed7jxEskKBEGbbm0CuIXzJbQoL+fSL+qdonfPMb+1Cx4R M5jCHIHYis3tB/PE1jH9rg82LXabH0he+2c3UO5ZGVYPuD0JT+If8WozafGljAv/51oI mTV7zXi3IHoSJ2N0VX2RyE4ryZuuaENH5WKtDGFYuL+e9URtopxx3U4LIEZ4uToG8l8x Iufw== X-Gm-Message-State: AFuF++lSmGkfEpl/ce7u0zKYhK11ByajJsNEEqWadRXaRMNCm7+cf3mB zX+zh0djwLYgWXuCwN/efTPm653VFseGxMSXZr+qfagnlkw+0gJG2JOm X-Gm-Gg: AYBFou1Oa5qziuOYgI/Sx0bRq0MEhQIk3m4/KZgCEvQEWmAUfpWncar+1hB3hyVk8Hz WKEU3PZ1VLFFv+HXsFUzpxOeHZ/UvhYSDiL/cosMCSxgHXi6a1FKP3SVFpfHhXywNsFAxnvgryR 8KFa0lfjAOfEXVg1AciE6ejbbEr4Biq0Eo2HNHTWQkZfkRUgv6utWgjvxSSCMszq/9zJOZz3/P/ 4IDe3cSLjOjklxgxrgKx4uY+jHMBuaOkn22xxQ5iGl7tStsWI6DXl48TG80j8nZWyi5f8GYwZOY IQRBx0JmIjKFw8wB3CLPSYS+gbTNOK+Y6GH011m5vZvg5cnzpY+uzoz+JGTe2Es4WRAOJB3/X4o 52nrsojDx0/vV5F2HfPWtTnoUcgWRDXnHTZp+lE3Vobd+8JZQK7PVX4W0PiOBF4iSlGiPoTfxeZ NbpFZOvQnsnrOYI7AZxSwX1kUx89gyx7SDRKeEygTsqfhOs8nfz35pWN+jCWDpO67cfxHivWYxe cuo5zX5JjtpZTWFdU0lY/Ziuu+hBIm0D8/0HjsAHoWVBs2VlusunUo5dQ+2kVwa7IJeBxj4f78M aMk7/vVMd+G7FPUpA6Vb X-Received: by 2002:a05:6808:15a0:b0:4d6:9252:4644 with SMTP id 5614622812f47-4d72ea60fb1mr765397b6e.56.1790202919796; Wed, 23 Sep 2026 15:35:19 -0700 (PDT) Received: from [100.82.231.29] (c-98-38-17-99.hsd1.co.comcast.net. [98.38.17.99]) by smtp.googlemail.com with ESMTPSA id 586e51a60fabf-491ee1ac486sm559401fac.16.2026.09.23.15.35.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Sep 2026 15:35:19 -0700 (PDT) From: Jim Cromie Date: Wed, 23 Sep 2026 16:34:42 -0600 Subject: [PATCH v11 18/38] dyndbg: macrofy a 2-index for-loop pattern Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260923-dd-cmap-part2-clean-v11-18-9b6c217fdf2f@gmail.com> References: <20260923-dd-cmap-part2-clean-v11-0-9b6c217fdf2f@gmail.com> In-Reply-To: <20260923-dd-cmap-part2-clean-v11-0-9b6c217fdf2f@gmail.com> To: Jason Baron , Shuah Khan , Andrew Morton , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Arnd Bergmann , Luis Chamberlain , Petr Pavlu , Daniel Gomez , Sami Tolvanen , Aaron Tomlin , Jonathan Corbet , Greg Kroah-Hartman , Nathan Chancellor , Nicolas Schier , Shuah Khan , Randy Dunlap , "Rafael J. Wysocki" , Pavel Machek , Len Brown , Jonathan Corbet , Petr Mladek , Steven Rostedt , John Ogness , Sergey Senozhatsky Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arch@vger.kernel.org, linux-modules@vger.kernel.org, linux-doc@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-pm@vger.kernel.org, Jim Cromie , Louis Chauvet X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1790202874; l=2812; i=jim.cromie@gmail.com; s=20260203; h=from:subject:message-id; bh=zCwr+VGqKnNAOkzayghTBT7W0F9XwKbxJ4/xtvRrwII=; b=MtxKW5tqPWiU+c3h1aFiaFOnaqcptE3iPisUyD4ekvG6WyZ6vBzitYfyBmZ8s+ZdbA9UiPRPj IK6yKEbDE07BHfoCfxQJDvGQ52SxUshC0CGJ1Kcd+c1y+apgADflV6h X-Developer-Key: i=jim.cromie@gmail.com; a=ed25519; pk=C6E5ODlPQo7ZBynATXH9wg7K6HxP0pIXyf4s38Qw0XE= dynamic-debug currently has 2 __sections (__dyndbg, __dyndb_classes), struct _ddebug_info keeps track of them both, with 2 members each: _vec and _vec#_len. We need to loop over these sections, with index and record pointer, making ref to both _vec and _vec_len. This is already fiddly and error-prone, and will get worse as we add a 3rd section. Lets instead embed/abstract the fiddly-ness in the `for_subvec()` macro, and avoid repeating it going forward. This is a for-loop macro expander, so it syntactically expects to precede either a single statement or a { block } of them, and the usual typeof or do-while-0 tricks are unavailable to fix the multiple-expansion warning. Signed-off-by: Jim Cromie Reviewed-by: Louis Chauvet --- v2: move RvB after SoB --- lib/dynamic_debug.c | 19 ++++++++++++++++--- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index 1c0604d7e3cc..84a311fac657 100644 --- a/lib/dynamic_debug.c +++ b/lib/dynamic_debug.c @@ -149,6 +149,20 @@ static void v3pr_info_dq(const struct ddebug_query *query, const char *msg) query->first_lineno, query->last_lineno, query->class_string); } +/* + * simplify a repeated for-loop pattern walking N steps in a T _vec + * member inside a struct _box. It expects int i and T *_sp to be + * declared in the caller. + * @_i: caller provided counter. + * @_sp: cursor into _vec, to examine each item. + * @_box: ptr to a struct containing @_vec member + * @_vec: name of a member in @_box + */ +#define for_subvec(_i, _sp, _box, _vec) \ + for ((_i) = 0, (_sp) = (_box)->_vec; \ + (_i) < (_box)->num_##_vec; \ + (_i)++, (_sp)++) /* { block } */ + static struct ddebug_class_map *ddebug_find_valid_class(struct ddebug_table const *dt, const char *class_string, int *class_id) @@ -156,7 +170,7 @@ static struct ddebug_class_map *ddebug_find_valid_class(struct ddebug_table cons struct ddebug_class_map *map; int i, idx; - for (map = dt->classes, i = 0; i < dt->num_classes; i++, map++) { + for_subvec(i, map, dt, classes) { idx = match_string(map->class_names, map->length, class_string); if (idx >= 0) { *class_id = idx + map->base; @@ -1166,8 +1180,7 @@ static void ddebug_attach_module_classes(struct ddebug_table *dt, struct _ddebug * the builtin/modular classmap vector/section. Save the start * and length of the subrange at its edges. */ - for (cm = di->classes, i = 0; i < di->num_classes; i++, cm++) { - + for_subvec(i, cm, di, classes) { if (!strcmp(cm->mod_name, dt->mod_name)) { if (!nc) { v2pr_info("start subrange, class[%d]: module:%s base:%d len:%d ty:%d\n", -- 2.55.0