From: Tao Gong <gongtao0607@gmail.com>
To: netdev@vger.kernel.org
Cc: "Chester A . Unal" <chester.a.unal@arinc9.com>,
"Daniel Golle" <daniel@makrotopia.org>,
"Andrew Lunn" <andrew@lunn.ch>,
"Vladimir Oltean" <olteanv@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Lorenzo Bianconi" <lorenzo@kernel.org>,
"Arınç ÜNAL" <arinc.unal@arinc9.com>,
"Florian Fainelli" <florian.fainelli@broadcom.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
"Tao Gong" <gongtao0607@gmail.com>
Subject: [PATCH net v2 0/2] net: dsa: mt7530: fix trapped frame forwarding and egress tagging
Date: Wed, 23 Sep 2026 05:51:01 +0000 [thread overview]
Message-ID: <20260923055103.949540-1-gongtao0607@gmail.com> (raw)
This series resolves two issues in the MT7530 DSA switch driver preventing
trapped link-local control frames (such as STP BPDUs) from reaching the CPU
host when bridge VLAN filtering is enabled:
1. Commit 3ac85bcfd404 ("net: dsa: mt7530: preserve VLAN tags on trapped
link-local frames") set MT7530_VLAN_EG_DISABLED to preserve VLAN tags,
but in hardware this disables the per-packet override and causes
trapped frames to follow the CPU port's active VLAN table (VAWD2) rule.
When bridge VLAN filtering is active, the CPU port is in stack mode,
causing incoming untagged BPDUs (01:80:C2:00:00:00) to be egressed with
a VLAN tag, which userspace STP daemons (such as ustpd) and the kernel
bridge drop. MT7530_VLAN_EG_CONSISTENT correctly preserves wire state
(untagged frames stay untagged, tagged frames stay tagged).
2. On Airoha EN7581 and AN7583 switch IP, setting MT7531_CFC (0x04)
CPU_PMAP alone is insufficient; the switch MAC forwarding control
(MT753X_MFC, 0x10) must also have CPU_EN and CPU_PORT configured for
trapped frames to exit to the CPU conduit.
Changes in v2:
- Rebased onto net/main
(git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git) adapting
to mt7530_rmw() instead of net-next's regmap helpers, resolving the
patch application failure on net-0 noted by Jakub Kicinski.
- Carried over Lorenzo Bianconi's Acked-by on patch 2 as the underlying
logic is unchanged.
Tao Gong (2):
net: dsa: mt7530: use consistent egress tag for trapped link-local
frames
net: dsa: mt7530: trap frames to conduit in MFC on EN7581 and AN7583
drivers/net/dsa/mt7530.c | 27 ++++++++++++++-------------
1 file changed, 14 insertions(+), 13 deletions(-)
base-commit: 9c572a83037a7dcd653ba3a9cc468c16b857d0c9
--
2.55.0
next reply other threads:[~2026-09-23 5:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-23 5:51 Tao Gong [this message]
2026-09-23 5:51 ` [PATCH net v2 1/2] net: dsa: mt7530: use consistent egress tag for trapped link-local frames Tao Gong
2026-09-27 6:06 ` netdev-bot+sashiko
2026-09-23 5:51 ` [PATCH net v2 2/2] net: dsa: mt7530: trap frames to conduit in MFC on EN7581 and AN7583 Tao Gong
2026-09-27 6:06 ` netdev-bot+sashiko
2026-09-29 9:08 ` [PATCH net v2 0/2] net: dsa: mt7530: fix trapped frame forwarding and egress tagging Paolo Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260923055103.949540-1-gongtao0607@gmail.com \
--to=gongtao0607@gmail.com \
--cc=andrew@lunn.ch \
--cc=angelogioacchino.delregno@collabora.com \
--cc=arinc.unal@arinc9.com \
--cc=chester.a.unal@arinc9.com \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=florian.fainelli@broadcom.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=lorenzo@kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®