From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sender6-op-o11.zoho.com (sender6-op-o11.zoho.com [165.173.180.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7DE524A6CFC for ; Thu, 24 Sep 2026 18:11:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=165.173.180.11 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790273484; cv=pass; b=op9pzFm6mqS8ypU4ndd0dZb0x4YoSPi/X4IBTVlmwamxAtdjo9DMooOwu8eWVzWc1vBvDUCxcOuWUNRRZ+/Rr7EI6ajwUBdJ71313/COyLYMEeOkRkdZhsTmYAx6jRCF1f/nynfdp9O8j9UKzVeUoKMVySEcqUkA9VTIIQk6l6o= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790273484; c=relaxed/simple; bh=t0pKAbH0SA2araO3s4z8ycC80JiA92CZd/FQ3/v+S5g=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=rDcck4jUve2gtZ38m5aWpi3j4BOicN8C/4cE8NzWW155hed1+RPoreR5ewdSzNiE1AXPuKdORDGx/WVE3/ZtWrmvc09L3bXxTC5IewsT6z8BIfJPmkh5pr8XJ6/hM/s9ukXJ1aOUl/8KJzaZqsf4ZgvDPutK0ra+fprjcORe2eA= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b=Udyzymsm; arc=pass smtp.client-ip=165.173.180.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b="Udyzymsm" ARC-Seal: i=1; a=rsa-sha256; t=1790273448; cv=none; d=zohomail.com; s=zohoarc; b=McnGQpY+6XYneNEGQL29hTgeIITEtTVzgLlyIMu7vLhVJ+h+RBUntQ0cjS3PJycxVan1vL9AkeBe8J+p46bJgg2MF0hFNEIV8SADK/NZj5ZuL35EMupnXjtjxKNX5/8j6hfaOganxueiDExzVXMWX9IeOZYOdU4OnD7LLj/Te4Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1790273448; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=Z6RRS3cshQwsXc3rA/U7BvQ2XdAR4lAqGHrehoKydrQ=; b=Bg4ZWdfE7f9s7MtFh8xrCxvXoy/xKyvgWXnw8E10XMqxMtlicvaUVx4IYKxdxa9/v2TrVtR4kk2ZCF8pM0bMInv9nVig82KFxNhS3f1Jx5u4KKJ/XV+FOUtiPKBhHXj5ERA8Jk5VUrYXmZGO1SEL2f6Mlp+HCs/gujncEMBLTLg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=adrian.larumbe@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1790273448; s=zohomail; d=collabora.com; i=adrian.larumbe@collabora.com; h=From:From:Date:Date:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Message-Id:In-Reply-To:To:To:Cc:Cc:Reply-To; bh=Z6RRS3cshQwsXc3rA/U7BvQ2XdAR4lAqGHrehoKydrQ=; b=Udyzymsm4E2hQ1fHrRdvhdsOX7PMjPZynSGWZfWrvmh6eSaE6aIYYu4frt19CvxA rq4SHixRz4afnubhhGD0KDcn79bEmc5jjI+sQo7v6/hpRvecMVxCx30T1wFETgcaEs6 axkEd0lj+yrIQmYXTWpdZOA0QWpLkPusYl4uYjWg= Received: by smtp.zohomail.com with SMTPS id 1790273446941450.9724938594469; Thu, 24 Sep 2026 11:10:46 -0700 (PDT) From: =?utf-8?q?Adri=C3=A1n_Larumbe?= Date: Thu, 24 Sep 2026 19:09:29 +0100 Subject: [PATCH v10 12/15] drm/panfrost: Skip cache flush/invalidate when enabling perfcnt Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Message-Id: <20260924-claude-fixes-v10-12-755929b3cc19@collabora.com> References: <20260924-claude-fixes-v10-0-755929b3cc19@collabora.com> In-Reply-To: <20260924-claude-fixes-v10-0-755929b3cc19@collabora.com> To: Boris Brezillon , Rob Herring , Steven Price , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Faith Ekstrand , "Marty E. Plummer" , Tomeu Vizoso , Eric Anholt , Alyssa Rosenzweig , Robin Murphy , Philipp Zabel Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Collabora Kernel Team , =?utf-8?q?Adri=C3=A1n_Larumbe?= , Neil Armstrong X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1716; i=adrian.larumbe@collabora.com; h=from:subject:message-id; bh=t0pKAbH0SA2araO3s4z8ycC80JiA92CZd/FQ3/v+S5g=; b=owEB7QES/pANAwAKAQ4mfkzuU0M9AcsmYgBqtWdZjvyW3F2YcXi7lUVv8ElgN/A3cYLT55Izq DNlDkFvimiJAbMEAAEKAB0WIQQyQDDowAUXXfk3B6QOJn5M7lNDPQUCarVnWQAKCRAOJn5M7lND PQSKC/94MNfPevFpReWzuA27iTpvNNV67rCqn+2eSW2KOorPejYEo89L7+ho7jDvZs7iaIqkLfz qcadu7tRYDRVLtWu4n4Vd0VG2B7hjprS8y9Y0J4wLZS9VXXU5EkmDcAFAqqlsTvk8z2RPpokH04 ny1YPnH4rX8MAS66EDELGt1yDVAw5Kje9QcPlSvjhGo/RYwA+SvYte/SVnCIGk2gKl1MIz46TZH +Ntb6wC8NpkAP4lyusyNXaws07MxnpIyfdYxLoru0YUWhbOtCppN4CUdqs4hKZL1HB911rXXG1w QWEWin7eVcuER8iGoyfK+iZ18KKm352C/V8pQQP4K7DeJCjdZtb7974nhWKI1XGVJb4bY1E1Tw+ tl9VIMJC6RbldE0nQ5Vc/YWHlFv0pXx8XeAhlOZKgh4GMkVrGbnB3CKzPYARhhuZobWjmNLNLHm vAh+cPk0ERQm3n7PrYiJGpZg7HcJdQGUnyZsiya8mDAL0Le3sCsdiHexmDRGc/+OpgGAg= X-Developer-Key: i=adrian.larumbe@collabora.com; a=openpgp; fpr=324030E8C005175DF93707A40E267E4CEE53433D The GPU cache flush/invalidate operation is unnecessary. First off, the GPU doesn't read off the perfcnt sample buffer, only writes into it, so an invalidate doesn't make a difference. Then flushing GPU caches after each sample has been written is enough for the CPU to see updated values. Reviewed-by: Boris Brezillon Signed-off-by: Adrián Larumbe --- drivers/gpu/drm/panfrost/panfrost_perfcnt.c | 15 ++------------- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/panfrost/panfrost_perfcnt.c b/drivers/gpu/drm/panfrost/panfrost_perfcnt.c index f71534e741b6..ffc77121070e 100644 --- a/drivers/gpu/drm/panfrost/panfrost_perfcnt.c +++ b/drivers/gpu/drm/panfrost/panfrost_perfcnt.c @@ -124,21 +124,10 @@ static int panfrost_perfcnt_enable_locked(struct panfrost_device *pfdev, panfrost_gem_internal_set_label(&bo->base, "Perfcnt sample buffer"); /* - * Invalidate the cache and clear the counters to start from a fresh - * state. + * Clear the counters to start from a fresh state. */ - reinit_completion(&pfdev->perfcnt->dump_comp); - gpu_write(pfdev, GPU_INT_CLEAR, - GPU_IRQ_CLEAN_CACHES_COMPLETED | - GPU_IRQ_PERFCNT_SAMPLE_COMPLETED); + gpu_write(pfdev, GPU_INT_CLEAR, GPU_IRQ_PERFCNT_SAMPLE_COMPLETED); gpu_write(pfdev, GPU_CMD, GPU_CMD_PERFCNT_CLEAR); - gpu_write(pfdev, GPU_CMD, GPU_CMD_CLEAN_INV_CACHES); - ret = wait_for_completion_timeout(&pfdev->perfcnt->dump_comp, - msecs_to_jiffies(1000)); - if (!ret) { - ret = -ETIMEDOUT; - goto err_vunmap; - } ret = panfrost_mmu_as_get(pfdev, perfcnt->mapping->mmu); if (ret < 0) -- 2.55.0