From: Guangshuo Li <lgs201920130244@gmail.com>
To: ychuang3@nuvoton.com, schung@nuvoton.com,
gregkh@linuxfoundation.org, jirislaby@kernel.org
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
ilpo.jarvinen@linux.intel.com, lgs201920130244@gmail.com
Subject: [PATCH] serial: ma35d1: unmap MMIO on remove
Date: Thu, 24 Sep 2026 19:04:00 +0800 [thread overview]
Message-ID: <20260924110400.1556396-1-lgs201920130244@gmail.com> (raw)
ma35d1serial_probe() maps up->port.membase with ioremap(), but
ma35d1serial_remove() does not perform the matching iounmap(). The probe
error path already releases this mapping after disabling the clock.
Add iounmap() to the remove path after clk_disable_unprepare() to match
the resource cleanup order used by ma35d1serial_probe().
Fixes: 930cbf92db01 ("tty: serial: Add Nuvoton ma35d1 serial driver support")
Signed-off-by: Guangshuo Li <lgs201920130244@gmail.com>
---
drivers/tty/serial/ma35d1_serial.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/tty/serial/ma35d1_serial.c b/drivers/tty/serial/ma35d1_serial.c
index 920fe7ff5083..e5eaaf154911 100644
--- a/drivers/tty/serial/ma35d1_serial.c
+++ b/drivers/tty/serial/ma35d1_serial.c
@@ -770,6 +770,7 @@ static void ma35d1serial_remove(struct platform_device *dev)
uart_remove_one_port(&ma35d1serial_reg, port);
clk_disable_unprepare(up->clk);
+ iounmap(up->port.membase);
}
static int ma35d1serial_suspend(struct platform_device *dev, pm_message_t state)
base-commit: f03c39de3a1307371a4032757cd1732e91087c7d
--
2.43.0
next reply other threads:[~2026-09-24 11:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-24 11:04 Guangshuo Li [this message]
2026-10-01 8:41 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260924110400.1556396-1-lgs201920130244@gmail.com \
--to=lgs201920130244@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=schung@nuvoton.com \
--cc=ychuang3@nuvoton.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®