From: Vincent Donnefort <vdonnefort@google.com>
To: rostedt@goodmis.org, mhiramat@kernel.org,
linux-trace-kernel@vger.kernel.org
Cc: mathieu.desnoyers@efficios.com, kernel-team@android.com,
linux-kernel@vger.kernel.org,
Vincent Donnefort <vdonnefort@google.com>
Subject: [PATCH v7 04/20] tracing/remotes: Initialise pos in trace_start()
Date: Thu, 24 Sep 2026 15:57:38 +0100 [thread overview]
Message-ID: <20260924145754.1285146-5-vdonnefort@google.com> (raw)
In-Reply-To: <20260924145754.1285146-1-vdonnefort@google.com>
When *pos is 0, trace_start() passes a dummy local variable i to
trace_next() to fetch the first entry without modifying *pos. In that
branch, i was left uninitialized.
While i is discarded and causes no functional issues, initialise i and
keep static analysers happy.
Signed-off-by: Vincent Donnefort <vdonnefort@google.com>
---
kernel/trace/trace_remote.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/trace/trace_remote.c b/kernel/trace/trace_remote.c
index ae22d13308a5..aa76845a630a 100644
--- a/kernel/trace/trace_remote.c
+++ b/kernel/trace/trace_remote.c
@@ -748,12 +748,12 @@ static void *trace_start(struct seq_file *m, loff_t *pos)
trace_remote_iter_read_start(iter);
+ i = iter->pos;
if (!*pos) {
iter->pos = -1;
return trace_next(m, NULL, &i);
}
- i = iter->pos;
while (i < *pos) {
iter = trace_next(m, NULL, &i);
if (!iter)
--
2.56.0.rc1.310.g51773c2048-goog
next prev parent reply other threads:[~2026-09-24 14:58 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-24 14:57 [PATCH v7 00/20] tracing/remotes: Add printk, dump_on_panic and boot parameters Vincent Donnefort
2026-09-24 14:57 ` [PATCH v7 01/20] tracing/remotes: Gate tracefs files opening on trace remote registration Vincent Donnefort
2026-09-24 14:57 ` [PATCH v7 02/20] tracing/remotes: Release tracefs,eventfs on registration failure Vincent Donnefort
2026-09-24 14:57 ` [PATCH v7 03/20] tracing/remotes: Use kstrtobool for boolean tracefs files Vincent Donnefort
2026-09-24 14:57 ` Vincent Donnefort [this message]
2026-09-24 14:57 ` [PATCH v7 05/20] tracing/remotes: Annotate remote shared fields with READ_ONCE/WRITE_ONCE Vincent Donnefort
2026-09-24 14:57 ` [PATCH v7 06/20] tracing/remotes: Use a single per-remote polling work Vincent Donnefort
2026-09-24 14:57 ` [PATCH v7 07/20] tracing/simple_ring_buffer: Add support for compressed length Vincent Donnefort
2026-09-24 14:57 ` [PATCH v7 08/20] tracing/remotes: Add dmesg tracefs file Vincent Donnefort
2026-09-24 14:57 ` [PATCH v7 09/20] tracing/remotes: selftests: Add a test for the " Vincent Donnefort
2026-09-24 14:57 ` [PATCH v7 10/20] tracing/remotes: selftests: Prefix hypervisor folder Vincent Donnefort
2026-09-24 14:57 ` [PATCH v7 11/20] ring-buffer: Use irqsave for the reader lock in ring_buffer_poll_remote Vincent Donnefort
2026-09-24 14:57 ` [PATCH v7 12/20] ring-buffer: Use panic-friendly locking in ring_buffer_iter interface Vincent Donnefort
2026-09-24 14:57 ` [PATCH v7 13/20] ring-buffer: Add ring_buffer_read_remote_meta_page() Vincent Donnefort
2026-09-24 14:57 ` [PATCH v7 14/20] ring-buffer: Add kerneldoc for ring_buffer_poll_remote Vincent Donnefort
2026-09-24 14:57 ` [PATCH v7 15/20] tracing/remotes: Add dump_on_panic tracefs file Vincent Donnefort
2026-09-24 14:57 ` [PATCH v7 16/20] tracing/remotes: selftests: Add a test for the " Vincent Donnefort
2026-09-24 14:57 ` [PATCH v7 17/20] tracing/remotes: Add poll_ms " Vincent Donnefort
2026-09-24 14:57 ` [PATCH v7 18/20] tracing/remotes: Add trace_remote cmdline options Vincent Donnefort
2026-09-24 14:57 ` [PATCH v7 19/20] Documentation: tracing/remotes: Add detailed tracefs layout Vincent Donnefort
2026-09-24 14:57 ` [PATCH v7 20/20] Documentation/kernel-parameters: Add trace_remote Vincent Donnefort
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260924145754.1285146-5-vdonnefort@google.com \
--to=vdonnefort@google.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®