From: Mikhail Gavrilov <mikhail.v.gavrilov@gmail.com>
To: Dave Hansen <dave.hansen@intel.com>
Cc: Pedro Falcato <pfalcato@suse.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
Andy Lutomirski <luto@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@kernel.org>, Ingo Molnar <mingo@redhat.com>,
Borislav Petkov <bp@alien8.de>,
x86@kernel.org, "H . Peter Anvin" <hpa@zytor.com>,
Mike Rapoport <rppt@kernel.org>, Lorenzo Stoakes <ljs@kernel.org>,
Toshi Kani <toshi.kani@hpe.com>,
linux-mm@kvack.org, regressions@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] x86/mm: Drop the page allocation from pud_free_pmd_page()
Date: Fri, 25 Sep 2026 01:39:15 +0500 [thread overview]
Message-ID: <20260924203915.189167-1-mikhail.v.gavrilov@gmail.com> (raw)
In-Reply-To: <d8b502f7-a552-4600-b348-614d1d62afa5@intel.com>
On 9/24/26 10:21, Dave Hansen wrote:
> OK, I've got a version of Mikhail's fix with a changelog and comments
> I've munged a bit:
>
>> https://git.kernel.org/pub/scm/linux/kernel/git/daveh/devel.git/log/?h=pmdfree
>
> Does that look OK to everyone?
Looks good to me, thanks. The code is v2 with your comments and the
declarations reordered, so the testing done for v2 still applies.
Two small things, both optional:
- "The new mmap_read_lock() is held over a GFP_KERNEL allocation":
the lock held over the allocation is the same init_mm lock, but
taken in vmap_try_huge_pud(), not the new one in CPA. Maybe "The
huge vmap code holds the same lock over a GFP_KERNEL allocation,
which is a no-no now that reclaim can take it."
- The kernel-doc lost its "Return:" line while the function still
returns int, so kernel-doc -Wreturn will complain about it.
next prev parent reply other threads:[~2026-09-24 20:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-23 22:31 Mikhail Gavrilov
2026-09-23 23:07 ` Dave Hansen
2026-09-24 5:10 ` Mikhail Gavrilov
2026-09-24 16:45 ` Dave Hansen
2026-09-24 16:55 ` Pedro Falcato
2026-09-24 17:21 ` Dave Hansen
2026-09-24 17:54 ` Pedro Falcato
2026-09-24 20:39 ` Mikhail Gavrilov [this message]
2026-09-24 23:51 ` Dave Hansen
2026-09-28 18:05 ` [tip: x86/urgent] x86/mm: Drop unnecessary PMD page copy when freeing tip-bot2 for Mikhail Gavrilov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260924203915.189167-1-mikhail.v.gavrilov@gmail.com \
--to=mikhail.v.gavrilov@gmail.com \
--cc=bp@alien8.de \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=pfalcato@suse.de \
--cc=regressions@lists.linux.dev \
--cc=rppt@kernel.org \
--cc=tglx@kernel.org \
--cc=toshi.kani@hpe.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®