From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj2-f42.google.com (mail-pj2-f42.google.com [74.125.227.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B3CEE3B5314 for ; Sun, 27 Sep 2026 02:55:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790477713; cv=none; b=R4xi5Spj5n57kENfkHyllQUFFwSakfl1S+Irjwg0BuRuBfao3mf6AvsT4neK5GOw0gmlAvbpGmjDYg0LNuTSathX01/zrv+Dy9vsqb+928qiJtFRV1DSsfExkqu/SqaqF0PpHjuq8fOFbjZeE6iumWBkIGMd+uXxeWf64OkrMLg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790477713; c=relaxed/simple; bh=q3HT6xfHRoYAMNVXjK1x5yO75MJw/sRMzAnm8tJtAus=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BQpysyMTVXfq4SlVgrseAjlsFUwOBmP4WNdneWzkZM39tNTYx+RMiC+MC5zLnaTksWZ6SWaIh75j0rH/ABcHqudU/jjrZrOduzF1/fqY5jsS7eh1Zya5oFQJOSuIfdnAtgesjzie0VAFPuHINGiG1n0dDnqM5V8QMP0ev5ZyRcc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=bytedance.com; spf=pass smtp.mailfrom=bytedance.com; dkim=pass (2048-bit key) header.d=bytedance.com header.i=@bytedance.com header.b=LlSh/SJi; arc=none smtp.client-ip=74.125.227.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=bytedance.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bytedance.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bytedance.com header.i=@bytedance.com header.b="LlSh/SJi" Received: by mail-pj2-f42.google.com with SMTP id 98e67ed59e1d1-39d654f02baso850301a91.3 for ; Sat, 26 Sep 2026 19:55:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1790477711; x=1791082511; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=oPILxKtLMatcdEGLhusrMdFPdqn1uhqgdU3ISddJAJk=; b=LlSh/SJiosXrurb9TIRGu0Ea20ZiYnaq72lYh5jCfM+3UX75QEJjBJb8KCQReePxOX mxeVjVEECtAVNHzu1TwCG5HcI1Kt7sNnj0/GpD+1TqZw8JkaOuIKVPkDuyaDYF8MfMp/ vnFyjJyvbF8yE1mzwfW6slN5K/sm0W5i0xWtZV5HAu5cjkSDXuwjwcQidSf5VHIJ8YUd Ya1GURYhSzwDikW25mhtMGvQMY2zoPeFy27TIfT0vZ8E6Povfg2xwJhU2HUQKTDhMZkG fYjJ3OKI2A9ldxGkPPmX/0OW50UxTG6cifxDf2nidg6YHTl+ylvsuB1lufILUyyA+iBp lS5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790477711; x=1791082511; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=oPILxKtLMatcdEGLhusrMdFPdqn1uhqgdU3ISddJAJk=; b=rcV5UdIGXqeYL/K2xKHYBsj+W4qIJjHwWUb5MkvMctPqHSGBv1b/XVELxn1U71hoXY DPqzp/D7Z5i+hlZrFEizQYHk1PBjl9S3yLncK+AK3f4d+ETVrTA+62MwlNTSZmxer1x4 +uyw6v6ESsDdFOjKSUniWpExQAnXs7+FtSK52dNi5CMVIoiuWCMYaskE9ovvvHmJDjzU j8wRI4vTTxatB5a3ptlsV7WCPpBok4InNZMYA2aZIEt7ORsFJiSZtzFfomGRNPnP3flZ Db91wVxEPA9tbqc2wW60Dt27lVrDMP7N+9S9y2YDqh9pDTCMt3RxoczXFAB+do9AhH45 +6Tw== X-Forwarded-Encrypted: i=1; AKwUvBzbZKsISzMb53TmXXqWI2a3Buwi34T0iKkFOEqRyRbO67CVfTUl+w8Pk/NP3gkg7S5iK3dSV85+3+ebZlI=@vger.kernel.org X-Gm-Message-State: AFq9FYIbq6P5+eqNDGwLKcY1Hp3tFvM1nVik41JFF3+NG564/pUWps9r Du1lIE580zoPloyIKhN0PlKYxQm3Xvc+YoH/MzOpn9CHfrqF1JHjmWwaXwHP5rgwzpc= X-Gm-Gg: AYBFou0xvygrzlmKunMzKvBp318/SUqqnnv4MlutdFfaPxX+d3ZZGEx7Xi6Rb7roieK mVG4HLxbRSmy71q+9TciD4nenoeXL6XageHd4B+cGWKnf3mH9SWFgYf9cvCd451WejA9R/xTMld VBcQGthRDvmcXXRzxK1cdrDdQQTgdB5swhAFnqChuri1nkjWf2HaidUa7/msvgFg1HsPGocwXVd 6tUUWXa3PgaoB2+8mqMloQQkNiy1dwSCYSd45Z0Sur4J13nrQb0/Im4guWfNKk7V9hQ9RJMg7Zx vYbJpvuCxsfC7OWOK1HTAeXDraJFQ5XKVuvGK+MCLxs9jtP32MbJz29S0vXA5mlcVoRu+6x4Grf zNIvgtTxDIzEhochKHvekfX2exWkBv06FUZIm3iNIevwvUPM8E+sIVdkr8cw2HuSh4A2iuyEPSu Pletx2+bgIzRcPiwuD56QKQr4RzsaO+a1srZpcRpkB2adG8z/qCZiU4PGuJCZCMVmmVGfqaxHW8 hdKdAtnFe6S5mEgCNbx X-Received: by 2002:a17:90b:1807:b0:3a0:c8be:3227 with SMTP id 98e67ed59e1d1-3a0c8be4232mr4636947a91.13.1790477710866; Sat, 26 Sep 2026 19:55:10 -0700 (PDT) Received: from n232-176-004.byted.org ([36.110.163.102]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3a0b8efb156sm13461377a91.1.2026.09.26.19.55.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 26 Sep 2026 19:55:10 -0700 (PDT) From: Muchun Song To: Andrew Morton , David Hildenbrand , Oscar Salvador , Madhavan Srinivasan , Michael Ellerman , Jonathan Corbet Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-doc@vger.kernel.org, Muchun Song , Lorenzo Stoakes , Mike Rapoport , Qi Zheng , Nicholas Piggin , Christophe Leroy , Randy Dunlap , Muchun Song , Lance Yang Subject: [PATCH v5 04/12] mm/sparse-vmemmap: open-code init_compound_tail() Date: Sun, 27 Sep 2026 10:54:33 +0800 Message-ID: <20260927025441.741633-5-songmuchun@bytedance.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260927025441.741633-1-songmuchun@bytedance.com> References: <20260927025441.741633-1-songmuchun@bytedance.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit init_compound_tail() is only used by vmemmap_shared_tail_page(), where the shared tail page setup intentionally passes NULL as the compound head. Keeping this helper in mm/internal.h exposes that special case to the rest of the MM code and can make the NULL head argument look generally valid. Open-code the initialization at the only call site so the special-case use stays local to sparse vmemmap optimization. No functional change intended. Signed-off-by: Muchun Song Acked-by: Qi Zheng Acked-by: David Hildenbrand (Arm) Acked-by: Mike Rapoport (Microsoft) --- v4: - Collect Acked-by from Mike Rapoport v3: - Collect Acked-by from David Hildenbrand v2: - Collect Acked-by from Qi Zheng --- mm/internal.h | 9 --------- mm/sparse-vmemmap.c | 5 ++++- 2 files changed, 4 insertions(+), 10 deletions(-) diff --git a/mm/internal.h b/mm/internal.h index da14c56fb24e..0dca33db068f 100644 --- a/mm/internal.h +++ b/mm/internal.h @@ -786,15 +786,6 @@ static inline void prep_compound_tail(struct page *tail, VM_WARN_ON_ONCE(tail->private); } -static inline void init_compound_tail(struct page *tail, - const struct page *head, unsigned int order, struct zone *zone) -{ - atomic_set(&tail->_mapcount, -1); - set_page_node(tail, zone_to_nid(zone)); - set_page_zone(tail, zone_idx(zone)); - prep_compound_tail(tail, head, order); -} - #if defined CONFIG_COMPACTION || defined CONFIG_CMA /* diff --git a/mm/sparse-vmemmap.c b/mm/sparse-vmemmap.c index 38c36399f53e..e4dae98ba7f8 100644 --- a/mm/sparse-vmemmap.c +++ b/mm/sparse-vmemmap.c @@ -217,7 +217,10 @@ struct page __ref *vmemmap_shared_tail_page(unsigned int order, struct zone *zon for (int i = 0; i < PAGE_SIZE / sizeof(struct page); i++) { page = (struct page *)addr + i; mm_zero_struct_page(page); - init_compound_tail(page, NULL, order, zone); + atomic_set(&page->_mapcount, -1); + set_page_node(page, zone_to_nid(zone)); + set_page_zone(page, zone_idx(zone)); + prep_compound_tail(page, NULL, order); } page = virt_to_page(addr); -- 2.54.0