mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Linus Walleij <linusw@kernel.org>
To: Li Youhong <dayou5941@163.com>,
	 Daniel Scally <dan.scally@ideasonboard.com>,
	 Jacopo Mondi <jacopo.mondi@ideasonboard.com>,
	 Mauro Carvalho Chehab <mchehab@kernel.org>,
	Rob Herring <robh@kernel.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 Conor Dooley <conor+dt@kernel.org>,
	 Hans Verkuil <hverkuil+cisco@kernel.org>,
	 Nayden Kanchev <nayden.kanchev@arm.com>
Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org,
	 linux-kernel@vger.kernel.org, Linus Walleij <linusw@kernel.org>,
	 stable@vger.kernel.org
Subject: [PATCH 0/3] media: mali-c55: Fix IRQ lifetime and wake handling
Date: Tue, 29 Sep 2026 14:02:23 +0200	[thread overview]
Message-ID: <20260929-mali-c55-irq-supend-resume-v1-0-e3af34afff12@kernel.org> (raw)

This is essentially my reply with the "proper fix" for:
https://lore.kernel.org/linux-media/20260903025526.2657105-1-dayou5941@163.com/

Keep the Mali-C55 interrupt requested for the driver's lifetime instead
of changing interrupt ownership along with the runtime power state.
Synchronize and disable the IRQ before power-off, and enable it after
power-on. Hold a PM reference until probe installs the IRQ, and stop
runtime PM and drain the IRQ before removing the media entities.

Allow platforms to mark the ISP as a wakeup source. Hold a runtime PM
reference while IRQ wake is armed, resuming an idle ISP if needed and
preserving an active ISP's configuration. Balance the reference on resume
and failure. Hibernation still uses the power-down path.

Wake events require a configured stream and an input that remains active
during system sleep. The internal TPG shares the ISP's power state;
external sensors and receivers need their own wake support. An idle
pipeline is not started by this series. Hardware wake remains untested.

The first patch extends the binding with the standard wakeup-source
property. The second patch updates the driver IRQ and PM handling. The
third patch retains ISP power while IRQ wake is armed.

Tested on the Renesas RZ/V2H board with the other in-flight patches
(DTS changes and the TPG enablement) doing full suspend/resume cycles
with wakeup from RTC and NMI and capturing images before and
after the test.

Assisted-by: LLM
Signed-off-by: Linus Walleij <linusw@kernel.org>
---
Linus Walleij (3):
      dt-bindings: media: mali-c55: Allow wakeup source
      media: mali-c55: Keep IRQ requested during suspend
      media: mali-c55: Keep ISP powered while IRQ wake is armed

 .../devicetree/bindings/media/arm,mali-c55.yaml    |  2 +
 .../media/platform/arm/mali-c55/mali-c55-core.c    | 96 +++++++++++++++++-----
 2 files changed, 78 insertions(+), 20 deletions(-)
---
base-commit: cee9395acd8043be0644b25c34bfa86623f2b935
change-id: 20260918-mali-c55-irq-supend-resume-30b507a20011

Best regards,
--  
Linus Walleij <linusw@kernel.org>


             reply	other threads:[~2026-09-29 12:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-29 12:02 Linus Walleij [this message]
2026-09-29 12:02 ` [PATCH 1/3] dt-bindings: media: mali-c55: Allow wakeup source Linus Walleij
2026-09-29 12:02 ` [PATCH 2/3] media: mali-c55: Keep IRQ requested during suspend Linus Walleij
2026-09-29 12:02 ` [PATCH 3/3] media: mali-c55: Keep ISP powered while IRQ wake is armed Linus Walleij
2026-10-06 11:43 ` [PATCH 0/3] media: mali-c55: Fix IRQ lifetime and wake handling Lad, Prabhakar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260929-mali-c55-irq-supend-resume-v1-0-e3af34afff12@kernel.org \
    --to=linusw@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=dan.scally@ideasonboard.com \
    --cc=dayou5941@163.com \
    --cc=devicetree@vger.kernel.org \
    --cc=hverkuil+cisco@kernel.org \
    --cc=jacopo.mondi@ideasonboard.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=nayden.kanchev@arm.com \
    --cc=robh@kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®