From: Fabricio Akio via B4 Relay <devnull+fabricioakio.gmail.com@kernel.org>
To: Casey Connolly <casey.connolly@linaro.org>,
Sebastian Reichel <sre@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Abel Vesa <abelvesa@kernel.org>
Cc: Robin Snyders <robin@snyders.xyz>,
David Heidelberg <david@ixit.cz>,
phone-devel@vger.kernel.org,
Richard Acayan <mailingradian@gmail.com>,
linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Sebastian Reichel <sebastian.reichel@collabora.com>,
Fabricio Akio <fabricioakio@gmail.com>
Subject: [PATCH 2/4] power: supply: qcom_smbx: report charger state changes
Date: Sat, 03 Oct 2026 16:45:22 -0300 [thread overview]
Message-ID: <20261003-qcom-smbx-chg-state-change-v1-2-fffaef446932@gmail.com> (raw)
In-Reply-To: <20261003-qcom-smbx-chg-state-change-v1-0-fffaef446932@gmail.com>
From: Fabricio Akio <fabricioakio@gmail.com>
Nothing notifies consumers when the charging state changes on its own,
as when a charge completes, so they can keep a stale status.
Request the chg-state-change interrupt when the device tree provides
it, and notify consumers when it fires.
Fixes: 8648aeb5d7b7 ("power: supply: add Qualcomm PMI8998 SMB2 Charger driver")
Signed-off-by: Fabricio Akio <fabricioakio@gmail.com>
---
drivers/power/supply/qcom_smbx.c | 24 ++++++++++++++++++++++++
1 file changed, 24 insertions(+)
diff --git a/drivers/power/supply/qcom_smbx.c b/drivers/power/supply/qcom_smbx.c
index f5557b8cc92a..3738eb8638bc 100644
--- a/drivers/power/supply/qcom_smbx.c
+++ b/drivers/power/supply/qcom_smbx.c
@@ -762,6 +762,15 @@ static irqreturn_t smb_handle_usb_icl_change(int irq, void *data)
return IRQ_HANDLED;
}
+static irqreturn_t smb_handle_chg_state_change(int irq, void *data)
+{
+ struct smb_chip *chip = data;
+
+ power_supply_changed(chip->chg_psy);
+
+ return IRQ_HANDLED;
+}
+
static irqreturn_t smb_handle_wdog_bark(int irq, void *data)
{
struct smb_chip *chip = data;
@@ -1078,6 +1087,21 @@ static int smb_probe(struct platform_device *pdev)
if (rc < 0)
return rc;
+ /* Optional: not every device tree lists it */
+ irq = platform_get_irq_byname_optional(pdev, "chg-state-change");
+ if (irq > 0) {
+ rc = devm_request_threaded_irq(chip->dev, irq, NULL,
+ smb_handle_chg_state_change,
+ IRQF_ONESHOT, "chg-state-change",
+ chip);
+ if (rc < 0)
+ return dev_err_probe(chip->dev, rc,
+ "Couldn't request irq chg-state-change\n");
+ } else if (irq != -ENXIO) {
+ return dev_err_probe(chip->dev, irq,
+ "Couldn't get irq chg-state-change\n");
+ }
+
devm_device_init_wakeup(chip->dev);
rc = devm_pm_set_wake_irq(chip->dev, chip->cable_irq);
--
2.55.0
next prev parent reply other threads:[~2026-10-03 19:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-03 19:45 [PATCH 0/4] " Fabricio Akio via B4 Relay
2026-10-03 19:45 ` [PATCH 1/4] dt-bindings: power: supply: qcom,pmi8998-charger: add chg-state-change Fabricio Akio via B4 Relay
2026-10-04 8:06 ` Krzysztof Kozlowski
2026-10-04 11:58 ` Fabricio Akio
2026-10-03 19:45 ` Fabricio Akio via B4 Relay [this message]
2026-10-03 19:45 ` [PATCH 3/4] arm64: dts: qcom: pm660: Add the charger state change interrupt Fabricio Akio via B4 Relay
2026-10-03 19:45 ` [PATCH 4/4] arm64: dts: qcom: pmi8998: " Fabricio Akio via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261003-qcom-smbx-chg-state-change-v1-2-fffaef446932@gmail.com \
--to=devnull+fabricioakio.gmail.com@kernel.org \
--cc=abelvesa@kernel.org \
--cc=andersson@kernel.org \
--cc=casey.connolly@linaro.org \
--cc=conor+dt@kernel.org \
--cc=david@ixit.cz \
--cc=devicetree@vger.kernel.org \
--cc=fabricioakio@gmail.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mailingradian@gmail.com \
--cc=phone-devel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=robin@snyders.xyz \
--cc=sebastian.reichel@collabora.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®