mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Yazen Ghannam <yazen.ghannam@amd.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Vishal Badole <Vishal.Badole@amd.com>,
	tony.luck@intel.com, linux-edac@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] EDAC/amd64: Set zn_regs_v2 for all Family 1Ah models
Date: Mon, 5 Oct 2026 11:07:51 -0400	[thread overview]
Message-ID: <20261005150751.GA1159@yaz-khff2.amd.com> (raw)
In-Reply-To: <20261004175048.GBasKR-AA6kPKnbgEa@fat_crate.local>

On Sun, Oct 04, 2026 at 10:50:48AM -0700, Borislav Petkov wrote:
> On Sun, Oct 04, 2026 at 01:05:25PM -0400, Yazen Ghannam wrote:
> > I'd rather we load unconditionally for all models with the same base
> > behavior using sane defaults. Then we can have model-specific patches
> > for variations, if needed.
> 
> I'd rather not because I keep getting all those: amd64_edac doesn't load on my
> machine reports. Well, after a while it turns out that it should not load
> there in the first place.
> 
> And then there's the managerial checkbox patch which needs to add support for
> their new model just because... does it even make sense to add support? Oh, we
> didn't even think of that but it says "Unsupported" so we thought we should
> "fix" the error message... 
> 
> So I don't want to have that unnecessary waste of everything. And if a f/m/s
> would keep my sanity, then I'm perfectly fine with it.
> 
> > Essentially, we could avoid a whole class of patches for derivative
> > (client, embedded, etc.) products. The module would load with the sane
> > defaults. If the test folks find an issue, then we can have a
> > model-specific patch.
> 
> Only on well-tested and supported configurations. Everything else doesn't
> work.
> 

Okay, fair enough.

Vishal, you should be able to combine the current version with the
suggestion from Boris.

1) Move the zn v2 flag to the top of the 1Ah case.
2) Add 'failure' for the default case.
3) Leave the 40h model group and add the new group with it. Basically,
there will be two model ranges sharing the 'empty' case.
4) Update the commit message with the new details. Make sure to describe
'why' rather than 'what'.

Thanks,
Yazen

  reply	other threads:[~2026-10-05 15:08 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-02 11:32 [PATCH v3 0/2] EDAC/amd64: Fix UMC csrow decode and consolidate Family 1Ah setup Vishal Badole
2026-10-02 11:32 ` [PATCH v3 1/2] EDAC/amd64: Mask UMC chip select to the four implemented selects Vishal Badole
2026-10-05 18:19   ` Borislav Petkov
2026-10-02 11:32 ` [PATCH v3 2/2] EDAC/amd64: Set zn_regs_v2 for all Family 1Ah models Vishal Badole
2026-10-03  1:22   ` Borislav Petkov
2026-10-04 15:14     ` Yazen Ghannam
2026-10-04 16:04       ` Borislav Petkov
2026-10-04 17:05         ` Yazen Ghannam
2026-10-04 17:50           ` Borislav Petkov
2026-10-05 15:07             ` Yazen Ghannam [this message]
2026-10-06  5:39               ` Badole, Vishal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261005150751.GA1159@yaz-khff2.amd.com \
    --to=yazen.ghannam@amd.com \
    --cc=Vishal.Badole@amd.com \
    --cc=bp@alien8.de \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®