From: Rob Herring <robh@kernel.org>
To: Coia Prant <coiaprant@gmail.com>
Cc: Vinod Koul <vkoul@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Manivannan Sadhasivam <mani@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v11 0/2] phy: rockchip: naneng-combphy: add SGMII MAC selection for RK3568
Date: Mon, 5 Oct 2026 22:27:10 -0500 [thread overview]
Message-ID: <20261006032710.GA3539706-robh@kernel.org> (raw)
In-Reply-To: <20261005225944.1171574-1-coiaprant@gmail.com>
On Tue, Oct 06, 2026 at 06:59:42AM +0800, Coia Prant wrote:
> Changes since v10:
>
> - Drop the top-level "default: 1" for "rockchip,sgmii-mac-sel".
> dtschema injects top-level defaults into every matching node, and the
> injected value conflicts with the "else" branch that forbids the
> property on non-RK3568 variants, breaking dtbs_check on those
> platforms. The driver already treats an absent property as 1 (GMAC1),
> so behavior is unchanged.
What? That's not right. 'default' has no effect on the validation.
Please add it back. If the property doesn't apply to some variant, then
default doesn't matter.
Rob
next prev parent reply other threads:[~2026-10-06 3:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-05 22:59 Coia Prant
2026-10-05 22:59 ` [PATCH v11 1/2] dt-bindings: phy: rockchip: naneng-combphy: add rockchip,sgmii-mac-sel property Coia Prant
2026-10-05 22:59 ` [PATCH v11 2/2] phy: rockchip: naneng-combphy: add SGMII MAC selection for RK3568 Coia Prant
2026-10-06 3:27 ` Rob Herring [this message]
2026-10-06 7:48 ` [PATCH v11 0/2] " Coia Prant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261006032710.GA3539706-robh@kernel.org \
--to=robh@kernel.org \
--cc=coiaprant@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mani@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®