mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: James Hilliard <james.hilliard1@gmail.com>
Cc: netdev-bot+sinfo@kernel.org, netdev@vger.kernel.org,
	Paolo Abeni <pabeni@redhat.com>,
	Maxime Chevallier <maxime.chevallier@bootlin.com>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	Eric Dumazet <edumazet@kernel.org>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Alexandre Torgue <alexandre.torgue@foss.st.com>,
	Serge Semin <fancer.lancer@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Nicolai Buchwitz <nb@tipi-net.de>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v2] net: stmmac: unwind the WoL IRQ after a safety IRQ request failure
Date: Tue, 6 Oct 2026 18:10:09 -0700	[thread overview]
Message-ID: <20261006181009.5c4fe5b5@kernel.org> (raw)
In-Reply-To: <CADvTj4obBNgR4w3BW4-gCU-=LUxesQdTRN=EdWTcx7VznFi4kA@mail.gmail.com>

On Tue, 6 Oct 2026 17:17:20 -0600 James Hilliard wrote:
> > Please make sure you read this paragraph, to the end.  
> 
> How much detail should I be including? I had previously been told to try
> and keep commit message more terse[0] and this info didn't seem particularly
> useful.

Not sure how to answer this. Just think for a second -
if the information was not particularly useful, would we be asking 
for it over and over?

> Should I put this info below the --- separator so it doesn't end up in the
> final commit or something like that?

In the commit message, please, it will also be very useful
to people backporting from upstream to various downstream kernels.

  parent reply	other threads:[~2026-10-07  1:10 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-06  7:06 James Hilliard
2026-10-06  7:09 ` netdev-bot+sinfo
2026-10-06  7:14   ` James Hilliard
2026-10-06 22:52     ` Jakub Kicinski
2026-10-06 23:17       ` James Hilliard
2026-10-07  0:57         ` Andrew Lunn
2026-10-07  1:27           ` James Hilliard
2026-10-07  1:10         ` Jakub Kicinski [this message]
2026-10-06  7:50 ` Maxime Chevallier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261006181009.5c4fe5b5@kernel.org \
    --to=kuba@kernel.org \
    --cc=alexandre.torgue@foss.st.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=fancer.lancer@gmail.com \
    --cc=james.hilliard1@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maxime.chevallier@bootlin.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=nb@tipi-net.de \
    --cc=netdev-bot+sinfo@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®