From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A73363793BA for ; Tue, 6 Oct 2026 21:03:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791320611; cv=none; b=oEFPzp8/DhWPdbnVMOA07rU6/ZKGCL4JexJle9rnqAtqGJaaz8prowk5W6M/gIYK5A8HVVuh95lUzN37cz+ClsETCj7APYt/bkNScKILg5bDKcm625t/DEtP+jyy87tS7Z2q8ntbxktS9uZW6DmbL8KZ3ULYnJ0IDx70LqDltcU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791320611; c=relaxed/simple; bh=ISf7Lb0t6b8ylOEcWRDSL9BmaWLi8p6rYhKIlR06ZHE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=eopD4WvLdalX/5CfcWlLJK5LsqiDx400aLh4Evbut8cAjJOOgBDtcWVTDfBmFUCbrOlgbhfKOO9hedU+qjuwgc4AZ9F/zkNWr3AjRWkZafgmfuyor4QFkeA3RBCXrw3uMWziJ45IArw7mIm+rIHiwMYkeb5Nha/dNrozBqK0CW8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IKqmtzUQ; arc=none smtp.client-ip=209.85.218.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IKqmtzUQ" Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-c2dc8cb0decso350631466b.2 for ; Tue, 06 Oct 2026 14:03:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791320608; x=1791925408; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=ylT2JTUORypj+MjhE+jQDW+T/v8WU4XCGcgTDo3Q5yQ=; b=IKqmtzUQB7WmQxcEW/YAAzrXsgpHIm0PThTUoXrUS8PGBGb9mXomqqCXqAo9bgAMRj U2UUJMWDikgRQ8v3Dl2b1/A+qze7pPFRPgZHFyxatnY9iscLK987ristcBlzDLYBAeHD l2ZVQRmmLCYufP06ERngwu0R5hcqhkPCYJk8Xl9TFRQEX9db4+4Iv9S16Tk2iU/V3z/A CXl2oDDOocTogggMbdlQDluXxWDna7v3bxt4yN9OpAi86yI6ainUCl2dD0+gZrqxeD06 pBup341hPMmhMFRyZY8dBSDSv2ilOf58qoZPREVvS++jq44XIDTWbWTlbf2eESkKkx8/ LYvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791320608; x=1791925408; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ylT2JTUORypj+MjhE+jQDW+T/v8WU4XCGcgTDo3Q5yQ=; b=JV/hPVr5Ge4aeeB5kTXe4Ogge7PtMEdaECq5wIpxMzTPDJ8WLQtabaAlagYWlJ8Sk/ WrQEMUlK8Q2TQ53JaojGEy7P5H9x4f15P9uhv5EZ4whpMtzOqE4zOmRDUW5TBmSm5ohU TZ1502CHnE9xhOhHIo0ndUUMJ+hpvyY3vyyZZAUb5uGTlV7bNPCqIaaqiuWvMINiePrB dAYSquhjT8JNc9Un2rF9meUBfPiUnVEHWj9WVqQ/1tukmnGPjeaf2HTkh7iik0PgmvXI Z79TajUvuavCGbc/obWidN3nG2xZhwMw5oVpMptKlyim5vd8KP1hXbW+QpvEOAaTcjNK Ea+g== X-Forwarded-Encrypted: i=1; AKwUvBwuwvsaiaVPsM6/m6bgcIEaAOmlJHO6RpWh6Aph+vLsUu7IGrNOrr9pW3FXhAEM8ic750ixBoEjjFKx7ZQ=@vger.kernel.org X-Gm-Message-State: AFuF++l/n2snLsZpYNjLw8D/NPBy1jeN5QMESbn4tVxG//8IGclXzRZx NFzTJ3Bfe5/XYHypSnnTONT4SMvrOah7y7hEyM0/hoc/zptSpkERF+DrV1p0W7Lhr4/VZw== X-Gm-Gg: AYBFou3k9XGzb9IUY3jfxEnMrWwBBxbxjQsb1ukNh+Xamups2KWyq8FVFPGp9br7gD1 yMVMNBAPaP+k7/0gJUHLqrWpsGKYEnn+VAxoTc128PZBZnJO3T5w/6FLp5VQGN8zWrySyvIqD5v lsaWOh4Dz5brhbCUeO9HE09Wk7pnZDGlnQvpvsalx6qbtoQbT5siavVf26k7Qsc1eIQTZlOa3AH 5cdbLnScMIV267NyriGg+YseKEnUGvneUdxraIQZPK6ddLdUK0ouNMXtJ7szlksLMGsZbgA43k5 6s0AunBd1hohVvfTRJsLbkCiBXila1c7R/TDvmK/kNIWIWSGYe3NXxHW+dqJbXFRF5s8H/zCOIJ lqOwTc1QUzX/Heb1fEtCZ2rmPmdWPoYHG0xJEgYNaBkTUEEaOPvDd4A/Hmthe4tbqQwkFbhfknR yd31zR4ex34wg2wHQXYwCdR7cvi5xG+n1lLfVEEQBpgKO8KoQTal7AX0hX3mgzUMOxT5tqRlBfQ m0DouE9JuFE87WYQDyclnAoeEYSjd4N X-Received: by 2002:a17:907:8992:b0:c29:5021:f6f8 with SMTP id a640c23a62f3a-c317c0bc3a7mr23014166b.36.1791320607819; Tue, 06 Oct 2026 14:03:27 -0700 (PDT) Received: from debian (ip-78-137-176-146.broadband.digiweb.ie. [78.137.176.146]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c317c2f9938sm8483166b.50.2026.10.06.14.03.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Oct 2026 14:03:26 -0700 (PDT) From: Pablo Mazzini To: Linus Walleij Cc: Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Andre Przywara , linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Pablo Mazzini Subject: [PATCH] pinctrl: sunxi: dt: do not accumulate npins across probe attempts Date: Tue, 6 Oct 2026 22:03:13 +0100 Message-ID: <20261006210313.43163-1-pmazzini@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit init_pins_table() adds to npins in the driver's static descriptor, so after a probe deferral the count doubles and the next probe fails with "pin 0 already registered". Count into a local instead. Signed-off-by: Pablo Mazzini --- drivers/pinctrl/sunxi/pinctrl-sunxi-dt.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/pinctrl/sunxi/pinctrl-sunxi-dt.c b/drivers/pinctrl/sunxi/pinctrl-sunxi-dt.c index 50a16f3bd131..1c1888394cf1 100644 --- a/drivers/pinctrl/sunxi/pinctrl-sunxi-dt.c +++ b/drivers/pinctrl/sunxi/pinctrl-sunxi-dt.c @@ -75,7 +75,7 @@ static struct sunxi_desc_pin *init_pins_table(struct device *dev, struct sunxi_pinctrl_desc *desc) { struct sunxi_desc_pin *pins, *cur_pin; - int name_size = 0; + int name_size = 0, npins = 0; int port_base = desc->pin_base / PINS_PER_BANK; char *pin_names, *cur_name; int i, j; @@ -85,7 +85,7 @@ static struct sunxi_desc_pin *init_pins_table(struct device *dev, * Also work out how much memory we need to store all the pin names. */ for (i = 0; i < SUNXI_PINCTRL_MAX_BANKS; i++) { - desc->npins += pins_per_bank[i]; + npins += pins_per_bank[i]; if (pins_per_bank[i] < 10) { /* 4 bytes for "PXy\0" */ name_size += pins_per_bank[i] * 4; @@ -98,12 +98,14 @@ static struct sunxi_desc_pin *init_pins_table(struct device *dev, } } - if (desc->npins == 0) { + if (npins == 0) { dev_err(dev, "no ports defined\n"); return ERR_PTR(-EINVAL); } - pins = devm_kcalloc(dev, desc->npins, sizeof(*pins), GFP_KERNEL); + desc->npins = npins; + + pins = devm_kcalloc(dev, npins, sizeof(*pins), GFP_KERNEL); if (!pins) return ERR_PTR(-ENOMEM); -- 2.52.0