Re: [PATCH 1/2] dt-bindings: clock: mediatek: mt7629: add RTC clock IDs

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1109 bytes --]

On Tue, Oct 06, 2026 at 02:42:23PM +0800, Chuanhong Guo wrote:
> Expose the 40 MHz / 1221 RTC source and the RTC clock mux. Keep the
> existing CLK_TOP_RTC ID for the 40 MHz / 1024 source.
> 
> Signed-off-by: Chuanhong Guo <gch981213@gmail.com>
> ---
>  include/dt-bindings/clock/mt7629-clk.h | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/include/dt-bindings/clock/mt7629-clk.h b/include/dt-bindings/clock/mt7629-clk.h
> index ad8e6d7f0154..aa94a398ae05 100644
> --- a/include/dt-bindings/clock/mt7629-clk.h
> +++ b/include/dt-bindings/clock/mt7629-clk.h
> @@ -115,7 +115,9 @@
>  #define CLK_TOP_CRYPTO_SEL		105
>  #define CLK_TOP_SGMII_REF_1_SEL		106
>  #define CLK_TOP_10M_SEL			107
> -#define CLK_TOP_NR_CLK			108
> +#define CLK_TOP_RTC_32K			108
> +#define CLK_TOP_RTC_SEL			109
> +#define CLK_TOP_NR_CLK			110

Since you can change NR_CLK, its not a binding.
Please remove it, and put it in a driver or w/e uses it.

pw-bot: changes-requested

Thanks,
Conor.

>  
>  /* INFRACFG */
>  #define CLK_INFRA_MUX1_SEL		0
> 
> -- 
> 2.55.0
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]