From: Nathan Chancellor <nathan@kernel.org>
To: Rosen Penev <rosenp@gmail.com>
Cc: Kjetil Oftedal <oftedal@gmail.com>,
sparclinux@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Andreas Larsson <andreas@gaisler.com>,
Nick Desaulniers <ndesaulniers@google.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>,
open list <linux-kernel@vger.kernel.org>,
"open list:CLANG/LLVM BUILD SUPPORT:Keyword:b(?i:clang|llvm)b"
<llvm@lists.linux.dev>
Subject: Re: [PATCH] sparc64: Define p4d_page() instead of stubbing it to NULL
Date: Wed, 7 Oct 2026 11:41:41 +0200 [thread overview]
Message-ID: <20261007094141.GA1527675@ax162> (raw)
In-Reply-To: <CAKxU2N-ZE7dwiGzVgxDYFvm2R0BE0nah2WehGcjpym=Kq68dYw@mail.gmail.com>
On Tue, Oct 06, 2026 at 05:00:30PM -0700, Rosen Penev wrote:
> LLM suggests as an alternative:
>
> /* sparc64 has no p4d leaf mappings, so this is never called */
> static inline struct page *p4d_page(p4d_t p4d)
> {
> return NULL;
> }
>
> Not sure how to proceed.
That seems like a more reasonable fix to me, as it is still obvious this
is not supported while hiding the NULL value from clang's frontend that
emits the warning. It could be worth a comment that it is an inline
function and not a macro to avoid the warning but I guess that is up to
the sparc maintainers.
--
Cheers,
Nathan
next prev parent reply other threads:[~2026-10-07 9:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-05 20:39 Rosen Penev
2026-10-06 7:59 ` Kjetil Oftedal
2026-10-06 8:31 ` Nathan Chancellor
2026-10-07 0:00 ` Rosen Penev
2026-10-07 9:41 ` Nathan Chancellor [this message]
2026-10-07 11:08 ` Andreas Larsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261007094141.GA1527675@ax162 \
--to=nathan@kernel.org \
--cc=andreas@gaisler.com \
--cc=davem@davemloft.net \
--cc=justinstitt@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=morbo@google.com \
--cc=ndesaulniers@google.com \
--cc=oftedal@gmail.com \
--cc=rosenp@gmail.com \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®