From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 125643BF665 for ; Wed, 20 May 2026 22:20:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779315628; cv=none; b=Vo+OWPb9VZ4lMSDWSIdY9W8QccFnDgSOXP5mnu1ST5V6LsPyo2UCV7vXIjqxgx5mDR0B+ukEYtI8GJcA/j37p2P/ZohrmLBUFrh5yvOXnY6L6x6AqzY93X7+NomEVQ6lkhzavkMJxYHeUO0QMLvQKlokcfc/1VDeDgpOCJe70sg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779315628; c=relaxed/simple; bh=BFG0o0OJVbxM+Mfp5F1a0Qegi36i+qWUB4aV2HzNESs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=cbFkBgtu4tDJINc4+F9xn1wfUSpw4ZggpBUQwrHb7haplNZ4qkhCNnQ9sKYRFfJ5oe/Y5svSLInEhzCIBtgFhJNl5sOjkBubdtM3FVgrSzFwe0pHvM0mJ38FnDZIewSjjtbu5IVVnhB9Cks8GRzLBDL2PQn5mVkKTMd2R7u+zjQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=iNV7drXH; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=UPZU/PzN; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="iNV7drXH"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="UPZU/PzN" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1779315626; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eAu/RRdfYrA/U3um2PuIXBOQM7QYu96dWR4U/hhBwhM=; b=iNV7drXHLnEhmTBIW1QD730Ep3o9ZKkk7Gb8DQ/fbH/XB6soBuxegJuQOjgtoq34sJ7uum FwcrpkNbpGS7C9fN65bpp7PMLH7BWuCpY/MF6JSyz5GMRe6YYgDQhG98JX9xbMON1rm/d9 dDJlqQJMHFsOlrWXVu1lnRCBMqrdbHk= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-653-NvgLiyqTPtmyGqCA5dLmqw-1; Wed, 20 May 2026 18:20:24 -0400 X-MC-Unique: NvgLiyqTPtmyGqCA5dLmqw-1 X-Mimecast-MFC-AGG-ID: NvgLiyqTPtmyGqCA5dLmqw_1779315624 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-490261c79fcso11308675e9.0 for ; Wed, 20 May 2026 15:20:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1779315624; x=1779920424; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=eAu/RRdfYrA/U3um2PuIXBOQM7QYu96dWR4U/hhBwhM=; b=UPZU/PzNN+qvF+NvKH/SP0i2AfC05V2OquMPyv0MbGD+cLf4ixQBgtYSwAUwFkmzNe 8Dd6/q1O1ZhJNOSKY5RQqkzKTHZOscCqltSSBeWmNJK0UiZ3jZ8rUZnNpUL1u8dtQyD7 hWwmvQZg9t25iBb3jDbI2k7eXV0Obb0vqrqT8/sowlibxETuR9ptCMWUzZ5jdm4WzjAT bdtB3kFAVXpKXkL3HopCLFhPucooNYaJgyomyICy5YpQJMejUWZStD4La9d+x7NitJ/F tgCpMMGLsOllw+yabeR5slP4OvG+D5wJcmFYXt1QdG0bvQG4scXBtjRx7Dvt9xVT3yTQ ohyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779315624; x=1779920424; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eAu/RRdfYrA/U3um2PuIXBOQM7QYu96dWR4U/hhBwhM=; b=UhAWa5S5wIc7Wdcy/fqNXwjnR86NMVyLB903kBNyyg6YRqHTDTF+KJhKjQzjmwfKEB E8N3C3eDO4BpScU4aD5NcohHec6orrx6WcKFv3u3MrpugUUn6u0YNUiQ/tOhE+eazsIl uy0M2/RvVGQ06kMt1oT65tD0T1bkgmklmKkG3/XYbnWlT0wwI6ijzPDUeQcktq+Z1t74 UmZIUMBRY9E7FmbGFvDNOdiFuIOT7GUuKTGliUJq0RBwhhDZyy89Vyr0OSfbAcMlz1v9 gdIrxPHzpU6d5OTwtU4SCarr37nxgI444jLc2DjCRQsQPXTfbKkdCU/I5rN1XzYy+pkp zbiw== X-Gm-Message-State: AOJu0YzaZ46q90jSc2v8Wh/HYOgsei4yS4ovKWMR0QavRc9Q720SGQ4d PdSHclmKzISSZs39k8i6z/SczwKYuBnW6+JroMQxdtIR65zXA/FRu7yA1NOBcd+E+yTM+bYssf7 OPXA6V/O3w4VQnTyrfakYuWfnEjtu03J6qDdgXXHtOyPDHpMFk9HskF8WnqcdluEcrlRzou6t45 a71hzT9N1HINXB9o7EoUyRHaOpDDukPcDdZjRKNRSKDsM= X-Gm-Gg: Acq92OFAzwLWp1z7cTAPZJkuAF1OtXLBDU21jRRYADYzi2QrkHpQtB2S49aVsb6INMW 3oYm5BGkgn2SwbdiLKvuAUmRzkfvDGvjS1AR4kcEfDYt/RQ/ixfJ+7HaHjvD+AlxBY/0mSi0vrz Ys/q7B6y4+IG9LCRZ9gkUSvz6GwBVA9eTD9ybUN9U9UzHarsIQIlpkhglHobWcc+2S5qIel0Aw9 qqCjp8zzGvFDfaSI5edpmcQsFarNpkN5zdB0eNXxbdTE81JgNinXpBqIlGR/dgUEKoLe+b5w75x ocJZZwuQPxrFuHrQc58hjMNuOKg9Y2zjG0ToELj01K7Z7uL7ycpF2BMLykN+vbKH5c01MCYe4g7 /PgwCzqlT1GgL4NTp/cXqK5cYbWtI01alajtdthz20Lj5kXSz9inoGw== X-Received: by 2002:a05:600c:3b1f:b0:490:f7c:b19 with SMTP id 5b1f17b1804b1-49035fcbd6bmr2495615e9.0.1779315623668; Wed, 20 May 2026 15:20:23 -0700 (PDT) X-Received: by 2002:a05:600c:3b1f:b0:490:f7c:b19 with SMTP id 5b1f17b1804b1-49035fcbd6bmr2494745e9.0.1779315622997; Wed, 20 May 2026 15:20:22 -0700 (PDT) Received: from redhat.com (IGLD-80-230-25-45.inter.net.il. [80.230.25.45]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49033d9edcbsm24375095e9.13.2026.05.20.15.20.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 May 2026 15:20:22 -0700 (PDT) Date: Wed, 20 May 2026 18:20:18 -0400 From: "Michael S. Tsirkin" To: linux-kernel@vger.kernel.org Cc: "David Hildenbrand (Arm)" , Jason Wang , Xuan Zhuo , Eugenio =?utf-8?B?UMOpcmV6?= , Muchun Song , Oscar Salvador , Andrew Morton , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Johannes Weiner , Zi Yan , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Hugh Dickins , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Christoph Lameter , David Rientjes , Roman Gushchin , Harry Yoo , Axel Rasmussen , Yuanchu Xie , Wei Xu , Chris Li , Kairui Song , Kemeng Shi , Nhat Pham , Baoquan He , virtualization@lists.linux.dev, linux-mm@kvack.org, Andrea Arcangeli , Miaohe Lin , Naoya Horiguchi Subject: [PATCH v8 02/37] mm: memory-failure: serialize TestSetPageHWPoison with zone->lock Message-ID: <2140873c1955d1ddde7b20dc86313215dbbc4645.1779315441.git.mst@redhat.com> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailer: git-send-email 2.27.0.106.g8ac3dc51b1 X-Mutt-Fcc: =sent TestSetPageHWPoison() is called without zone->lock, so its atomic update to page->flags can race with non-atomic flag operations that run under zone->lock in the buddy allocator. In particular, __free_pages_prepare() does: page->flags.f &= ~PAGE_FLAGS_CHECK_AT_PREP; This non-atomic read-modify-write, while correctly excluding __PG_HWPOISON from the mask, can still lose a concurrent TestSetPageHWPoison if the read happens before the poison bit is set and the write happens after. Follow-up patches in this series add similar non-atomic flag operations as well. Fix by acquiring zone->lock around TestSetPageHWPoison. This serializes with all buddy flag manipulation. The cost is negligible: one lock/unlock in an extremely rare path (hardware memory errors). Signed-off-by: Michael S. Tsirkin Assisted-by: Claude:claude-opus-4-6 --- mm/memory-failure.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/mm/memory-failure.c b/mm/memory-failure.c index ee42d4361309..a6b61172dd13 100644 --- a/mm/memory-failure.c +++ b/mm/memory-failure.c @@ -2348,6 +2348,8 @@ int memory_failure(unsigned long pfn, int flags) unsigned long page_flags; bool retry = true; int hugetlb = 0; + struct zone *zone; + unsigned long mf_flags; if (!sysctl_memory_failure_recovery) panic("Memory failure on page %lx", pfn); @@ -2390,7 +2392,10 @@ int memory_failure(unsigned long pfn, int flags) if (hugetlb) goto unlock_mutex; + zone = page_zone(p); + spin_lock_irqsave(&zone->lock, mf_flags); if (TestSetPageHWPoison(p)) { + spin_unlock_irqrestore(&zone->lock, mf_flags); res = -EHWPOISON; if (flags & MF_ACTION_REQUIRED) res = kill_accessing_process(current, pfn, flags); @@ -2399,6 +2404,7 @@ int memory_failure(unsigned long pfn, int flags) action_result(pfn, MF_MSG_ALREADY_POISONED, MF_FAILED); goto unlock_mutex; } + spin_unlock_irqrestore(&zone->lock, mf_flags); /* * We need/can do nothing about count=0 pages. -- MST