mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Rashika Kheria <rashika.kheria@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: "David Airlie" <airlied@linux.ie>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Rashika Kheria" <rashika.kheria@gmail.com>,
	"Ondrej Zary" <linux@rainbow-software.org>,
	"Mark Kettenis" <kettenis@openbsd.org>,
	"Christian König" <christian.koenig@amd.com>,
	dri-devel@lists.freedesktop.org, josh@joshtriplett.org
Subject: [PATCH 35/85] drivers: gpu: Move prototype declaration to header file radeon_mode.h
Date: Mon, 6 Jan 2014 21:12:07 +0530	[thread overview]
Message-ID: <22337ba41abeecf9559ea2d0c4ded36ff32a7828.1389018325.git.rashika.kheria@gmail.com> (raw)
In-Reply-To: <b21c9d47bbb72f2134540b852c908a2080f1ed1d.1389018324.git.rashika.kheria@gmail.com>

Move prototype declaration of functions radeon_add_atom_connector() and
radeon_add_legacy_connector() to header file drm/radeon/radeon_mode.h
because  they are used by more than one file.

This eliminates the following warning in drm/radeon/radeon_connectors.c:
drivers/gpu/drm/radeon/radeon_connectors.c:1588:1: warning: no previous prototype for ‘radeon_add_atom_connector’ [-Wmissing-prototypes]
drivers/gpu/drm/radeon/radeon_connectors.c:2020:1: warning: no previous prototype for ‘radeon_add_legacy_connector’ [-Wmissing-prototypes]

Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
---
 drivers/gpu/drm/radeon/radeon_atombios.c |   12 ------------
 drivers/gpu/drm/radeon/radeon_combios.c  |   10 ----------
 drivers/gpu/drm/radeon/radeon_mode.h     |   21 ++++++++++++++++++++-
 3 files changed, 20 insertions(+), 23 deletions(-)

diff --git a/drivers/gpu/drm/radeon/radeon_atombios.c b/drivers/gpu/drm/radeon/radeon_atombios.c
index b3bf270..392ea6e 100644
--- a/drivers/gpu/drm/radeon/radeon_atombios.c
+++ b/drivers/gpu/drm/radeon/radeon_atombios.c
@@ -41,18 +41,6 @@ extern void
 radeon_add_atom_encoder(struct drm_device *dev, uint32_t encoder_enum,
 			uint32_t supported_device, u16 caps);
 
-/* from radeon_connector.c */
-extern void
-radeon_add_atom_connector(struct drm_device *dev,
-			  uint32_t connector_id,
-			  uint32_t supported_device,
-			  int connector_type,
-			  struct radeon_i2c_bus_rec *i2c_bus,
-			  uint32_t igp_lane_info,
-			  uint16_t connector_object_id,
-			  struct radeon_hpd *hpd,
-			  struct radeon_router *router);
-
 /* from radeon_legacy_encoder.c */
 extern void
 radeon_add_legacy_encoder(struct drm_device *dev, uint32_t encoder_enum,
diff --git a/drivers/gpu/drm/radeon/radeon_combios.c b/drivers/gpu/drm/radeon/radeon_combios.c
index 68ce360..e4c1b8d 100644
--- a/drivers/gpu/drm/radeon/radeon_combios.c
+++ b/drivers/gpu/drm/radeon/radeon_combios.c
@@ -43,16 +43,6 @@ radeon_get_encoder_enum(struct drm_device *dev, uint32_t supported_device,
 			uint8_t dac);
 extern void radeon_link_encoder_connector(struct drm_device *dev);
 
-/* from radeon_connector.c */
-extern void
-radeon_add_legacy_connector(struct drm_device *dev,
-			    uint32_t connector_id,
-			    uint32_t supported_device,
-			    int connector_type,
-			    struct radeon_i2c_bus_rec *i2c_bus,
-			    uint16_t connector_object_id,
-			    struct radeon_hpd *hpd);
-
 /* from radeon_legacy_encoder.c */
 extern void
 radeon_add_legacy_encoder(struct drm_device *dev, uint32_t encoder_enum,
diff --git a/drivers/gpu/drm/radeon/radeon_mode.h b/drivers/gpu/drm/radeon/radeon_mode.h
index b2b556b..e841fde 100644
--- a/drivers/gpu/drm/radeon/radeon_mode.h
+++ b/drivers/gpu/drm/radeon/radeon_mode.h
@@ -50,7 +50,6 @@ void
 radeon_combios_connected_scratch_regs(struct drm_connector *connector,
 				      struct drm_encoder *encoder,
 				      bool connected);
-
 enum radeon_rmx_type {
 	RMX_OFF,
 	RMX_FULL,
@@ -629,6 +628,26 @@ struct atom_voltage_table
 	struct atom_voltage_table_entry entries[MAX_VOLTAGE_ENTRIES];
 };
 
+
+void
+radeon_add_atom_connector(struct drm_device *dev,
+			  uint32_t connector_id,
+			  uint32_t supported_device,
+			  int connector_type,
+			  struct radeon_i2c_bus_rec *i2c_bus,
+			  uint32_t igp_lane_info,
+			  uint16_t connector_object_id,
+			  struct radeon_hpd *hpd,
+			  struct radeon_router *router);
+void 
+radeon_add_legacy_connector(struct drm_device *dev,
+			    uint32_t connector_id,
+			    uint32_t supported_device,
+			    int connector_type,
+			    struct radeon_i2c_bus_rec *i2c_bus,
+			    uint16_t connector_object_id,
+			    struct radeon_hpd *hpd);
+
 extern enum radeon_tv_std
 radeon_combios_get_tv_info(struct radeon_device *rdev);
 extern enum radeon_tv_std
-- 
1.7.9.5


  parent reply	other threads:[~2014-01-06 15:42 UTC|newest]

Thread overview: 96+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-06 14:28 [PATCH 01/85] drivers: gpu: Include appropriate header file in drm_usb.c Rashika Kheria
2014-01-06 14:30 ` [PATCH 02/85] drivers: gpu: Mark function as static and remove unused function in ast_main.c Rashika Kheria
2014-01-06 14:32 ` [PATCH 03/85] drivers: gpu: Mark functions as static in ast_mode.c Rashika Kheria
2014-01-06 14:57 ` [PATCH 04/85] drivers: gpu: Mark functions as static in ast_ttm.c Rashika Kheria
2014-01-06 14:59 ` [PATCH 05/85] drivers: gpu: Mark function as static in cirrus_main.c Rashika Kheria
2014-01-06 15:00 ` [PATCH 06/85] drivers: gpu: Mark functions as static in cirrus_mode.c Rashika Kheria
2014-01-06 15:01 ` [PATCH 07/85] drivers: gpu: Mark functions as static and remove unused function in cirrus_ttm.c Rashika Kheria
2014-01-06 15:02 ` [PATCH 08/85] drivers: gpu: Mark function as static in cdv_intel_dp.c Rashika Kheria
2014-01-06 16:17   ` Patrik Jakobsson
2014-01-06 15:03 ` [PATCH 09/85] drivers: gpu: Include appropriate header file in mga_ioc32.c Rashika Kheria
2014-01-06 15:06 ` [PATCH 10/85] drivers: gpu: Mark function as static in mgag200_main.c Rashika Kheria
2014-01-06 15:07 ` [PATCH 11/85] drivers: gpu: Mark functions as static in mgag200_mode.c Rashika Kheria
2014-01-06 15:08 ` [PATCH 12/85] drivers: gpu: Mark functions as static in mgag200_ttm.c Rashika Kheria
2014-01-06 15:09 ` [PATCH 13/85] drivers: gpu: Mark functions as static and remove unused function in nve0.c Rashika Kheria
2014-01-06 15:10 ` [PATCH 14/85] drivers: gpu: Mark function as static in nv94.c Rashika Kheria
2014-01-06 15:11 ` [PATCH 15/85] drivers: gpu: Mark function as static in ctxnvd7.c Rashika Kheria
2014-01-06 15:14   ` Maarten Lankhorst
2014-01-06 15:13 ` [PATCH 16/85] drivers: gpu: Mark functions as static in nvc0.c Rashika Kheria
2014-01-06 15:14 ` [PATCH 17/85] drivers: gpu: Mark function as static in base.c Rashika Kheria
2014-01-06 15:16 ` [PATCH 18/85] drivers: gpu: Mark function as static in nv10_fence.c Rashika Kheria
2014-01-06 15:18 ` [PATCH 19/85] drivers: gpu: Include appropriate header file in overlay.c Rashika Kheria
2014-01-06 15:19 ` [PATCH 20/85] drivers: gpu: Mark function as static in qxl_kms.c Rashika Kheria
2014-01-06 15:20 ` [PATCH 21/85] drivers: gpu: Include appropriate header file in r128_ioc32.c Rashika Kheria
2014-01-06 15:21 ` [PATCH 22/85] drivers: gpu: Mark functions as static in radeon_device.c Rashika Kheria
2014-01-08 16:40   ` Alex Deucher
2014-01-09  0:07     ` Josh Triplett
2014-01-09 14:35       ` Alex Deucher
2014-01-06 15:23 ` [PATCH 23/85] drivers: gpu: Mark function as static in radeon_kms.c Rashika Kheria
2014-01-06 15:24 ` [PATCH 24/85] drivers: gpu: Move prototype declarations to header file from radeon_object.c Rashika Kheria
2014-01-06 15:25 ` [PATCH 25/85] drivers: gpu: Mark function as static in radeon_object.c Rashika Kheria
2014-01-06 15:27 ` [PATCH 27/85] drivers: gpu: Include appropriate header file in radeon_clocks.c Rashika Kheria
2014-01-06 15:28 ` [PATCH 28/85] drivers: gpu: Mark function as static in radeon_gem.c Rashika Kheria
2014-01-06 15:29 ` [PATCH 29/85] drivers: gpu: Include appropriate header file in radeon_ring.c Rashika Kheria
2014-01-06 15:31 ` [PATCH 30/85] drivers: gpu: Move prototype declarations to appropriate header file radeon.h Rashika Kheria
2014-01-06 15:34 ` [PATCH 26/85] drivers: gpu: Include appropriate header file in radeon_legacy_encoders.c Rashika Kheria
2014-01-06 15:36 ` [PATCH 31/85] drivers: gpu: Add static keyword to the definition of KMS_INVALID_IOCTL in radeon_kms.c Rashika Kheria
2014-01-06 15:38 ` [PATCH 32/85] drivers: gpu: Move prototype declarations to header file atombios.h Rashika Kheria
2014-01-06 15:43   ` Deucher, Alexander
2014-01-06 15:39 ` [PATCH 33/85] drivers: gpu: Include appropriate header file in radeon_atombios.c Rashika Kheria
2014-01-06 15:40 ` [PATCH 34/85] drivers: gpu: Move prototype declaration to appropriate header file radeon_mode.h Rashika Kheria
2014-01-06 15:42 ` Rashika Kheria [this message]
2014-01-06 15:43 ` [PATCH 36/85] drivers: gpu: Move prototype declarations to header file radeon_mode.h from radeon_atombios.c and radeon_combios.c Rashika Kheria
2014-01-06 15:44 ` [PATCH 37/85] drivers: gpu: Include appropriate header file in r600_cs.c Rashika Kheria
2014-01-06 15:45 ` [PATCH 38/85] drivers: gpu: Move prototype declaration to header file radeon.h from radeon_acpi.c Rashika Kheria
2014-01-06 15:46 ` [PATCH 39/85] drivers: gpu: Move prototype declaration to header file radeon_mode.h from atombios_i2c.c Rashika Kheria
2014-01-06 15:48 ` [PATCH 40/85] drivers: gpu: Mark function as static in r600_hdmi.c Rashika Kheria
2014-01-06 15:49 ` [PATCH 41/85] drivers: gpu: Include appropriate header file in evergreen_cs.c Rashika Kheria
2014-01-06 15:51 ` [PATCH 42/85] drivers: gpu: Move prototype declarations to header file radeon_asic.h Rashika Kheria
2014-01-06 15:52 ` [PATCH 43/85] drivers: gpu: Move prototype declarations to header file radeon_asic.h from evergreen.c and ni_dma.c Rashika Kheria
2014-01-06 15:53 ` [PATCH 44/85] drivers: gpu: Move prototype declaration to header file radeon_mode.h from radeon_atombios.c and radeon_encoders.c Rashika Kheria
2014-01-06 15:54 ` [PATCH 45/85] drivers: gpu: Include appropriate header file in atombios_encoders.c Rashika Kheria
2014-01-06 15:56 ` [PATCH 46/85] drivers: gpu: Move prototype declarations to header file radeon_mode.h from radeon_i2c.c Rashika Kheria
2014-01-06 15:57 ` [PATCH 47/85] drivers: gpu: Move prototype declarations to appropriate header file radeon_asic.h Rashika Kheria
2014-01-06 15:59 ` [PATCH 48/85] drivers: gpu: Move prototype declaration to header file radeon_asic.h from ci_dpm.c, cik_sdma.c, evergreen.c and kv_dpm.c Rashika Kheria
2014-01-06 16:00 ` [PATCH 49/85] drivers: gpu: Include appropriate header file in r600_dpm.c Rashika Kheria
2014-01-06 16:02 ` [PATCH 50/85] drivers: gpu: Include appropriate header file in rs780_dpm.c Rashika Kheria
2014-01-06 16:04 ` [PATCH 51/85] drivers: gpu: Include appropriate header file in rv6xx_dpm.c Rashika Kheria
2014-01-06 16:06 ` [PATCH 52/85] drivers: gpu: Include appropriate header file in rv770_dpm.c Rashika Kheria
2014-01-06 16:07 ` [PATCH 53/85] drivers: gpu: Remove unused function " Rashika Kheria
2014-01-06 16:08 ` [PATCH 54/85] drivers: gpu: Move prototype declarations to header file rv770_dpm.h Rashika Kheria
2014-01-06 16:10 ` [PATCH 55/85] drivers: gpu: Include appropriate header file in cypress_dpm.c Rashika Kheria
2014-01-06 16:11 ` [PATCH 56/85] drivers: gpu: Remove unused function " Rashika Kheria
2014-01-06 16:13 ` [PATCH 57/85] drivers: gpu: Include appropriate header file in btc_dpm.c Rashika Kheria
2014-01-06 16:14 ` [PATCH 58/85] drivers: gpu: Remove unused function " Rashika Kheria
2014-01-06 16:16 ` [PATCH 59/85] drivers: gpu: Mark function as static and remove unused function in sumo_dpm.c Rashika Kheria
2014-01-06 16:18 ` [PATCH 60/85] drivers: gpu: Include appropriate header file " Rashika Kheria
2014-01-06 16:19 ` [PATCH 61/85] drivers: gpu: Move prototype declaration to header file sumo_dpm.h Rashika Kheria
2014-01-06 16:21 ` [PATCH 62/85] drivers: gpu: Mark functions as static and remove unused function in trinity_dpm.c Rashika Kheria
2014-01-06 16:23 ` [PATCH 63/85] drivers: gpu: Include appropriate header file " Rashika Kheria
2014-01-06 16:25 ` [PATCH 64/85] drivers: gpu: Remove unused function in ni_dpm.c Rashika Kheria
2014-01-06 16:27 ` [PATCH 65/85] drivers: gpu: Include appropriate header file " Rashika Kheria
2014-01-06 16:29 ` [PATCH 66/85] drivers: gpu: Move prototype declarations to header file ni_dpm.h Rashika Kheria
2014-01-06 16:30 ` [PATCH 67/85] drivers: gpu: Include appropriate header file in si_smc.c and remove prototype declaration from header file sislands_smc.h Rashika Kheria
2014-01-06 16:31 ` [PATCH 68/85] drivers: gpu: Remove unused function in si_dpm.c Rashika Kheria
2014-01-06 16:33 ` [PATCH 69/85] drivers: gpu: Move prototype declarations to header file si_dpm.h Rashika Kheria
2014-01-06 16:34 ` [PATCH 70/85] drivers: gpu: Remove unused function in kv_dpm.c Rashika Kheria
2014-01-06 16:35 ` [PATCH 71/85] drivers: gpu: Include appropriate header file in ci_smc.c Rashika Kheria
2014-01-06 16:36 ` [PATCH 72/85] drivers: gpu: Mark functions as static and remove unused function in ci_dpm.c Rashika Kheria
2014-01-06 16:37 ` [PATCH 73/85] drivers: gpu: Include appropriate header file in dce6_afmt.c Rashika Kheria
2014-01-06 16:38 ` [PATCH 74/85] drivers: gpu: Move prototype declarations to header file radeon.h from evergreen_hdmi.c Rashika Kheria
2014-01-06 16:40 ` [PATCH 75/85] drivers: gpu: Move prototype declaration to header file radeon_asic.h from cik.c Rashika Kheria
2014-01-06 16:41 ` [PATCH 76/85] drivers: gpu: Move prototype declaration to header file radeon_drv.h from radeon_drv.c Rashika Kheria
2014-01-07 16:19   ` Alex Deucher
2014-01-06 16:41 ` [PATCH 77/85] drivers: gpu: Mark function as static in sis_drv.c Rashika Kheria
2014-01-06 16:42 ` [PATCH 78/85] drivers: gpu: Mark function as static in ttm_bo.c Rashika Kheria
2014-01-08 12:28   ` Thomas Hellstrom
2014-01-06 16:44 ` [PATCH 79/85] drivers: gpu: Mark function as static in ttm_bo_util.c Rashika Kheria
2014-01-06 16:45 ` [PATCH 80/85] drivers: gpu: Remove unused function in ttm_lock.c Rashika Kheria
2014-01-06 16:47 ` [PATCH 81/85] drivers: gpu: Mark function as static in via_drv.c Rashika Kheria
2014-01-06 16:48 ` [PATCH 82/85] drivers: gpu: Mark functions as static in vmwgfx_kms.c Rashika Kheria
2014-01-07 10:21   ` Jakob Bornecrantz
2014-01-07 10:51     ` Josh Triplett
2014-01-08 12:36       ` Thomas Hellstrom
2014-01-06 16:49 ` [PATCH 83/85] drivers: gpu: Mark functions as static and remove unused function in vmwgfx_resource.c Rashika Kheria
2014-01-06 16:50 ` [PATCH 84/85] drivers: gpu: Mark functions as static in vmwgfx_buffer.c Rashika Kheria
2014-01-06 16:51 ` [PATCH 85/85] drivers: gpu: Mark functions as static in vmwgfx_fence.c Rashika Kheria

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=22337ba41abeecf9559ea2d0c4ded36ff32a7828.1389018325.git.rashika.kheria@gmail.com \
    --to=rashika.kheria@gmail.com \
    --cc=airlied@linux.ie \
    --cc=alexander.deucher@amd.com \
    --cc=christian.koenig@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=josh@joshtriplett.org \
    --cc=kettenis@openbsd.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@rainbow-software.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®