From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-04.galae.net (smtpout-04.galae.net [185.171.202.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 02CA45678D3 for ; Tue, 22 Sep 2026 16:21:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.171.202.116 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790094093; cv=none; b=qwvYRa2K2SUIsgZz6Wd+U5WKyp0yA+UyMA/cP2oPSPY6J7gtYgApAodLFW7cCqjKgQe+3+JYYUaDntivsWa93VRq/Fe473Pwxp+I8cNKh9S+o4wOsiuVehHhBM6JIp2cfnrH3m6YOVbQmFPdJLLdg2nEeLa9k+4vWwd+NwV941s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790094093; c=relaxed/simple; bh=gdeAzbmxYfga89RQN4R10l3Bi3tZiPcNluKubSX3u2s=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=TA1JJpOLtiviZRxsk3agCoQSLH1642L2vjAIgRyyLdITk6DI7Oxppadj8LoHAWrkHGupi1u2UbrpN5hbxFtwzd21jtK9xsaZIsO99vaozXG9802QEv1z/yiH/Up3mCi0WGqGSTGz4S6vEZuq7iOTxU5dgSH/FUG16FnT9uzUG7U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=lZiYlG9E; arc=none smtp.client-ip=185.171.202.116 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="lZiYlG9E" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-04.galae.net (Postfix) with ESMTPS id 9BF4DC5CD79; Tue, 22 Sep 2026 16:22:12 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id C222260580; Tue, 22 Sep 2026 16:21:25 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 3053610329134; Tue, 22 Sep 2026 18:21:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1790094084; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:content-language:in-reply-to:references; bh=tueEJexz8lLxUgLlyuxH3o7C1CivlVOYsyBZG5CEAVY=; b=lZiYlG9ETLEEIJzn1Sfr+mR+MzscyvuHooi/aU6paqgH7Rkl4nltqX8V8CMm7iefDQaYmW oZ1L3ePV2V8qtyH+inEccdDVa8EFjQWX47laMVgBDkn6t4hc/PEuwUz7cOJXSmuK3Mwk9m 7j8d3YPiiviT5ZVerJQ4FTs8T6wT+eMzZSvfmYtO+jK+4L1Yl916K+nTXaE8odWZ6fXnwy flI87G8OkWO5/AyHCdC5Ansk/AmjePUE8ba9bLTpRyUGX54WVW0giWc+Yd/J84gjiOJzUL q42Tw4oZSdVh1gYYjRiP+LjdbZGBg02eqJJlXwEpZlobMs/UKfOnSXr+QlTEzA== Message-ID: <29f42227-d425-4c57-bfb8-e8f34962cef4@bootlin.com> Date: Tue, 22 Sep 2026 18:21:02 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net v4 0/7] net: stmmac: More selftest-related fixes To: Jakub Kicinski Cc: Andrew Lunn , davem@davemloft.net, Eric Dumazet , Paolo Abeni , Russell King , Heiner Kallweit , =?UTF-8?Q?Alexis_Lothor=C3=A9?= , Maxime Coquelin , Alexandre Torgue , Emil Renner Berthing , Minda Chen , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Jan Petrous , Ovidiu Panait , Jose.Abreu@synopsys.com, Nicolai Buchwitz , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, PKneuper@dspace.de, David Laight References: <20260917215339.2022523-1-maxime.chevallier@bootlin.com> <20260921152202.64d4c67a@kernel.org> Content-Language: en-US From: Maxime Chevallier In-Reply-To: <20260921152202.64d4c67a@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Last-TLS-Session-Version: TLSv1.3 Hi Jakub, On 9/22/26 00:22, Jakub Kicinski wrote: > On Thu, 17 Sep 2026 23:53:31 +0200 Maxime Chevallier wrote: >> This is V4 of stmmac selftest fixes, addressing Sashiko's issues over >> the MTU patch. This lead to the introduction of a new one. The >> dev_add_pack races have been addressed, however the double-vlan issue >> stayed there. Ovidiu is actively working on it, let's wait for his work >> to land before fixing that. >> >> Nicolai, I took the liberty of keeping your review tags on affected >> patches, let me know if this isn't ok. >> >> This is another round of stmmac selftest fixes, mostly about the selftests >> themselves but a few things were discovered w.r.t MTU and buffer size >> handling, see patch 5 anf 6. >> >> After this is merged, I consider the selftests to be now reliable enough >> to run them nightly on every stmmac series that's sent, and I'll be requiring >> clean selftests for new glue drivers. > > This got to the top of the stack for me, LMK if none of the AI feedback > is legit. You mentioned the VLAN one, not sure about the rest. > The EEE complaints look like nit picks but also some are easily > addressable? LMK.. I'd say the AI complaints are legit for EEE, but I have mixed feeling about iterating more for that point only. AI points bugs that are related to 3 main classes of problems (for EEE but other patches as well) : - User reconfigures the interface during the ethtool -t run - The selftest outcome depends on how the link was negotiated (worth for Pause and EEE) - Selftests are sensitive to external traffic being received during the selftests run. Obviously we don't want the kernel to crash because of ethtool selftests and that has been addressed, but for now I'd say ethtool selftests failing because of external factors is something we can live with, although we should make them more robust. The main thing is that we've always been subjected to these problems, and addressing that is an entire ordeal in itself. I can followup (my goal is to have all green runs here [1], this already proved useful for at least 2 patches in the past 2 months that broke selftests), so I'll definitely work on the remaining points as followup. Maxime [1] : https://minimaxwell.github.io/stmmac-ci/ (These are just custom tests, I want to switch to the real kselftests eventually, the runner is currently being stress-tested to iron out the last issues before submitting that to netdev-ci)