mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chuck Lever <chuck.lever@oracle.com>
To: Valentin Rothberg <valentinrothberg@gmail.com>
Cc: "J. Bruce Fields" <bfields@redhat.com>,
	Paul Bolle <pebolle@tiscali.nl>,
	Andreas Ruprecht <andreas.ruprecht@fau.de>,
	hengelein Stefan <stefan.hengelein@fau.de>,
	Trond Myklebust <trond.myklebust@primarydata.com>,
	anna.schumaker@netapp.com, davem@davemloft.net,
	linux-kernel@vger.kernel.org
Subject: Re: Documentation: rpcrdma: Merge svcrdma and xprtrdma modules into one
Date: Mon, 6 Jul 2015 11:30:26 -0400	[thread overview]
Message-ID: <2BDBB9B7-9BF0-4480-B1EC-908346C0E40F@oracle.com> (raw)
In-Reply-To: <CAD3Xx4LsvP0A5HCFLwvZuK36QUFdCZEuJNk3jNYM4qNVbrA1_g@mail.gmail.com>

Hi Valentin-


On Jul 6, 2015, at 3:36 AM, Valentin Rothberg <valentinrothberg@gmail.com> wrote:

> On Mon, Jun 22, 2015 at 9:08 AM, Valentin Rothberg
> <valentinrothberg@gmail.com> wrote:
>> Hi Chuck,
>> 
>> your commit ffe1f0df5862 ("rpcrdma: Merge svcrdma and xprtrdma modules
>> into one") has shown up in linux next-20150620.  The commit merges
>> SUNRPC_XPRT_RDMA_CLIENT and SUNRPC_XPRT_RDMA_SERVER into
>> SUNRPC_XPRT_RDMA, but misses to update references in Documentation,
>> see:
>> 
>> Documentation/filesystems/nfs/nfs-rdma.txt:142:
>> SUNRPC_XPRT_RDMA_CLIENT and SUNRPC_XPRT_RDMA_SERVER config options
>> that both
>> Documentation/filesystems/nfs/nfs-rdma.txt:242:
>> (CONFIG_SUNRPC_XPRT_RDMA_SERVER=m in kernel config), load the RDMA
>> Documentation/filesystems/nfs/nfs-rdma.txt:263:
>> (CONFIG_SUNRPC_XPRT_RDMA_CLIENT=m in kernel config), load the RDMA
>> client
>> 
>> I guess that commit 731d5cca8272 ("Documentation: NFS/RDMA: Document
>> separate Kconfig symbols") needs to be reverted as well.
>> 
>> I detected this issue with scripts/checkkconfigsymbols.py.
>> 
>> Kind regards,
>> Valentin
> 
> Hi,
> 
> this is just a kind reminder that the issue above is now present in v4.2-rc1.

I somehow missed your previous note. You can start by reverting
commit 731d5cca8272.

--
Chuck Lever




  reply	other threads:[~2015-07-06 15:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-22  7:08 Valentin Rothberg
2015-07-06  7:36 ` Valentin Rothberg
2015-07-06 15:30   ` Chuck Lever [this message]
2015-07-08 20:41     ` J. Bruce Fields

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2BDBB9B7-9BF0-4480-B1EC-908346C0E40F@oracle.com \
    --to=chuck.lever@oracle.com \
    --cc=andreas.ruprecht@fau.de \
    --cc=anna.schumaker@netapp.com \
    --cc=bfields@redhat.com \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pebolle@tiscali.nl \
    --cc=stefan.hengelein@fau.de \
    --cc=trond.myklebust@primarydata.com \
    --cc=valentinrothberg@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®