mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: matt mooney <mfm@muteddisk.com>
To: Greg KH <greg@kroah.com>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 09/22] staging: usbip: userspace: usbip: modify command failure
Date: Sun, 19 Jun 2011 22:44:39 -0700	[thread overview]
Message-ID: <2bb10c928e0daa3fe8d4010b1f802f4d7052b213.1308547654.git.mfm@muteddisk.com> (raw)
In-Reply-To: <cover.1308547654.git.mfm@muteddisk.com>

When a bad option is given, display a message stating such and output
usage. When a bad command is given, output command help.

Signed-off-by: matt mooney <mfm@muteddisk.com>
---
 drivers/staging/usbip/userspace/src/usbip.c |   13 ++++++++-----
 1 files changed, 8 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/usbip/userspace/src/usbip.c b/drivers/staging/usbip/userspace/src/usbip.c
index cdfe4c2..583b179 100644
--- a/drivers/staging/usbip/userspace/src/usbip.c
+++ b/drivers/staging/usbip/userspace/src/usbip.c
@@ -125,13 +125,13 @@ static int usbip_version(int argc, char *argv[])
 	(void) argc;
 	(void) argv;
 
-	printf("%s\n", usbip_version_string);
+	printf(PROGNAME " (%s)\n", usbip_version_string);
 	return 0;
 }
 
 static int run_command(const struct command *cmd, int argc, char *argv[])
 {
-	dbg("running command: `%s'\n", cmd->name);
+	dbg("running command: `%s'", cmd->name);
 	return cmd->fn(argc, argv);
 }
 
@@ -163,8 +163,11 @@ int main(int argc, char *argv[])
 			usbip_use_syslog = 1;
 			openlog("", LOG_PID, LOG_USER);
 			break;
+		case '?':
+			printf("usbip: invalid option\n");
 		default:
-			goto err_out;
+			usbip_usage();
+			goto out;
 		}
 	}
 
@@ -180,8 +183,8 @@ int main(int argc, char *argv[])
 			}
 	}
 
-err_out:
-	usbip_usage();
+	/* invalid command */
+	usbip_help(0, NULL);
 out:
 	return (rc > -1 ? EXIT_SUCCESS : EXIT_FAILURE);
 }
-- 
1.7.5.2


  parent reply	other threads:[~2011-06-20  5:47 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-20  5:44 [PATCH 00/22] staging: usbip: misc. userspace changes matt mooney
2011-06-20  5:44 ` [PATCH 01/22] staging: usbip: userspace: update cleanup.sh matt mooney
2011-06-20  5:44 ` [PATCH 02/22] staging: usbip: userspace: usbip_common.h: cleanup log macros matt mooney
2011-06-20  5:44 ` [PATCH 03/22] staging: usbip: userspace: usbip_common.h: move enums matt mooney
2011-06-20  5:44 ` [PATCH 04/22] staging: usbip: userspace: usbip_common.h: fixup header includes matt mooney
2011-06-20  5:44 ` [PATCH 05/22] staging: usbip: userspace: libsrc: set program name for logging matt mooney
2011-06-20  5:44 ` [PATCH 06/22] staging: usbip: userspace: usbip.c: add log option matt mooney
2011-06-20  5:44 ` [PATCH 07/22] staging: usbip: userspace: libsrc: remove usbip.h matt mooney
2011-06-20  5:44 ` [PATCH 08/22] staging: usbip: userspace: libsrc: change all output messages to debug matt mooney
2011-06-20  5:44 ` matt mooney [this message]
2011-06-20  5:44 ` [PATCH 10/22] staging: usbip: userspace: utils: remove libsysfs circumvention matt mooney
2011-06-20  5:44 ` [PATCH 11/22] staging: usbip: userspace: utils.c: rewrite modify_match_busid matt mooney
2011-06-20  5:44 ` [PATCH 12/22] staging: usbip: userspace: usbip_bind.c: major rewrite of the implementation matt mooney
2011-06-20  5:44 ` [PATCH 13/22] staging: usbip: userspace: usbip_unbind.c: implement using libsysfs matt mooney
2011-06-20  5:44 ` [PATCH 14/22] staging: usbip: userspace: usbip list: edit output messages matt mooney
2011-06-20  5:44 ` [PATCH 15/22] staging: usbip: userspace: usbip list: move output header matt mooney
2011-06-20  5:44 ` [PATCH 16/22] staging: usbip: userspace: rename stub driver files matt mooney
2011-06-20  5:44 ` [PATCH 17/22] staging: usbip: userspace: usbip_host: update function and variable names matt mooney
2011-06-20  5:44 ` [PATCH 18/22] staging: usbip: userspace: usbipd: major cleanup of daemon matt mooney
2011-06-20  5:44 ` [PATCH 19/22] staging: usbip: userspace: usbip_network.c: coding style cleanup matt mooney
2011-06-20  5:44 ` [PATCH 20/22] staging: usbip: userspace: add new prefix for usbip network code matt mooney
2011-06-20  5:44 ` [PATCH 21/22] staging: usbip: userspace: fix header installation bug matt mooney
2011-06-20  5:44 ` [PATCH 22/22] staging: usbip: userspace: configure.ac: change package data matt mooney
2011-07-06  3:12 ` [PATCH 00/22] staging: usbip: misc. userspace changes Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2bb10c928e0daa3fe8d4010b1f802f4d7052b213.1308547654.git.mfm@muteddisk.com \
    --to=mfm@muteddisk.com \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®