From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E07D3C060B for ; Wed, 20 May 2026 22:20:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779315624; cv=none; b=IH82nWcdvmXKBkmriwaSOZLb0/coXhWggiSzWbh4YelplYNS/+lq6nSsSd41G6/036+ZCHi1p4TjL3vcr5hlXJV+HWJrLAV83uUI1k3AV3c5M922aCtX4zN+0CyGGDZMeYvIguHWnVZMRu4a2C+2mZqURqK2nOJu1oRLkhWEi5Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779315624; c=relaxed/simple; bh=ivSgG/97imSLXWE5yAu9GDoEGm+2i+hvCGOloJMpUro=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=L6gwCiiA2OTXO8M4uxfW6azCbnDxXEOSRtOrCkyyYrlwel5dp0GMG76lNiQKpeUn8s38N0G5yC+YUEnJCEF/+rGh2H6aHH3ysk6Pd8T2luaUKzEY1s6nwm4ftQNdDJkb9pkN99It5t57TPIP80k015UaUYPtc/iYBJfpQ53ifgk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=QjOFcpWd; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=X1UKZ6yI; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="QjOFcpWd"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="X1UKZ6yI" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1779315621; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=piBMwx0YNR4u+eZF7dD5f/57awj2BSKfWqeLUqtqejA=; b=QjOFcpWdQNVCSnM5ANpyENzcuvc0JmLtdWpXpftMJ22M3p/0SlFUzIium+CpizjWR2QR2B kiWs9kgdAysHqx+EBPHO+FeavTz88L+5wAE/ZMhXggjQ3i46mLti/p+R0FDHzJXNnAVHru LnM3I4by3qouVHb13JZV+u3uz03PxiA= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-471-bFX_wMnkNGGXLkoY1gRePw-1; Wed, 20 May 2026 18:20:20 -0400 X-MC-Unique: bFX_wMnkNGGXLkoY1gRePw-1 X-Mimecast-MFC-AGG-ID: bFX_wMnkNGGXLkoY1gRePw_1779315619 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-48eb0da933fso39134635e9.0 for ; Wed, 20 May 2026 15:20:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1779315619; x=1779920419; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=piBMwx0YNR4u+eZF7dD5f/57awj2BSKfWqeLUqtqejA=; b=X1UKZ6yIeBqFw4g2FYk2VCN9WAHPT6fEwJtuWqfhW0fd4/EdHoe8XtZf+IEZq1Hf1i GEp/YQpH2inZJsysIjtnEPo5Bp2BCYds+hsW8umcL5HneTL4Pgu6UrIIt71Jw2FINh3r 6Qoad4hXsQPwjWYbHMwd5NP2jvnAH8uo6xOL/N5RkHc9QpGzPoPDD0c+Rylkt2XJv23s RUWFHsLtiV8ojwoGi9p8Sv65XeFUex3K1P3VMqxwoygSHfMqYFe9ZxdY8kxF7w6KfIPy kfGnDP+0m1u0O3EupgmqyW7AwqhPRSpUk3UWwC03Oe7TRR/L3GMH3LsC7fnYkOZLz4Mj LCOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779315619; x=1779920419; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=piBMwx0YNR4u+eZF7dD5f/57awj2BSKfWqeLUqtqejA=; b=o0z1u7Iuhq83qyqvsJCnYdX304VrXjHnzdBFKGqkcmukkteZF4axje7G+7UI9QT7Is mB+jjhZA4Ggb992/lycpEeSVEB0F4f+T/6p4/fPk0BB9uVWE48RXNsAzkv1vWBf34tB9 jMgAAQZwef0BxNRLd5S5C+wPYDSuPQiWdYb+heoOXSobEObeF5UVuBv72I1eDzy2zPOI Q39W+7l8pPAUVtZfOtwQDDhu8ZmwZqcvLXc5R4gh9wJmLtCfTpnN/GKmMldAMBEG0ySl 0MgH50oWCFxFIejAqr3SEsg5Hxt+A3d4EE0Z9jRydce56RNkxmQmo9RUyz5MTU27Drxh BM5A== X-Gm-Message-State: AOJu0Yy/8zOcZ2gntYAU8B1Ho6cJNS1scNz0IwRAgM3B5h/nMDzUNN1o +8WIKITgSrW4gVUuJR/DSomJ8x1iv3hvGKBjhjrz9Q1BhU7Y4dfatBjF0325ItIUcMUx3sFFwvj Hv//0VILCNZ8W6cI5PsjM7nJu42CGpTKHNfWkN8zPsyYvmsmP9XIjU6wJvCaAS9o+PXpdztjwoZ oEV+v8Ss31+m08gcU79j+y1wAZltAAXU1Es6uMBg9HPtE= X-Gm-Gg: Acq92OF3I+035QyKL96LHuXEAGWo+Iis/3OWygkTQ7qT6t+yEXuSyo1ZSl+6e/xK3Lt skSgpLhKA3Vp34hAm5ZwD3WXbjtLLBBwffKLbnOv3X62TbzpKg9tU1C/sGysERv9wcCOoTzutoD RKPvFY04JudDTSvbCkid9LU3p/wNz8TzTJrjwLCwhuZPPFtdj2VavEtnYgWGVsp/xoM4OhdzGBf yEBq9Uvm3zXHeeZYJ5vKNN8JWqFlOYsE89zEiwaoXwtrBleY06wL8JqwMsKZ7Eed1ftsLksEUB9 6+LY+89w8otdBqniTMqEuZzQMMRcJKT4uy+2QYfMJTKCdzhwiOA7gL5S+ebGF6l5LXFjXjzhW2j Tu3ccQp+Evykf91B6vwNRFPfPpPH8rZwtGL1ZiO+xPaU= X-Received: by 2002:a05:600c:4753:b0:48a:7a10:4f17 with SMTP id 5b1f17b1804b1-490360485f7mr2619535e9.6.1779315618733; Wed, 20 May 2026 15:20:18 -0700 (PDT) X-Received: by 2002:a05:600c:4753:b0:48a:7a10:4f17 with SMTP id 5b1f17b1804b1-490360485f7mr2618645e9.6.1779315618045; Wed, 20 May 2026 15:20:18 -0700 (PDT) Received: from redhat.com (IGLD-80-230-25-45.inter.net.il. [80.230.25.45]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49033d4ad9bsm18916095e9.8.2026.05.20.15.20.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 May 2026 15:20:17 -0700 (PDT) Date: Wed, 20 May 2026 18:20:13 -0400 From: "Michael S. Tsirkin" To: linux-kernel@vger.kernel.org Cc: "David Hildenbrand (Arm)" , Jason Wang , Xuan Zhuo , Eugenio =?utf-8?B?UMOpcmV6?= , Muchun Song , Oscar Salvador , Andrew Morton , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Johannes Weiner , Zi Yan , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Hugh Dickins , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Christoph Lameter , David Rientjes , Roman Gushchin , Harry Yoo , Axel Rasmussen , Yuanchu Xie , Wei Xu , Chris Li , Kairui Song , Kemeng Shi , Nhat Pham , Baoquan He , virtualization@lists.linux.dev, linux-mm@kvack.org, Andrea Arcangeli Subject: [PATCH v8 01/37] mm: mempolicy: fix interleave index for unaligned VMA start Message-ID: <2cc8a28608f548d582c4e5609eb036ac24f7ae6f.1779315441.git.mst@redhat.com> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailer: git-send-email 2.27.0.106.g8ac3dc51b1 X-Mutt-Fcc: =sent The NUMA interleave index formula (addr - vm_start) >> shift gives wrong results when vm_start is not aligned to the folio size: the subtraction before the shift allows low bits to affect the result via borrows. Use (addr >> shift) - (vm_start >> shift) instead, which independently aligns both values before computing the difference. No functional change for current callers: the fix only affects NUMA interleave and weighted-interleave policies. Current large-order callers either pre-align the address (vma_alloc_anon_folio_pmd) or do not use NUMA interleave (drm_pagemap). All other callers use order 0 where the old and new formulas are equivalent. However subsequent patches in this series add large-order callers that pass unaligned fault addresses, making this fix necessary. Signed-off-by: Michael S. Tsirkin Assisted-by: Claude:claude-opus-4-6 Reviewed-by: Gregory Price --- mm/mempolicy.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/mm/mempolicy.c b/mm/mempolicy.c index 4e4421b22b59..b2c21ed1fd84 100644 --- a/mm/mempolicy.c +++ b/mm/mempolicy.c @@ -2049,7 +2049,8 @@ struct mempolicy *get_vma_policy(struct vm_area_struct *vma, if (pol->mode == MPOL_INTERLEAVE || pol->mode == MPOL_WEIGHTED_INTERLEAVE) { *ilx += vma->vm_pgoff >> order; - *ilx += (addr - vma->vm_start) >> (PAGE_SHIFT + order); + *ilx += (addr >> (PAGE_SHIFT + order)) - + (vma->vm_start >> (PAGE_SHIFT + order)); } return pol; } -- MST