From: Bart Van Assche <bvanassche@acm.org>
To: Johannes Thumshirn <Johannes.Thumshirn@wdc.com>,
Zhengyuan Liu <liuzhengyuan@kylinos.cn>, mingo <mingo@kernel.org>,
"alexander.levin" <alexander.levin@microsoft.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Sasha Levin <sashal@kernel.org>
Subject: Re: Compilation error for target liblockdep
Date: Thu, 13 Feb 2020 21:57:43 -0800 [thread overview]
Message-ID: <2ec4aed8-a03a-aa1a-3e01-719f3c2b161d@acm.org> (raw)
In-Reply-To: <SN4PR0401MB359876ED2A2D503638658A679B1A0@SN4PR0401MB3598.namprd04.prod.outlook.com>
On 2020-02-13 04:59, Johannes Thumshirn wrote:
> On 18/11/2019 10:20, Zhengyuan Liu wrote:
>> Hi, guys,
>>
>> I got a compilation error while building target liblockdep and I think I'd
>> better report it to you. The error info showed as bellow:
>>
>> # cd SRC/tools
>> # make liblockdep
>> DESCEND lib/lockdep
>> CC lockdep.o
>> In file included from lockdep.c:33:0:
>> ../../../kernel/locking/lockdep.c:53:28: fatal error: linux/rcupdate.h: No such file or directory
>> compilation terminated.
>> mv: cannot stat './.lockdep.o.tmp': No such file or directory
>> /home/lzy/kernel-upstream/linux-linus-ubuntu/tools/build/Makefile.build:96: recipe for target 'lockdep.o' failed
>> make[2]: *** [lockdep.o] Error 1
>> Makefile:121: recipe for target 'liblockdep-in.o' failed
>> make[1]: *** [liblockdep-in.o] Error 2
>> Makefile:68: recipe for target 'liblockdep' failed
>> make: *** [liblockdep] Error 2
>>
>> BTW, It was introduced by commit a0b0fd53e1e ("locking/lockdep: Free lock classes that are no longer in use").
>
> This error still pops up here on current master
> HEAD: 0bf999f9c5e74c7ecf9dafb527146601e5c848b9
I'm not sure it's worth fixing the tests under tools/lib/lockdep since
keeping these tests working requires modifying the headers under
tools/lib/lockdep/include/ every time the kernel headers under include/
are changed. How about removing tools/lib/lockdep entirely and
converting these lockdep tests to the KUnit framework? KUnit is based on
UML and I think that's a much more robust approach. For more information
about KUnit, see also https://lwn.net/Articles/780985/.
Thanks,
Bart.
next prev parent reply other threads:[~2020-02-14 5:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-18 9:20 Zhengyuan Liu
2019-11-18 23:14 ` Bart Van Assche
[not found] ` <SN4PR0401MB359876ED2A2D503638658A679B1A0@SN4PR0401MB3598.namprd04.prod.outlook.com>
2020-02-14 5:57 ` Bart Van Assche [this message]
[not found] ` <SN4PR0401MB35983B3ACED57F66634CF90E9BDA0@SN4PR0401MB3598.namprd04.prod.outlook.com>
2020-04-15 2:09 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ec4aed8-a03a-aa1a-3e01-719f3c2b161d@acm.org \
--to=bvanassche@acm.org \
--cc=Johannes.Thumshirn@wdc.com \
--cc=alexander.levin@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liuzhengyuan@kylinos.cn \
--cc=mingo@kernel.org \
--cc=sashal@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®