From: "Christian König" <christian.koenig@amd.com>
To: Guchun Chen <guchun.chen@amd.com>,
peterz@infradead.org, mingo@redhat.com, will@kernel.org,
longman@redhat.com, boqun.feng@gmail.com,
linux-kernel@vger.kernel.org,
dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH] locking/rwsem: drop redundant semicolon of down_write_nest_lock
Date: Fri, 14 Jan 2022 09:40:54 +0100 [thread overview]
Message-ID: <33e93f72-0d5a-b624-f58e-c35155bbda1e@amd.com> (raw)
In-Reply-To: <20220114083742.6219-1-guchun.chen@amd.com>
Am 14.01.22 um 09:37 schrieb Guchun Chen:
> Otherwise, braces are needed when using it.
>
> Signed-off-by: Guchun Chen <guchun.chen@amd.com>
Acked-by: Christian König <christian.koenig@amd.com>
Peter any objections that we push this upstream through the drm subsystem?
Thanks,
Christian.
> ---
> include/linux/rwsem.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/rwsem.h b/include/linux/rwsem.h
> index f9348769e558..efa5c324369a 100644
> --- a/include/linux/rwsem.h
> +++ b/include/linux/rwsem.h
> @@ -230,7 +230,7 @@ extern void _down_write_nest_lock(struct rw_semaphore *sem, struct lockdep_map *
> do { \
> typecheck(struct lockdep_map *, &(nest_lock)->dep_map); \
> _down_write_nest_lock(sem, &(nest_lock)->dep_map); \
> -} while (0);
> +} while (0)
>
> /*
> * Take/release a lock when not the owner will release it.
next prev parent reply other threads:[~2022-01-14 8:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-14 8:37 Guchun Chen
2022-01-14 8:40 ` Christian König [this message]
2022-01-14 8:48 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33e93f72-0d5a-b624-f58e-c35155bbda1e@amd.com \
--to=christian.koenig@amd.com \
--cc=boqun.feng@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=guchun.chen@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®