mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Matthieu Baerts <matttbe@kernel.org>
To: Qingfang Deng <qingfang.deng@linux.dev>
Cc: "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Simon Horman <horms@kernel.org>, Shuah Khan <shuah@kernel.org>,
	Felix Maurer <fmaurer@redhat.com>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	Petr Machata <petrm@nvidia.com>,
	linux-kernel@vger.kernel.org, linux-ppp@vger.kernel.org,
	netdev@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net-next v2] selftests: net: add tests for PPPoL2TP
Date: Fri, 22 May 2026 11:43:09 +1000	[thread overview]
Message-ID: <357a49a0-0742-47a6-bba9-6c406dbd6888@kernel.org> (raw)
In-Reply-To: <0e6fa578-15b2-43c5-b5f5-a6e0a34c103b@linux.dev>

Hi Qingfang,

On 21/05/2026 17:18, Qingfang Deng wrote:
> Hi,
> 
> On 2026/5/21 10:24, Matthieu Baerts wrote:
>> Hi Qingfang,
>>
>> On 14/05/2026 11:57, Qingfang Deng wrote:
>>> Add ping, iperf3, and recursion tests for PPPoL2TP.
>> Thank you for the new test!
>>
>> I recently modified NIPA to be able to execute this test by adding
>> xl2tpd 1.3.20, but it looks like this test is flaky:
>>
>>    https://netdev.bots.linux.dev/contest.html?skip=0&test=pppol2tp-sh
>>
>> The results are now ignored.
>>
>> Do you mind fixing that, please?
> 
> 
> Looks like pppd exited unexpectedly, but I could not locally reproduce
> this issue.
> 
> You can start a socat instance to listen on syslog (as done in pppoe.sh
> test) to see what's going on.

If it is already done in another test, and if this is not creating more
troubles, it might be more interesting if this debug mode is always
enabled. I would then recommend sending a patch doing that, than
applying temp modifications only in NIPA, with a risk of causing other
troubles. WDYT?

Cheers,
Matt

  reply	other threads:[~2026-05-22  1:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-14  1:57 Qingfang Deng
2026-05-19  8:22 ` patchwork-bot+netdevbpf
2026-05-21  2:24 ` Matthieu Baerts
2026-05-21  7:18   ` Qingfang Deng
2026-05-22  1:43     ` Matthieu Baerts [this message]
2026-05-22  2:15       ` Qingfang Deng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=357a49a0-0742-47a6-bba9-6c406dbd6888@kernel.org \
    --to=matttbe@kernel.org \
    --cc=bigeasy@linutronix.de \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=fmaurer@redhat.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-ppp@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=petrm@nvidia.com \
    --cc=qingfang.deng@linux.dev \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®