From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Philippe Reynes <tremyfr@gmail.com>,
dave@thedillows.org, davem@davemloft.net
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: 3com: typhoon: fix typhoon_get_link_ksettings
Date: Sun, 6 Nov 2016 12:53:57 +0300 [thread overview]
Message-ID: <37849ac5-8781-00c0-de4c-476ca69ab1bf@cogentembedded.com> (raw)
In-Reply-To: <1478358700-22711-1-git-send-email-tremyfr@gmail.com>
Hello.
On 11/5/2016 6:11 PM, Philippe Reynes wrote:
> When moving from typhoon_get_settings to typhoon_getlink_ksettings
> in the commit commit f7a5537cd2a5 ("net: 3com: typhoon: use new api
One "commit" is enough. :-)
> ethtool_{get|set}_link_ksettings"), we use a local variable supported
> but we forgot to update the struct ethtool_link_ksettings with
> this value.
>
> We also initialize advertising to zero, because otherwise it may
> be uninitialized if no case of the switch (tp->xcvr_select) is used.
>
> Signed-off-by: Philippe Reynes <tremyfr@gmail.com>
[...]
MBR, Sergei
prev parent reply other threads:[~2016-11-06 9:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-05 15:11 Philippe Reynes
2016-11-06 9:53 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37849ac5-8781-00c0-de4c-476ca69ab1bf@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=dave@thedillows.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tremyfr@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®